Re: Review Request 50431: AMBARI-17896: Fix falcon hook classname and classpath for atlas

2016-07-31 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50431/#review144290
---



Please close this review

- Alejandro Fernandez


On July 27, 2016, 1:07 a.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50431/
> ---
> 
> (Updated July 27, 2016, 1:07 a.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17896
> https://issues.apache.org/jira/browse/AMBARI-17896
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed stack advisor for 2.5 and also the param_linux for setting the right 
> conf path
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  ebe3634 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 8d5cdc9 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> f8ba3e9 
> 
> Diff: https://reviews.apache.org/r/50431/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50431: AMBARI-17896: Fix falcon hook classname and classpath for atlas

2016-07-27 Thread Alejandro Fernandez 


> On July 27, 2016, 6:37 p.m., Alejandro Fernandez wrote:
> > Ship It!

Pushed to trunk, commit f428a6b97a52f6dee2e1cf7c78327770fd119ae6
branch-2.4, commit c91d18cac42bacab5d5a3c7745a6339172e2


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50431/#review143774
---


On July 27, 2016, 1:07 a.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50431/
> ---
> 
> (Updated July 27, 2016, 1:07 a.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17896
> https://issues.apache.org/jira/browse/AMBARI-17896
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed stack advisor for 2.5 and also the param_linux for setting the right 
> conf path
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  ebe3634 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 8d5cdc9 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> f8ba3e9 
> 
> Diff: https://reviews.apache.org/r/50431/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50431: AMBARI-17896: Fix falcon hook classname and classpath for atlas

2016-07-27 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50431/#review143772
---




ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py (line 
742)


This is hasattr instead of self.hasattr.
I'll fix it and commit it for you.


- Alejandro Fernandez


On July 27, 2016, 1:07 a.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50431/
> ---
> 
> (Updated July 27, 2016, 1:07 a.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17896
> https://issues.apache.org/jira/browse/AMBARI-17896
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed stack advisor for 2.5 and also the param_linux for setting the right 
> conf path
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  ebe3634 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 8d5cdc9 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> f8ba3e9 
> 
> Diff: https://reviews.apache.org/r/50431/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50431: AMBARI-17896: Fix falcon hook classname and classpath for atlas

2016-07-27 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50431/#review143774
---


Ship it!




Ship It!

- Alejandro Fernandez


On July 27, 2016, 1:07 a.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50431/
> ---
> 
> (Updated July 27, 2016, 1:07 a.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17896
> https://issues.apache.org/jira/browse/AMBARI-17896
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed stack advisor for 2.5 and also the param_linux for setting the right 
> conf path
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  ebe3634 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 8d5cdc9 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> f8ba3e9 
> 
> Diff: https://reviews.apache.org/r/50431/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50431: AMBARI-17896: Fix falcon hook classname and classpath for atlas

2016-07-26 Thread Venkat Ranganathan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50431/
---

(Updated July 26, 2016, 6:07 p.m.)


Review request for Ambari and Alejandro Fernandez.


Changes
---

Sorry - posted the patch without saving the files from the editor


Bugs: AMBARI-17896
https://issues.apache.org/jira/browse/AMBARI-17896


Repository: ambari


Description
---

Fixed stack advisor for 2.5 and also the param_linux for setting the right conf 
path


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
 ebe3634 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
8d5cdc9 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
f8ba3e9 

Diff: https://reviews.apache.org/r/50431/diff/


Testing
---


Thanks,

Venkat Ranganathan

Re: Review Request 50431: AMBARI-17896: Fix falcon hook classname and classpath for atlas

2016-07-26 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50431/#review143621
---




ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py (line 
742)


This is instead hasattr(self, "__atlasFalconHookClassName")


- Alejandro Fernandez


On July 26, 2016, 8:05 p.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50431/
> ---
> 
> (Updated July 26, 2016, 8:05 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17896
> https://issues.apache.org/jira/browse/AMBARI-17896
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed stack advisor for 2.5 and also the param_linux for setting the right 
> conf path
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  ebe3634 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 8d5cdc9 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> f8ba3e9 
> 
> Diff: https://reviews.apache.org/r/50431/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50431: AMBARI-17896: Fix falcon hook classname and classpath for atlas

2016-07-26 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50431/#review143619
---




ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
 (line 158)


Missing colon,



ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
 (line 163)


Missing colon


- Alejandro Fernandez


On July 26, 2016, 8:05 p.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50431/
> ---
> 
> (Updated July 26, 2016, 8:05 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17896
> https://issues.apache.org/jira/browse/AMBARI-17896
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed stack advisor for 2.5 and also the param_linux for setting the right 
> conf path
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  ebe3634 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 8d5cdc9 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> f8ba3e9 
> 
> Diff: https://reviews.apache.org/r/50431/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50431: AMBARI-17896: Fix falcon hook classname and classpath for atlas

2016-07-26 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50431/#review143616
---


Ship it!




Ship It!

- Alejandro Fernandez


On July 26, 2016, 8:05 p.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50431/
> ---
> 
> (Updated July 26, 2016, 8:05 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17896
> https://issues.apache.org/jira/browse/AMBARI-17896
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed stack advisor for 2.5 and also the param_linux for setting the right 
> conf path
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  ebe3634 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 8d5cdc9 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> f8ba3e9 
> 
> Diff: https://reviews.apache.org/r/50431/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50431: AMBARI-17896: Fix falcon hook classname and classpath for atlas

2016-07-26 Thread Venkat Ranganathan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50431/
---

(Updated July 26, 2016, 1:05 p.m.)


Review request for Ambari and Alejandro Fernandez.


Changes
---

Update with Review comments fixed


Bugs: AMBARI-17896
https://issues.apache.org/jira/browse/AMBARI-17896


Repository: ambari


Description
---

Fixed stack advisor for 2.5 and also the param_linux for setting the right conf 
path


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
 ebe3634 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
8d5cdc9 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
f8ba3e9 

Diff: https://reviews.apache.org/r/50431/diff/


Testing
---


Thanks,

Venkat Ranganathan

Re: Review Request 50431: AMBARI-17896: Fix falcon hook classname and classpath for atlas

2016-07-26 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50431/#review143596
---




ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
 (line 163)


"elif" instead in Python



ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py (line 
740)


Please add a comment that a higher stack (HDP 2.5) changes it to use a 
different class name.



ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 
83)


Please use a more pythonic name with "_" between the words, or camelCase.

Also, please add a comment as to why this was done.


- Alejandro Fernandez


On July 26, 2016, 5:12 a.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50431/
> ---
> 
> (Updated July 26, 2016, 5:12 a.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17896
> https://issues.apache.org/jira/browse/AMBARI-17896
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed stack advisor for 2.5 and also the param_linux for setting the right 
> conf path
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  ebe3634 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 8d5cdc9 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> f8ba3e9 
> 
> Diff: https://reviews.apache.org/r/50431/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50431: AMBARI-17896: Fix falcon hook classname and classpath for atlas

2016-07-25 Thread Venkat Ranganathan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50431/
---

(Updated July 25, 2016, 10:12 p.m.)


Review request for Ambari and Alejandro Fernandez.


Changes
---

Modified patch to not duplicate code for falcon advisor


Bugs: AMBARI-17896
https://issues.apache.org/jira/browse/AMBARI-17896


Repository: ambari


Description
---

Fixed stack advisor for 2.5 and also the param_linux for setting the right conf 
path


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
 ebe3634 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
8d5cdc9 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
f8ba3e9 

Diff: https://reviews.apache.org/r/50431/diff/


Testing
---


Thanks,

Venkat Ranganathan

Review Request 50431: AMBARI-17896: Fix falcon hook classname and classpath for atlas

2016-07-25 Thread Venkat Ranganathan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50431/
---

Review request for Ambari and Alejandro Fernandez.


Bugs: AMBARI-17896
https://issues.apache.org/jira/browse/AMBARI-17896


Repository: ambari


Description
---

Fixed stack advisor for 2.5 and also the param_linux for setting the right conf 
path


Diffs
-

  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
 ebe3634 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
315020b 

Diff: https://reviews.apache.org/r/50431/diff/


Testing
---


Thanks,

Venkat Ranganathan