Re: Review Request 50475: AMBARI-17778 Add usage information in ambari-server script
> On July 27, 2016, 10:56 p.m., Nate Cole wrote: > > Ship It! > > Masahiro Tanaka wrote: > Thank you for reviewing. Could you commit it? > > Nate Cole wrote: > Should it be committed to trunk? > > Masahiro Tanaka wrote: > Yes, please. I added "trunk" to "Branch" on this review board. > > Nate Cole wrote: > This has been pushed. Please close this review as Submitted and > appropriate jira as resolved. Thank you for submitting! - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50475/#review143727 --- On Aug. 9, 2016, 8:18 p.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50475/ > --- > > (Updated Aug. 9, 2016, 8:18 p.m.) > > > Review request for Ambari, Nate Cole, Sebastian Toader, Sid Wagle, and Yusaku > Sako. > > > Bugs: AMBARI-17778 > https://issues.apache.org/jira/browse/AMBARI-17778 > > > Repository: ambari > > > Description > --- > > In ambari-server script, there are some lacks of usage information (e.g. > install-mpack, upgrade-mpack.) > > They should be included in usage information. > > > Diffs > - > > ambari-server/sbin/ambari-server 81cf53b > > Diff: https://reviews.apache.org/r/50475/diff/ > > > Testing > --- > > ``` > --1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12818681/AMBARI-17778.patch > against trunk revision . > > +1 @author. The patch does not contain any @author tags. > > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > > +1 core tests. The patch passed unit tests in ambari-server. > > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/7913//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/7913//console > > This message is automatically generated. > ``` > & manual test > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 50475: AMBARI-17778 Add usage information in ambari-server script
> On July 27, 2016, 9:56 a.m., Nate Cole wrote: > > Ship It! > > Masahiro Tanaka wrote: > Thank you for reviewing. Could you commit it? Should it be committed to trunk? - Nate --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50475/#review143727 --- On July 26, 2016, 8:30 p.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50475/ > --- > > (Updated July 26, 2016, 8:30 p.m.) > > > Review request for Ambari, Nate Cole, Sebastian Toader, Sid Wagle, and Yusaku > Sako. > > > Bugs: AMBARI-17778 > https://issues.apache.org/jira/browse/AMBARI-17778 > > > Repository: ambari > > > Description > --- > > In ambari-server script, there are some lacks of usage information (e.g. > install-mpack, upgrade-mpack.) > > They should be included in usage information. > > > Diffs > - > > ambari-server/sbin/ambari-server 81cf53b > > Diff: https://reviews.apache.org/r/50475/diff/ > > > Testing > --- > > ``` > --1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12818681/AMBARI-17778.patch > against trunk revision . > > +1 @author. The patch does not contain any @author tags. > > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > > +1 core tests. The patch passed unit tests in ambari-server. > > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/7913//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/7913//console > > This message is automatically generated. > ``` > & manual test > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 50475: AMBARI-17778 Add usage information in ambari-server script
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50475/#review143727 --- Ship it! Ship It! - Nate Cole On July 26, 2016, 8:30 p.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50475/ > --- > > (Updated July 26, 2016, 8:30 p.m.) > > > Review request for Ambari, Nate Cole, Sebastian Toader, Sid Wagle, and Yusaku > Sako. > > > Bugs: AMBARI-17778 > https://issues.apache.org/jira/browse/AMBARI-17778 > > > Repository: ambari > > > Description > --- > > In ambari-server script, there are some lacks of usage information (e.g. > install-mpack, upgrade-mpack.) > > They should be included in usage information. > > > Diffs > - > > ambari-server/sbin/ambari-server 81cf53b > > Diff: https://reviews.apache.org/r/50475/diff/ > > > Testing > --- > > ``` > --1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12818681/AMBARI-17778.patch > against trunk revision . > > +1 @author. The patch does not contain any @author tags. > > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > > +1 core tests. The patch passed unit tests in ambari-server. > > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/7913//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/7913//console > > This message is automatically generated. > ``` > & manual test > > > Thanks, > > Masahiro Tanaka > >
Review Request 50475: AMBARI-17778 Add usage information in ambari-server script
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50475/ --- Review request for Ambari, Nate Cole, Sebastian Toader, Sid Wagle, and Yusaku Sako. Bugs: AMBARI-17778 https://issues.apache.org/jira/browse/AMBARI-17778 Repository: ambari Description --- In ambari-server script, there are some lacks of usage information (e.g. install-mpack, upgrade-mpack.) They should be included in usage information. Diffs - ambari-server/sbin/ambari-server 81cf53b Diff: https://reviews.apache.org/r/50475/diff/ Testing --- ``` --1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12818681/AMBARI-17778.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in ambari-server. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/7913//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7913//console This message is automatically generated. ``` & manual test Thanks, Masahiro Tanaka
