Re: Review Request 51055: Avoid hardcoded values in blueprint for hive and oozie
> On Aug. 15, 2016, 5:28 p.m., Di Li wrote: > > Ship It! Thank you Di. Could you please help me push this to trunk? - Amruta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51055/#review145773 --- On Aug. 15, 2016, 11:54 p.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51055/ > --- > > (Updated Aug. 15, 2016, 11:54 p.m.) > > > Review request for Ambari, Di Li and Robert Nettleton. > > > Bugs: AMBARI-18140 > https://issues.apache.org/jira/browse/AMBARI-18140 > > > Repository: ambari > > > Description > --- > > If a cluster is created with hardcoded hostnames, exported blueprint > continues to include the hardcoded hostnames for hive and oozie external > database properties. This patch updates the existing maps to included the > missed properties. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > 849e90a > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > 13927f8 > > Diff: https://reviews.apache.org/r/51055/diff/ > > > Testing > --- > > Test cases included in the patch. > Manual testing performed by creating cluster using blueprint with > hive_existing_mysql_host property set. and tested export blueprint on it. > hive_existing_mysql_host was filtered out in the exported blueprint as > expected. > > > Thanks, > > Amruta Borkar > >
Re: Review Request 51055: Avoid hardcoded values in blueprint for hive and oozie
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51055/#review145773 --- Ship it! Ship It! - Di Li On Aug. 12, 2016, 11:48 p.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51055/ > --- > > (Updated Aug. 12, 2016, 11:48 p.m.) > > > Review request for Ambari, Di Li and Robert Nettleton. > > > Bugs: AMBARI-18140 > https://issues.apache.org/jira/browse/AMBARI-18140 > > > Repository: ambari > > > Description > --- > > If a cluster is created with hardcoded hostnames, exported blueprint > continues to include the hardcoded hostnames for hive and oozie external > database properties. This patch updates the existing maps to included the > missed properties. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > 849e90a > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > 13927f8 > > Diff: https://reviews.apache.org/r/51055/diff/ > > > Testing > --- > > Test cases included in the patch > > > Thanks, > > Amruta Borkar > >
Re: Review Request 51055: Avoid hardcoded values in blueprint for hive and oozie
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51055/#review145760 --- Ship it! This patch looks fine to me. Can you please update the review with the manual testing you've done with this patch applied? We'd probably need to make sure that the Blueprint cluster deployment, and a Blueprint export, both function properly with this change applied. Thanks. - Robert Nettleton On Aug. 12, 2016, 11:48 p.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51055/ > --- > > (Updated Aug. 12, 2016, 11:48 p.m.) > > > Review request for Ambari, Di Li and Robert Nettleton. > > > Bugs: AMBARI-18140 > https://issues.apache.org/jira/browse/AMBARI-18140 > > > Repository: ambari > > > Description > --- > > If a cluster is created with hardcoded hostnames, exported blueprint > continues to include the hardcoded hostnames for hive and oozie external > database properties. This patch updates the existing maps to included the > missed properties. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > 849e90a > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > 13927f8 > > Diff: https://reviews.apache.org/r/51055/diff/ > > > Testing > --- > > Test cases included in the patch > > > Thanks, > > Amruta Borkar > >
Review Request 51055: Avoid hardcoded values in blueprint for hive and oozie
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51055/ --- Review request for Ambari, Di Li and Robert Nettleton. Bugs: AMBARI-18140 https://issues.apache.org/jira/browse/AMBARI-18140 Repository: ambari Description --- If a cluster is created with hardcoded hostnames, exported blueprint continues to include the hardcoded hostnames for hive and oozie external database properties. This patch updates the existing maps to included the missed properties. Diffs - ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 849e90a ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 13927f8 Diff: https://reviews.apache.org/r/51055/diff/ Testing --- Test cases included in the patch Thanks, Amruta Borkar
