Re: Review Request 51657: Support round-robin scheduling with failover for monitors with distributed collector

2016-09-08 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51657/
---

(Updated Сен. 8, 2016, 11:58 д.п.)


Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-17456
https://issues.apache.org/jira/browse/AMBARI-17456


Repository: ambari


Description
---

_Tasks_:

- Monitors get a fix set of collector nodes, every restart gets a refresh 
of available collector nodes
- Round-robin the write for available collectors
- Use failed attempts to blacklist collectors
- Use configurable interval to white-list already black-listed collectors.


Diffs (updated)
-

  ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini 
3e5d861 
  ambari-metrics/ambari-metrics-host-monitoring/conf/windows/metric_monitor.ini 
bc2b461 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/blacklisted_set.py
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
 02f0ce3 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py
 c2ee448 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
6997108 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/event_definition.py
 f356b03 
  
ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestEmitter.py
 be0608f 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
 681726f 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
 9b5c864 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
 459ce45 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
 383a0de 

Diff: https://reviews.apache.org/r/51657/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 51657: Support round-robin scheduling with failover for monitors with distributed collector

2016-09-06 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51657/#review147868
---


Fix it, then Ship it!





ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
(line 103)


There should be a log statement here.



ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
 (line 715)


We should not have these congigs in ams-site cause it is not seriealized on 
monitor side.

Rather this should be in ams-env. It would ask for restarting collector but 
that is limitation casue we do not manage the monitopr configs, in future we 
shoould allow monitor confgis managed from Ambari.


- Sid Wagle


On Sept. 6, 2016, 4:53 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51657/
> ---
> 
> (Updated Sept. 6, 2016, 4:53 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-17456
> https://issues.apache.org/jira/browse/AMBARI-17456
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> _Tasks_:
> 
> - Monitors get a fix set of collector nodes, every restart gets a refresh 
> of available collector nodes
> - Round-robin the write for available collectors
> - Use failed attempts to blacklist collectors
> - Use configurable interval to white-list already black-listed collectors.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini 
> 3e5d861 
>   
> ambari-metrics/ambari-metrics-host-monitoring/conf/windows/metric_monitor.ini 
> bc2b461 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/blacklisted_set.py
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
>  02f0ce3 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py
>  c2ee448 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
> 6997108 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/event_definition.py
>  f356b03 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestEmitter.py
>  be0608f 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
>  c02df71 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  fc95aa7 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
>  383a0de 
> 
> Diff: https://reviews.apache.org/r/51657/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 51657: Support round-robin scheduling with failover for monitors with distributed collector

2016-09-06 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51657/
---

(Updated Сен. 6, 2016, 4:53 п.п.)


Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-17456
https://issues.apache.org/jira/browse/AMBARI-17456


Repository: ambari


Description
---

_Tasks_:

- Monitors get a fix set of collector nodes, every restart gets a refresh 
of available collector nodes
- Round-robin the write for available collectors
- Use failed attempts to blacklist collectors
- Use configurable interval to white-list already black-listed collectors.


Diffs
-

  ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini 
3e5d861 
  ambari-metrics/ambari-metrics-host-monitoring/conf/windows/metric_monitor.ini 
bc2b461 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/blacklisted_set.py
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
 02f0ce3 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py
 c2ee448 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
6997108 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/event_definition.py
 f356b03 
  
ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestEmitter.py
 be0608f 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
 c02df71 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
 fc95aa7 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
 383a0de 

Diff: https://reviews.apache.org/r/51657/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Review Request 51657: Support round-robin scheduling with failover for monitors with distributed collector

2016-09-06 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51657/
---

Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-17456
https://issues.apache.org/jira/browse/AMBARI-17456


Repository: ambari


Description
---

_Tasks_:

- Monitors get a fix set of collector nodes, every restart gets a refresh 
of available collector nodes
- Round-robin the write for available collectors
- Use failed attempts to blacklist collectors
- Use configurable interval to white-list already black-listed collectors.


Diffs
-

  ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini 
3e5d861 
  ambari-metrics/ambari-metrics-host-monitoring/conf/windows/metric_monitor.ini 
bc2b461 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/blacklisted_set.py
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
 02f0ce3 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py
 c2ee448 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
6997108 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/event_definition.py
 f356b03 
  
ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestEmitter.py
 be0608f 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
 c02df71 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
 fc95aa7 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
 383a0de 

Diff: https://reviews.apache.org/r/51657/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen