Re: Review Request 52419: AMBARI-18504 Build fails at verify step due to leftover findbugs html file

2016-10-11 Thread Sandor Magyari

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52419/#review152157
---


Ship it!




Ship It!

- Sandor Magyari


On Oct. 11, 2016, 4:38 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52419/
> ---
> 
> (Updated Oct. 11, 2016, 4:38 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Balázs Bence Sári, Laszlo 
> Puskas, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18504
> https://issues.apache.org/jira/browse/AMBARI-18504
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> XSLT transformation should be applied only to `*.xml`.
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml d3ec9ad 
> 
> Diff: https://reviews.apache.org/r/52419/diff/
> 
> 
> Testing
> ---
> 
> ```
> $ mvn -pl ambari-server -DskipTests clean verify
> ...
> [INFO] --- xml-maven-plugin:1.0:transform (default) @ ambari-server ---
> [INFO] Transforming file: 
> /Users/adoroszlai/src/ambari/ambari-server/target/findbugs/findbugsXml.xml
> [INFO] Transformed 1 file(s).
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> ...
> $ ls -1 ambari-server/target/findbugs/
> findbugsXml.html
> findbugsXml.xml
> $ mvn -pl ambari-server -DskipTests verify
> ...
> [INFO] --- xml-maven-plugin:1.0:transform (default) @ ambari-server ---
> [INFO] Transforming file: 
> /Users/adoroszlai/src/ambari/ambari-server/target/findbugs/findbugsXml.xml
> [INFO] Transformed 1 file(s).
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> ...
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>



Re: Review Request 52419: AMBARI-18504 Build fails at verify step due to leftover findbugs html file

2016-10-11 Thread Sebastian Toader

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52419/#review152155
---


Ship it!




Ship It!

- Sebastian Toader


On Oct. 11, 2016, 6:38 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52419/
> ---
> 
> (Updated Oct. 11, 2016, 6:38 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Balázs Bence Sári, Laszlo 
> Puskas, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18504
> https://issues.apache.org/jira/browse/AMBARI-18504
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> XSLT transformation should be applied only to `*.xml`.
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml d3ec9ad 
> 
> Diff: https://reviews.apache.org/r/52419/diff/
> 
> 
> Testing
> ---
> 
> ```
> $ mvn -pl ambari-server -DskipTests clean verify
> ...
> [INFO] --- xml-maven-plugin:1.0:transform (default) @ ambari-server ---
> [INFO] Transforming file: 
> /Users/adoroszlai/src/ambari/ambari-server/target/findbugs/findbugsXml.xml
> [INFO] Transformed 1 file(s).
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> ...
> $ ls -1 ambari-server/target/findbugs/
> findbugsXml.html
> findbugsXml.xml
> $ mvn -pl ambari-server -DskipTests verify
> ...
> [INFO] --- xml-maven-plugin:1.0:transform (default) @ ambari-server ---
> [INFO] Transforming file: 
> /Users/adoroszlai/src/ambari/ambari-server/target/findbugs/findbugsXml.xml
> [INFO] Transformed 1 file(s).
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> ...
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>



Re: Review Request 52419: AMBARI-18504 Build fails at verify step due to leftover findbugs html file

2016-10-11 Thread Attila Doroszlai

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52419/
---

(Updated Oct. 11, 2016, 6:37 p.m.)


Review request for Ambari, Alejandro Fernandez, Balázs Bence Sári, Laszlo 
Puskas, Sumit Mohanty, and Sebastian Toader.


Changes
---

Backward compatible with Maven 3.0.5


Bugs: AMBARI-18504
https://issues.apache.org/jira/browse/AMBARI-18504


Repository: ambari


Description
---

XSLT transformation should be applied only to `*.xml`.


Diffs (updated)
-

  ambari-server/pom.xml d3ec9ad 

Diff: https://reviews.apache.org/r/52419/diff/


Testing
---

```
$ mvn -pl ambari-server -DskipTests clean verify
...
[INFO] --- xml-maven-plugin:1.0:transform (default) @ ambari-server ---
[INFO] Transforming file: 
/Users/adoroszlai/src/ambari/ambari-server/target/findbugs/findbugsXml.xml
[INFO] Transformed 1 file(s).
[INFO] 
[INFO] BUILD SUCCESS
...
$ ls -1 ambari-server/target/findbugs/
findbugsXml.html
findbugsXml.xml
$ mvn -pl ambari-server -DskipTests verify
...
[INFO] --- xml-maven-plugin:1.0:transform (default) @ ambari-server ---
[INFO] Transforming file: 
/Users/adoroszlai/src/ambari/ambari-server/target/findbugs/findbugsXml.xml
[INFO] Transformed 1 file(s).
[INFO] 
[INFO] BUILD SUCCESS
...
```


Thanks,

Attila Doroszlai



Re: Review Request 52419: AMBARI-18504 Build fails at verify step due to leftover findbugs html file

2016-10-04 Thread Laszlo Puskas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52419/#review151315
---


Ship it!




Ship It!

- Laszlo Puskas


On Oct. 4, 2016, 9:33 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52419/
> ---
> 
> (Updated Oct. 4, 2016, 9:33 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Balázs Bence Sári, Laszlo 
> Puskas, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18504
> https://issues.apache.org/jira/browse/AMBARI-18504
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> XSLT transformation should be applied only to `*.xml`.
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml e37accd 
> 
> Diff: https://reviews.apache.org/r/52419/diff/
> 
> 
> Testing
> ---
> 
> ```
> $ mvn -pl ambari-server -DskipTests clean verify
> ...
> [INFO] --- xml-maven-plugin:1.0:transform (default) @ ambari-server ---
> [INFO] Transforming file: 
> /Users/adoroszlai/src/ambari/ambari-server/target/findbugs/findbugsXml.xml
> [INFO] Transformed 1 file(s).
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> ...
> $ ls -1 ambari-server/target/findbugs/
> findbugsXml.html
> findbugsXml.xml
> $ mvn -pl ambari-server -DskipTests verify
> ...
> [INFO] --- xml-maven-plugin:1.0:transform (default) @ ambari-server ---
> [INFO] Transforming file: 
> /Users/adoroszlai/src/ambari/ambari-server/target/findbugs/findbugsXml.xml
> [INFO] Transformed 1 file(s).
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> ...
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>



Review Request 52419: AMBARI-18504 Build fails at verify step due to leftover findbugs html file

2016-09-30 Thread Attila Doroszlai

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52419/
---

Review request for Ambari, Balázs Bence Sári, Sumit Mohanty, and Sebastian 
Toader.


Bugs: AMBARI-18504
https://issues.apache.org/jira/browse/AMBARI-18504


Repository: ambari


Description
---

XSLT transformation should be applied only to `*.xml`.


Diffs
-

  ambari-server/pom.xml e37accd 

Diff: https://reviews.apache.org/r/52419/diff/


Testing
---

```
$ mvn -pl ambari-server -DskipTests clean verify
...
[INFO] --- xml-maven-plugin:1.0:transform (default) @ ambari-server ---
[INFO] Transforming file: 
/Users/adoroszlai/src/ambari/ambari-server/target/findbugs/findbugsXml.xml
[INFO] Transformed 1 file(s).
[INFO] 
[INFO] BUILD SUCCESS
...
$ ls -1 ambari-server/target/findbugs/
findbugsXml.html
findbugsXml.xml
$ mvn -pl ambari-server -DskipTests verify
...
[INFO] --- xml-maven-plugin:1.0:transform (default) @ ambari-server ---
[INFO] Transforming file: 
/Users/adoroszlai/src/ambari/ambari-server/target/findbugs/findbugsXml.xml
[INFO] Transformed 1 file(s).
[INFO] 
[INFO] BUILD SUCCESS
...
```


Thanks,

Attila Doroszlai