Re: Review Request 52747: Migration to Bootstrap3 framework

2016-10-13 Thread Yusaku Sako 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52747/#review152522
---


Ship it!




Ship It!

- Yusaku Sako


On Oct. 13, 2016, 1:48 p.m., Aleksandr Kovalenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52747/
> ---
> 
> (Updated Oct. 13, 2016, 1:48 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Zhe (Joe) Wang, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18573
> https://issues.apache.org/jira/browse/AMBARI-18573
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Migrate from Bootstrap2 to Bootstrap3 framework.
> 
> 
> Diffs
> -
> 
>   LICENSE.txt 906c0590c2a749b910139dee2af70e4b4b17c949 
>   ambari-web/app/app.js 53394a055bb5997c3589b0e18413e2f984b6 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.eot PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.svg PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.woff PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.woff2 PRE-CREATION 
>   ambari-web/app/config.js 4550eb8905d6064f44a194d31ee3727c55e9bfb5 
>   ambari-web/app/controllers/application.js 
> dca689f949dfa3583fac3e2d181e2d876716664d 
>   ambari-web/app/controllers/main/admin/service_auto_start.js 
> b425c785770ef05c4b7b519d50645be0f1b655ea 
>   ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 
> d00a652f8da42fba20fb86394e06dcedba18edfc 
>   ambari-web/app/controllers/main/admin/stack_upgrade_history_controller.js 
> f05d366057d75ca47418891c86504f18e8e3f1c4 
>   
> ambari-web/app/controllers/main/alerts/add_alert_definition/step1_controller.js
>  43e25c8c5338d9c264aa8346cce1b12d195f64f0 
>   
> ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js
>  6ca3e786d65cfe515615e10aa141a3d5dca2fbd5 
>   ambari-web/app/controllers/main/alerts/alert_instances_controller.js 
> 5913070d3ba799b6d2415361381aea781b1f313d 
>   ambari-web/app/controllers/main/alerts/manage_alert_groups_controller.js 
> 6ba595738234aa840de8bdbca47884a5d699b843 
>   ambari-web/app/controllers/main/charts/heatmap.js 
> 73d18005202e956b2af4732abf3467a72a7d96f2 
>   ambari-web/app/controllers/main/service/info/summary.js 
> c16bb3fc728fe89743d308e0ab96b073e5a8845f 
>   ambari-web/app/controllers/main/service/manage_config_groups_controller.js 
> 539d03eb3d0c5b0e7ea8e5284b5a1c796d3af3cc 
>   ambari-web/app/controllers/wizard/step10_controller.js 
> 8c4b5dbe371e78fd5cb0bc7e87e0a7a965486f2d 
>   ambari-web/app/controllers/wizard/step1_controller.js 
> a1ebad83cbe9e5082c4cc56b391c7d1a25108e00 
>   ambari-web/app/controllers/wizard/step7/assign_master_controller.js 
> 399000eaac97dc4bcfa121b5b3906db7bf71013f 
>   ambari-web/app/data/host/categories.js 
> 7e010d5fb117bcb9e1c633484748b8b4aaf35f97 
>   ambari-web/app/messages.js 71500810a0993c5c02102bfd0ffa15028f78d842 
>   ambari-web/app/mixins/common/configs/configs_saver.js 
> 6592203d614d55c7940657e56e119d4a2f2809bd 
>   ambari-web/app/mixins/common/widgets/widget_mixin.js 
> 5ec4dd6cad9320220da375891894bc41ece71908 
>   ambari-web/app/mixins/main/dashboard/widgets/editable.js 
> c5d3bb4967d02f7193c32a0212550acf69ae8b5a 
>   ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js 
> b10d386ebfb6624dad507f63904edc6d03665fe3 
>   ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js 
> cbb81b369b98baafe5c7962242812522f53ab823 
>   ambari-web/app/mixins/main/host/details/host_components/decommissionable.js 
> 38d5b1770a53704c650008afc6ab6a1bbda08d1d 
>   ambari-web/app/mixins/main/service/configs/config_overridable.js 
> a8bd273e2ebc25834559224cd0f9d2e78f91 
>   ambari-web/app/mixins/main/service/configs/widget_popover_support.js 
> 96a25781e27d2be364454aa0337ffec21b85aaf1 
>   ambari-web/app/mixins/wizard/wizardProgressPageView.js 
> 81970866b4e9dd158e0a6821c4f53c01df845855 
>   ambari-web/app/models/alerts/alert_config.js 
> efbfebff5840dcdafea7657ff44ba0c7206b05bb 
>   ambari-web/app/models/alerts/alert_definition.js 
> 4da7199320bc925977071b41d2a0ee1c0b03bcbe 
>   ambari-web/app/models/alerts/alert_instance.js 
> b366802acfe56eac234abbe130198c9ae6bc8e00 
>   ambari-web/app/models/authentication.js 
> 436c18410c79928edd33367c99fe9ec94d8454d8 
>   ambari-web/app/models/host_component.js 
> 11ea659089742d261ceb9f31aaecfd668b553bfa 
>   ambari-web/app/models/hosts.js 9275b3e320136d6932e91b18d9f832eeb7d93e4b 
>   ambari-web/app/models/repository.js 
> 0b7ee69d0f108132c9a6b694b3b8918864d784c4 
>   ambari-web/app/router.js 02707711b8c132d2815854a7bc902ac39a034aae 
>

Re: Review Request 52747: Migration to Bootstrap3 framework

2016-10-13 Thread Aleksandr Kovalenko 


> On Окт. 12, 2016, 8:35 п.п., Yusaku Sako wrote:
> > Thanks for moving the ambari bootstrap override as unminified, non-vendor 
> > style.
> > Can we move the Roboto font files back to vendor, though?

done


- Aleksandr


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52747/#review152395
---


On Окт. 13, 2016, 1:48 п.п., Aleksandr Kovalenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52747/
> ---
> 
> (Updated Окт. 13, 2016, 1:48 п.п.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Zhe (Joe) Wang, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18573
> https://issues.apache.org/jira/browse/AMBARI-18573
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Migrate from Bootstrap2 to Bootstrap3 framework.
> 
> 
> Diffs
> -
> 
>   LICENSE.txt 906c0590c2a749b910139dee2af70e4b4b17c949 
>   ambari-web/app/app.js 53394a055bb5997c3589b0e18413e2f984b6 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.eot PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.svg PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.woff PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.woff2 PRE-CREATION 
>   ambari-web/app/config.js 4550eb8905d6064f44a194d31ee3727c55e9bfb5 
>   ambari-web/app/controllers/application.js 
> dca689f949dfa3583fac3e2d181e2d876716664d 
>   ambari-web/app/controllers/main/admin/service_auto_start.js 
> b425c785770ef05c4b7b519d50645be0f1b655ea 
>   ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 
> d00a652f8da42fba20fb86394e06dcedba18edfc 
>   ambari-web/app/controllers/main/admin/stack_upgrade_history_controller.js 
> f05d366057d75ca47418891c86504f18e8e3f1c4 
>   
> ambari-web/app/controllers/main/alerts/add_alert_definition/step1_controller.js
>  43e25c8c5338d9c264aa8346cce1b12d195f64f0 
>   
> ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js
>  6ca3e786d65cfe515615e10aa141a3d5dca2fbd5 
>   ambari-web/app/controllers/main/alerts/alert_instances_controller.js 
> 5913070d3ba799b6d2415361381aea781b1f313d 
>   ambari-web/app/controllers/main/alerts/manage_alert_groups_controller.js 
> 6ba595738234aa840de8bdbca47884a5d699b843 
>   ambari-web/app/controllers/main/charts/heatmap.js 
> 73d18005202e956b2af4732abf3467a72a7d96f2 
>   ambari-web/app/controllers/main/service/info/summary.js 
> c16bb3fc728fe89743d308e0ab96b073e5a8845f 
>   ambari-web/app/controllers/main/service/manage_config_groups_controller.js 
> 539d03eb3d0c5b0e7ea8e5284b5a1c796d3af3cc 
>   ambari-web/app/controllers/wizard/step10_controller.js 
> 8c4b5dbe371e78fd5cb0bc7e87e0a7a965486f2d 
>   ambari-web/app/controllers/wizard/step1_controller.js 
> a1ebad83cbe9e5082c4cc56b391c7d1a25108e00 
>   ambari-web/app/controllers/wizard/step7/assign_master_controller.js 
> 399000eaac97dc4bcfa121b5b3906db7bf71013f 
>   ambari-web/app/data/host/categories.js 
> 7e010d5fb117bcb9e1c633484748b8b4aaf35f97 
>   ambari-web/app/messages.js 71500810a0993c5c02102bfd0ffa15028f78d842 
>   ambari-web/app/mixins/common/configs/configs_saver.js 
> 6592203d614d55c7940657e56e119d4a2f2809bd 
>   ambari-web/app/mixins/common/widgets/widget_mixin.js 
> 5ec4dd6cad9320220da375891894bc41ece71908 
>   ambari-web/app/mixins/main/dashboard/widgets/editable.js 
> c5d3bb4967d02f7193c32a0212550acf69ae8b5a 
>   ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js 
> b10d386ebfb6624dad507f63904edc6d03665fe3 
>   ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js 
> cbb81b369b98baafe5c7962242812522f53ab823 
>   ambari-web/app/mixins/main/host/details/host_components/decommissionable.js 
> 38d5b1770a53704c650008afc6ab6a1bbda08d1d 
>   ambari-web/app/mixins/main/service/configs/config_overridable.js 
> a8bd273e2ebc25834559224cd0f9d2e78f91 
>   ambari-web/app/mixins/main/service/configs/widget_popover_support.js 
> 96a25781e27d2be364454aa0337ffec21b85aaf1 
>   ambari-web/app/mixins/wizard/wizardProgressPageView.js 
> 81970866b4e9dd158e0a6821c4f53c01df845855 
>   ambari-web/app/models/alerts/alert_config.js 
> efbfebff5840dcdafea7657ff44ba0c7206b05bb 
>   ambari-web/app/models/alerts/alert_definition.js 
> 4da7199320bc925977071b41d2a0ee1c0b03bcbe 
>   ambari-web/app/models/alerts/alert_instance.js 
> b366802acfe56eac234abbe130198c9ae6bc8e00 
>   ambari-web/app/models/authentication.js 
> 436c18410c79928edd33367c99fe9ec94d8454d8 
>   ambari-web/app/models/host_component.js 
> 11ea659089742d261ceb9f31aaecfd668b553bfa 
>   ambari-web/app/models/hosts.js

Re: Review Request 52747: Migration to Bootstrap3 framework

2016-10-13 Thread Aleksandr Kovalenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52747/
---

(Updated Окт. 13, 2016, 1:48 п.п.)


Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Zhe (Joe) Wang, 
and Yusaku Sako.


Changes
---

Updated patch to fix open issues.


Bugs: AMBARI-18573
https://issues.apache.org/jira/browse/AMBARI-18573


Repository: ambari


Description
---

Migrate from Bootstrap2 to Bootstrap3 framework.


Diffs (updated)
-

  LICENSE.txt 906c0590c2a749b910139dee2af70e4b4b17c949 
  ambari-web/app/app.js 53394a055bb5997c3589b0e18413e2f984b6 
  ambari-web/app/assets/fonts/glyphicons-halflings-regular.eot PRE-CREATION 
  ambari-web/app/assets/fonts/glyphicons-halflings-regular.svg PRE-CREATION 
  ambari-web/app/assets/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 
  ambari-web/app/assets/fonts/glyphicons-halflings-regular.woff PRE-CREATION 
  ambari-web/app/assets/fonts/glyphicons-halflings-regular.woff2 PRE-CREATION 
  ambari-web/app/config.js 4550eb8905d6064f44a194d31ee3727c55e9bfb5 
  ambari-web/app/controllers/application.js 
dca689f949dfa3583fac3e2d181e2d876716664d 
  ambari-web/app/controllers/main/admin/service_auto_start.js 
b425c785770ef05c4b7b519d50645be0f1b655ea 
  ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 
d00a652f8da42fba20fb86394e06dcedba18edfc 
  ambari-web/app/controllers/main/admin/stack_upgrade_history_controller.js 
f05d366057d75ca47418891c86504f18e8e3f1c4 
  
ambari-web/app/controllers/main/alerts/add_alert_definition/step1_controller.js 
43e25c8c5338d9c264aa8346cce1b12d195f64f0 
  
ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js 
6ca3e786d65cfe515615e10aa141a3d5dca2fbd5 
  ambari-web/app/controllers/main/alerts/alert_instances_controller.js 
5913070d3ba799b6d2415361381aea781b1f313d 
  ambari-web/app/controllers/main/alerts/manage_alert_groups_controller.js 
6ba595738234aa840de8bdbca47884a5d699b843 
  ambari-web/app/controllers/main/charts/heatmap.js 
73d18005202e956b2af4732abf3467a72a7d96f2 
  ambari-web/app/controllers/main/service/info/summary.js 
c16bb3fc728fe89743d308e0ab96b073e5a8845f 
  ambari-web/app/controllers/main/service/manage_config_groups_controller.js 
539d03eb3d0c5b0e7ea8e5284b5a1c796d3af3cc 
  ambari-web/app/controllers/wizard/step10_controller.js 
8c4b5dbe371e78fd5cb0bc7e87e0a7a965486f2d 
  ambari-web/app/controllers/wizard/step1_controller.js 
a1ebad83cbe9e5082c4cc56b391c7d1a25108e00 
  ambari-web/app/controllers/wizard/step7/assign_master_controller.js 
399000eaac97dc4bcfa121b5b3906db7bf71013f 
  ambari-web/app/data/host/categories.js 
7e010d5fb117bcb9e1c633484748b8b4aaf35f97 
  ambari-web/app/messages.js 71500810a0993c5c02102bfd0ffa15028f78d842 
  ambari-web/app/mixins/common/configs/configs_saver.js 
6592203d614d55c7940657e56e119d4a2f2809bd 
  ambari-web/app/mixins/common/widgets/widget_mixin.js 
5ec4dd6cad9320220da375891894bc41ece71908 
  ambari-web/app/mixins/main/dashboard/widgets/editable.js 
c5d3bb4967d02f7193c32a0212550acf69ae8b5a 
  ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js 
b10d386ebfb6624dad507f63904edc6d03665fe3 
  ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js 
cbb81b369b98baafe5c7962242812522f53ab823 
  ambari-web/app/mixins/main/host/details/host_components/decommissionable.js 
38d5b1770a53704c650008afc6ab6a1bbda08d1d 
  ambari-web/app/mixins/main/service/configs/config_overridable.js 
a8bd273e2ebc25834559224cd0f9d2e78f91 
  ambari-web/app/mixins/main/service/configs/widget_popover_support.js 
96a25781e27d2be364454aa0337ffec21b85aaf1 
  ambari-web/app/mixins/wizard/wizardProgressPageView.js 
81970866b4e9dd158e0a6821c4f53c01df845855 
  ambari-web/app/models/alerts/alert_config.js 
efbfebff5840dcdafea7657ff44ba0c7206b05bb 
  ambari-web/app/models/alerts/alert_definition.js 
4da7199320bc925977071b41d2a0ee1c0b03bcbe 
  ambari-web/app/models/alerts/alert_instance.js 
b366802acfe56eac234abbe130198c9ae6bc8e00 
  ambari-web/app/models/authentication.js 
436c18410c79928edd33367c99fe9ec94d8454d8 
  ambari-web/app/models/host_component.js 
11ea659089742d261ceb9f31aaecfd668b553bfa 
  ambari-web/app/models/hosts.js 9275b3e320136d6932e91b18d9f832eeb7d93e4b 
  ambari-web/app/models/repository.js 0b7ee69d0f108132c9a6b694b3b8918864d784c4 
  ambari-web/app/router.js 02707711b8c132d2815854a7bc902ac39a034aae 
  ambari-web/app/routes/activate_hawq_standby_routes.js 
8ab19dba452a33d389f66b030626c87afa2f9489 
  ambari-web/app/routes/add_alert_definition_routes.js 
15d010394e81fae48b63964f3d5e18e02f2e6f03 
  ambari-web/app/routes/add_hawq_standby_routes.js 
d802808e91c99523e166639311b533fe16c87629 
  ambari-web/app/routes/add_host_routes.js 
c733a6665637cd9a8c749a844d531a530abe071b 
  ambari-web/app/routes/add_kerberos_routes.js 
1568577b3a2591c3ac1059c3625d6c64cf0f7913

Re: Review Request 52747: Migration to Bootstrap3 framework

2016-10-12 Thread Yusaku Sako 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52747/#review152395
---



Thanks for moving the ambari bootstrap override as unminified, non-vendor style.
Can we move the Roboto font files back to vendor, though?


LICENSE.txt (line 348)


This should not have been reverted.


- Yusaku Sako


On Oct. 12, 2016, 7:05 p.m., Aleksandr Kovalenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52747/
> ---
> 
> (Updated Oct. 12, 2016, 7:05 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Zhe (Joe) Wang, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18573
> https://issues.apache.org/jira/browse/AMBARI-18573
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Migrate from Bootstrap2 to Bootstrap3 framework.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/app.js 53394a055bb5997c3589b0e18413e2f984b6 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.eot PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.svg PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.woff PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.woff2 PRE-CREATION 
>   ambari-web/app/config.js 4550eb8905d6064f44a194d31ee3727c55e9bfb5 
>   ambari-web/app/controllers/application.js 
> dca689f949dfa3583fac3e2d181e2d876716664d 
>   ambari-web/app/controllers/main/admin/service_auto_start.js 
> b425c785770ef05c4b7b519d50645be0f1b655ea 
>   ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 
> d00a652f8da42fba20fb86394e06dcedba18edfc 
>   ambari-web/app/controllers/main/admin/stack_upgrade_history_controller.js 
> f05d366057d75ca47418891c86504f18e8e3f1c4 
>   
> ambari-web/app/controllers/main/alerts/add_alert_definition/step1_controller.js
>  43e25c8c5338d9c264aa8346cce1b12d195f64f0 
>   
> ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js
>  6ca3e786d65cfe515615e10aa141a3d5dca2fbd5 
>   ambari-web/app/controllers/main/alerts/alert_instances_controller.js 
> 5913070d3ba799b6d2415361381aea781b1f313d 
>   ambari-web/app/controllers/main/alerts/manage_alert_groups_controller.js 
> 6ba595738234aa840de8bdbca47884a5d699b843 
>   ambari-web/app/controllers/main/charts/heatmap.js 
> 73d18005202e956b2af4732abf3467a72a7d96f2 
>   ambari-web/app/controllers/main/service/info/summary.js 
> c16bb3fc728fe89743d308e0ab96b073e5a8845f 
>   ambari-web/app/controllers/main/service/manage_config_groups_controller.js 
> 539d03eb3d0c5b0e7ea8e5284b5a1c796d3af3cc 
>   ambari-web/app/controllers/wizard/step10_controller.js 
> 8c4b5dbe371e78fd5cb0bc7e87e0a7a965486f2d 
>   ambari-web/app/controllers/wizard/step1_controller.js 
> a1ebad83cbe9e5082c4cc56b391c7d1a25108e00 
>   ambari-web/app/controllers/wizard/step7/assign_master_controller.js 
> 399000eaac97dc4bcfa121b5b3906db7bf71013f 
>   ambari-web/app/data/host/categories.js 
> 7e010d5fb117bcb9e1c633484748b8b4aaf35f97 
>   ambari-web/app/messages.js 71500810a0993c5c02102bfd0ffa15028f78d842 
>   ambari-web/app/mixins/common/configs/configs_saver.js 
> 6592203d614d55c7940657e56e119d4a2f2809bd 
>   ambari-web/app/mixins/common/widgets/widget_mixin.js 
> 5ec4dd6cad9320220da375891894bc41ece71908 
>   ambari-web/app/mixins/main/dashboard/widgets/editable.js 
> c5d3bb4967d02f7193c32a0212550acf69ae8b5a 
>   ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js 
> b10d386ebfb6624dad507f63904edc6d03665fe3 
>   ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js 
> cbb81b369b98baafe5c7962242812522f53ab823 
>   ambari-web/app/mixins/main/host/details/host_components/decommissionable.js 
> 38d5b1770a53704c650008afc6ab6a1bbda08d1d 
>   ambari-web/app/mixins/main/service/configs/config_overridable.js 
> a8bd273e2ebc25834559224cd0f9d2e78f91 
>   ambari-web/app/mixins/main/service/configs/widget_popover_support.js 
> 96a25781e27d2be364454aa0337ffec21b85aaf1 
>   ambari-web/app/mixins/wizard/wizardProgressPageView.js 
> 81970866b4e9dd158e0a6821c4f53c01df845855 
>   ambari-web/app/models/alerts/alert_config.js 
> efbfebff5840dcdafea7657ff44ba0c7206b05bb 
>   ambari-web/app/models/alerts/alert_definition.js 
> 4da7199320bc925977071b41d2a0ee1c0b03bcbe 
>   ambari-web/app/models/alerts/alert_instance.js 
> b366802acfe56eac234abbe130198c9ae6bc8e00 
>   ambari-web/app/models/authentication.js 
> 436c18410c79928edd33367c99fe9ec94d8454d8 
>   ambari-web/app/models/host_component.js 
> 11ea659089742d261ceb9f31aaecfd668b553bfa 
>   ambari-web/app/models/hosts.js

Re: Review Request 52747: Migration to Bootstrap3 framework

2016-10-12 Thread Yusaku Sako 


> On Oct. 11, 2016, 7:42 p.m., Yusaku Sako wrote:
> > ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js,
> >  line 44
> > 
> >
> > glyphicon is duplicated.  This probably has no material impact, but 
> > let's remove this.

I didn't see this fixed in the new patch.


> On Oct. 11, 2016, 7:42 p.m., Yusaku Sako wrote:
> > ambari-web/app/templates/common/configs/widgets/textfield_config_widget.hbs,
> >  line 19
> > 
> >
> > Need to fix this typo

I didn't see this fixed in the new patch.


- Yusaku


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52747/#review152182
---


On Oct. 12, 2016, 7:05 p.m., Aleksandr Kovalenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52747/
> ---
> 
> (Updated Oct. 12, 2016, 7:05 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Zhe (Joe) Wang, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18573
> https://issues.apache.org/jira/browse/AMBARI-18573
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Migrate from Bootstrap2 to Bootstrap3 framework.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/app.js 53394a055bb5997c3589b0e18413e2f984b6 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.eot PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.svg PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.woff PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.woff2 PRE-CREATION 
>   ambari-web/app/config.js 4550eb8905d6064f44a194d31ee3727c55e9bfb5 
>   ambari-web/app/controllers/application.js 
> dca689f949dfa3583fac3e2d181e2d876716664d 
>   ambari-web/app/controllers/main/admin/service_auto_start.js 
> b425c785770ef05c4b7b519d50645be0f1b655ea 
>   ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 
> d00a652f8da42fba20fb86394e06dcedba18edfc 
>   ambari-web/app/controllers/main/admin/stack_upgrade_history_controller.js 
> f05d366057d75ca47418891c86504f18e8e3f1c4 
>   
> ambari-web/app/controllers/main/alerts/add_alert_definition/step1_controller.js
>  43e25c8c5338d9c264aa8346cce1b12d195f64f0 
>   
> ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js
>  6ca3e786d65cfe515615e10aa141a3d5dca2fbd5 
>   ambari-web/app/controllers/main/alerts/alert_instances_controller.js 
> 5913070d3ba799b6d2415361381aea781b1f313d 
>   ambari-web/app/controllers/main/alerts/manage_alert_groups_controller.js 
> 6ba595738234aa840de8bdbca47884a5d699b843 
>   ambari-web/app/controllers/main/charts/heatmap.js 
> 73d18005202e956b2af4732abf3467a72a7d96f2 
>   ambari-web/app/controllers/main/service/info/summary.js 
> c16bb3fc728fe89743d308e0ab96b073e5a8845f 
>   ambari-web/app/controllers/main/service/manage_config_groups_controller.js 
> 539d03eb3d0c5b0e7ea8e5284b5a1c796d3af3cc 
>   ambari-web/app/controllers/wizard/step10_controller.js 
> 8c4b5dbe371e78fd5cb0bc7e87e0a7a965486f2d 
>   ambari-web/app/controllers/wizard/step1_controller.js 
> a1ebad83cbe9e5082c4cc56b391c7d1a25108e00 
>   ambari-web/app/controllers/wizard/step7/assign_master_controller.js 
> 399000eaac97dc4bcfa121b5b3906db7bf71013f 
>   ambari-web/app/data/host/categories.js 
> 7e010d5fb117bcb9e1c633484748b8b4aaf35f97 
>   ambari-web/app/messages.js 71500810a0993c5c02102bfd0ffa15028f78d842 
>   ambari-web/app/mixins/common/configs/configs_saver.js 
> 6592203d614d55c7940657e56e119d4a2f2809bd 
>   ambari-web/app/mixins/common/widgets/widget_mixin.js 
> 5ec4dd6cad9320220da375891894bc41ece71908 
>   ambari-web/app/mixins/main/dashboard/widgets/editable.js 
> c5d3bb4967d02f7193c32a0212550acf69ae8b5a 
>   ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js 
> b10d386ebfb6624dad507f63904edc6d03665fe3 
>   ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js 
> cbb81b369b98baafe5c7962242812522f53ab823 
>   ambari-web/app/mixins/main/host/details/host_components/decommissionable.js 
> 38d5b1770a53704c650008afc6ab6a1bbda08d1d 
>   ambari-web/app/mixins/main/service/configs/config_overridable.js 
> a8bd273e2ebc25834559224cd0f9d2e78f91 
>   ambari-web/app/mixins/main/service/configs/widget_popover_support.js 
> 96a25781e27d2be364454aa0337ffec21b85aaf1 
>   ambari-web/app/mixins/wizard/wizardProgressPageView.js 
> 81970866b4e9dd158e0a6821c4f53c01df845855 
>   ambari-web/app/models/alerts/alert_config.js 
> efbfebff5840dcdafea7657ff44ba0c7206b05bb 
>

Re: Review Request 52747: Migration to Bootstrap3 framework

2016-10-12 Thread Aleksandr Kovalenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52747/
---

(Updated Окт. 12, 2016, 7:05 п.п.)


Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Zhe (Joe) Wang, 
and Yusaku Sako.


Changes
---

Uploaded updated patch


Bugs: AMBARI-18573
https://issues.apache.org/jira/browse/AMBARI-18573


Repository: ambari


Description
---

Migrate from Bootstrap2 to Bootstrap3 framework.


Diffs (updated)
-

  ambari-web/app/app.js 53394a055bb5997c3589b0e18413e2f984b6 
  ambari-web/app/assets/fonts/glyphicons-halflings-regular.eot PRE-CREATION 
  ambari-web/app/assets/fonts/glyphicons-halflings-regular.svg PRE-CREATION 
  ambari-web/app/assets/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 
  ambari-web/app/assets/fonts/glyphicons-halflings-regular.woff PRE-CREATION 
  ambari-web/app/assets/fonts/glyphicons-halflings-regular.woff2 PRE-CREATION 
  ambari-web/app/config.js 4550eb8905d6064f44a194d31ee3727c55e9bfb5 
  ambari-web/app/controllers/application.js 
dca689f949dfa3583fac3e2d181e2d876716664d 
  ambari-web/app/controllers/main/admin/service_auto_start.js 
b425c785770ef05c4b7b519d50645be0f1b655ea 
  ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 
d00a652f8da42fba20fb86394e06dcedba18edfc 
  ambari-web/app/controllers/main/admin/stack_upgrade_history_controller.js 
f05d366057d75ca47418891c86504f18e8e3f1c4 
  
ambari-web/app/controllers/main/alerts/add_alert_definition/step1_controller.js 
43e25c8c5338d9c264aa8346cce1b12d195f64f0 
  
ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js 
6ca3e786d65cfe515615e10aa141a3d5dca2fbd5 
  ambari-web/app/controllers/main/alerts/alert_instances_controller.js 
5913070d3ba799b6d2415361381aea781b1f313d 
  ambari-web/app/controllers/main/alerts/manage_alert_groups_controller.js 
6ba595738234aa840de8bdbca47884a5d699b843 
  ambari-web/app/controllers/main/charts/heatmap.js 
73d18005202e956b2af4732abf3467a72a7d96f2 
  ambari-web/app/controllers/main/service/info/summary.js 
c16bb3fc728fe89743d308e0ab96b073e5a8845f 
  ambari-web/app/controllers/main/service/manage_config_groups_controller.js 
539d03eb3d0c5b0e7ea8e5284b5a1c796d3af3cc 
  ambari-web/app/controllers/wizard/step10_controller.js 
8c4b5dbe371e78fd5cb0bc7e87e0a7a965486f2d 
  ambari-web/app/controllers/wizard/step1_controller.js 
a1ebad83cbe9e5082c4cc56b391c7d1a25108e00 
  ambari-web/app/controllers/wizard/step7/assign_master_controller.js 
399000eaac97dc4bcfa121b5b3906db7bf71013f 
  ambari-web/app/data/host/categories.js 
7e010d5fb117bcb9e1c633484748b8b4aaf35f97 
  ambari-web/app/messages.js 71500810a0993c5c02102bfd0ffa15028f78d842 
  ambari-web/app/mixins/common/configs/configs_saver.js 
6592203d614d55c7940657e56e119d4a2f2809bd 
  ambari-web/app/mixins/common/widgets/widget_mixin.js 
5ec4dd6cad9320220da375891894bc41ece71908 
  ambari-web/app/mixins/main/dashboard/widgets/editable.js 
c5d3bb4967d02f7193c32a0212550acf69ae8b5a 
  ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js 
b10d386ebfb6624dad507f63904edc6d03665fe3 
  ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js 
cbb81b369b98baafe5c7962242812522f53ab823 
  ambari-web/app/mixins/main/host/details/host_components/decommissionable.js 
38d5b1770a53704c650008afc6ab6a1bbda08d1d 
  ambari-web/app/mixins/main/service/configs/config_overridable.js 
a8bd273e2ebc25834559224cd0f9d2e78f91 
  ambari-web/app/mixins/main/service/configs/widget_popover_support.js 
96a25781e27d2be364454aa0337ffec21b85aaf1 
  ambari-web/app/mixins/wizard/wizardProgressPageView.js 
81970866b4e9dd158e0a6821c4f53c01df845855 
  ambari-web/app/models/alerts/alert_config.js 
efbfebff5840dcdafea7657ff44ba0c7206b05bb 
  ambari-web/app/models/alerts/alert_definition.js 
4da7199320bc925977071b41d2a0ee1c0b03bcbe 
  ambari-web/app/models/alerts/alert_instance.js 
b366802acfe56eac234abbe130198c9ae6bc8e00 
  ambari-web/app/models/authentication.js 
436c18410c79928edd33367c99fe9ec94d8454d8 
  ambari-web/app/models/host_component.js 
11ea659089742d261ceb9f31aaecfd668b553bfa 
  ambari-web/app/models/hosts.js 9275b3e320136d6932e91b18d9f832eeb7d93e4b 
  ambari-web/app/models/repository.js 0b7ee69d0f108132c9a6b694b3b8918864d784c4 
  ambari-web/app/router.js 02707711b8c132d2815854a7bc902ac39a034aae 
  ambari-web/app/routes/activate_hawq_standby_routes.js 
8ab19dba452a33d389f66b030626c87afa2f9489 
  ambari-web/app/routes/add_alert_definition_routes.js 
15d010394e81fae48b63964f3d5e18e02f2e6f03 
  ambari-web/app/routes/add_hawq_standby_routes.js 
d802808e91c99523e166639311b533fe16c87629 
  ambari-web/app/routes/add_host_routes.js 
c733a6665637cd9a8c749a844d531a530abe071b 
  ambari-web/app/routes/add_kerberos_routes.js 
1568577b3a2591c3ac1059c3625d6c64cf0f7913 
  ambari-web/app/routes/add_service_routes.js

Re: Review Request 52747: Migration to Bootstrap3 framework

2016-10-11 Thread Yusaku Sako 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52747/#review152182
---




ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js 
(line 44)


glyphicon is duplicated.  This probably has no material impact, but let's 
remove this.



ambari-web/app/templates/common/configs/widgets/textfield_config_widget.hbs 
(line 19)


Need to fix this typo



ambari-web/vendor/theme/bootstrap-ambari.min.css (line 1)


Can we put this in a non-vendor directory, unminified with an appropriate 
license header?


- Yusaku Sako


On Oct. 11, 2016, 6:34 p.m., Aleksandr Kovalenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52747/
> ---
> 
> (Updated Oct. 11, 2016, 6:34 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Zhe (Joe) Wang, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18573
> https://issues.apache.org/jira/browse/AMBARI-18573
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Migrate from Bootstrap2 to Bootstrap3 framework.
> 
> 
> Diffs
> -
> 
>   LICENSE.txt 906c0590c2a749b910139dee2af70e4b4b17c949 
>   ambari-web/app/app.js 53394a055bb5997c3589b0e18413e2f984b6 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.eot PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.svg PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.woff PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.woff2 PRE-CREATION 
>   ambari-web/app/config.js 4550eb8905d6064f44a194d31ee3727c55e9bfb5 
>   ambari-web/app/controllers/application.js 
> dca689f949dfa3583fac3e2d181e2d876716664d 
>   ambari-web/app/controllers/main/admin/service_auto_start.js 
> b425c785770ef05c4b7b519d50645be0f1b655ea 
>   ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 
> d00a652f8da42fba20fb86394e06dcedba18edfc 
>   ambari-web/app/controllers/main/admin/stack_upgrade_history_controller.js 
> f05d366057d75ca47418891c86504f18e8e3f1c4 
>   
> ambari-web/app/controllers/main/alerts/add_alert_definition/step1_controller.js
>  43e25c8c5338d9c264aa8346cce1b12d195f64f0 
>   
> ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js
>  6ca3e786d65cfe515615e10aa141a3d5dca2fbd5 
>   ambari-web/app/controllers/main/alerts/alert_instances_controller.js 
> 5913070d3ba799b6d2415361381aea781b1f313d 
>   ambari-web/app/controllers/main/alerts/manage_alert_groups_controller.js 
> 6ba595738234aa840de8bdbca47884a5d699b843 
>   ambari-web/app/controllers/main/charts/heatmap.js 
> 73d18005202e956b2af4732abf3467a72a7d96f2 
>   ambari-web/app/controllers/main/service/info/summary.js 
> c16bb3fc728fe89743d308e0ab96b073e5a8845f 
>   ambari-web/app/controllers/main/service/manage_config_groups_controller.js 
> 539d03eb3d0c5b0e7ea8e5284b5a1c796d3af3cc 
>   ambari-web/app/controllers/wizard/step10_controller.js 
> 8c4b5dbe371e78fd5cb0bc7e87e0a7a965486f2d 
>   ambari-web/app/controllers/wizard/step1_controller.js 
> a1ebad83cbe9e5082c4cc56b391c7d1a25108e00 
>   ambari-web/app/controllers/wizard/step7/assign_master_controller.js 
> 399000eaac97dc4bcfa121b5b3906db7bf71013f 
>   ambari-web/app/data/host/categories.js 
> 7e010d5fb117bcb9e1c633484748b8b4aaf35f97 
>   ambari-web/app/messages.js 71500810a0993c5c02102bfd0ffa15028f78d842 
>   ambari-web/app/mixins/common/configs/configs_saver.js 
> 6592203d614d55c7940657e56e119d4a2f2809bd 
>   ambari-web/app/mixins/common/widgets/widget_mixin.js 
> 5ec4dd6cad9320220da375891894bc41ece71908 
>   ambari-web/app/mixins/main/dashboard/widgets/editable.js 
> c5d3bb4967d02f7193c32a0212550acf69ae8b5a 
>   ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js 
> b10d386ebfb6624dad507f63904edc6d03665fe3 
>   ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js 
> cbb81b369b98baafe5c7962242812522f53ab823 
>   ambari-web/app/mixins/main/host/details/host_components/decommissionable.js 
> 38d5b1770a53704c650008afc6ab6a1bbda08d1d 
>   ambari-web/app/mixins/main/service/configs/config_overridable.js 
> a8bd273e2ebc25834559224cd0f9d2e78f91 
>   ambari-web/app/mixins/main/service/configs/widget_popover_support.js 
> 96a25781e27d2be364454aa0337ffec21b85aaf1 
>   ambari-web/app/mixins/wizard/wizardProgressPageView.js 
> 81970866b4e9dd158e0a6821c4f53c01df845855 
>   ambari-web/app/models/alerts/alert_config.js 
> efbfebff5840dcdafea7657ff44ba0c7206b05bb 
>

Re: Review Request 52747: Migration to Bootstrap3 framework

2016-10-11 Thread Jaimin Jetly 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52747/#review152178
---


Ship it!




Ship It!

- Jaimin Jetly


On Oct. 11, 2016, 6:34 p.m., Aleksandr Kovalenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52747/
> ---
> 
> (Updated Oct. 11, 2016, 6:34 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Zhe (Joe) Wang, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18573
> https://issues.apache.org/jira/browse/AMBARI-18573
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Migrate from Bootstrap2 to Bootstrap3 framework.
> 
> 
> Diffs
> -
> 
>   LICENSE.txt 906c0590c2a749b910139dee2af70e4b4b17c949 
>   ambari-web/app/app.js 53394a055bb5997c3589b0e18413e2f984b6 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.eot PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.svg PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.woff PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.woff2 PRE-CREATION 
>   ambari-web/app/config.js 4550eb8905d6064f44a194d31ee3727c55e9bfb5 
>   ambari-web/app/controllers/application.js 
> dca689f949dfa3583fac3e2d181e2d876716664d 
>   ambari-web/app/controllers/main/admin/service_auto_start.js 
> b425c785770ef05c4b7b519d50645be0f1b655ea 
>   ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 
> d00a652f8da42fba20fb86394e06dcedba18edfc 
>   ambari-web/app/controllers/main/admin/stack_upgrade_history_controller.js 
> f05d366057d75ca47418891c86504f18e8e3f1c4 
>   
> ambari-web/app/controllers/main/alerts/add_alert_definition/step1_controller.js
>  43e25c8c5338d9c264aa8346cce1b12d195f64f0 
>   
> ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js
>  6ca3e786d65cfe515615e10aa141a3d5dca2fbd5 
>   ambari-web/app/controllers/main/alerts/alert_instances_controller.js 
> 5913070d3ba799b6d2415361381aea781b1f313d 
>   ambari-web/app/controllers/main/alerts/manage_alert_groups_controller.js 
> 6ba595738234aa840de8bdbca47884a5d699b843 
>   ambari-web/app/controllers/main/charts/heatmap.js 
> 73d18005202e956b2af4732abf3467a72a7d96f2 
>   ambari-web/app/controllers/main/service/info/summary.js 
> c16bb3fc728fe89743d308e0ab96b073e5a8845f 
>   ambari-web/app/controllers/main/service/manage_config_groups_controller.js 
> 539d03eb3d0c5b0e7ea8e5284b5a1c796d3af3cc 
>   ambari-web/app/controllers/wizard/step10_controller.js 
> 8c4b5dbe371e78fd5cb0bc7e87e0a7a965486f2d 
>   ambari-web/app/controllers/wizard/step1_controller.js 
> a1ebad83cbe9e5082c4cc56b391c7d1a25108e00 
>   ambari-web/app/controllers/wizard/step7/assign_master_controller.js 
> 399000eaac97dc4bcfa121b5b3906db7bf71013f 
>   ambari-web/app/data/host/categories.js 
> 7e010d5fb117bcb9e1c633484748b8b4aaf35f97 
>   ambari-web/app/messages.js 71500810a0993c5c02102bfd0ffa15028f78d842 
>   ambari-web/app/mixins/common/configs/configs_saver.js 
> 6592203d614d55c7940657e56e119d4a2f2809bd 
>   ambari-web/app/mixins/common/widgets/widget_mixin.js 
> 5ec4dd6cad9320220da375891894bc41ece71908 
>   ambari-web/app/mixins/main/dashboard/widgets/editable.js 
> c5d3bb4967d02f7193c32a0212550acf69ae8b5a 
>   ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js 
> b10d386ebfb6624dad507f63904edc6d03665fe3 
>   ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js 
> cbb81b369b98baafe5c7962242812522f53ab823 
>   ambari-web/app/mixins/main/host/details/host_components/decommissionable.js 
> 38d5b1770a53704c650008afc6ab6a1bbda08d1d 
>   ambari-web/app/mixins/main/service/configs/config_overridable.js 
> a8bd273e2ebc25834559224cd0f9d2e78f91 
>   ambari-web/app/mixins/main/service/configs/widget_popover_support.js 
> 96a25781e27d2be364454aa0337ffec21b85aaf1 
>   ambari-web/app/mixins/wizard/wizardProgressPageView.js 
> 81970866b4e9dd158e0a6821c4f53c01df845855 
>   ambari-web/app/models/alerts/alert_config.js 
> efbfebff5840dcdafea7657ff44ba0c7206b05bb 
>   ambari-web/app/models/alerts/alert_definition.js 
> 4da7199320bc925977071b41d2a0ee1c0b03bcbe 
>   ambari-web/app/models/alerts/alert_instance.js 
> b366802acfe56eac234abbe130198c9ae6bc8e00 
>   ambari-web/app/models/authentication.js 
> 436c18410c79928edd33367c99fe9ec94d8454d8 
>   ambari-web/app/models/host_component.js 
> 11ea659089742d261ceb9f31aaecfd668b553bfa 
>   ambari-web/app/models/hosts.js 9275b3e320136d6932e91b18d9f832eeb7d93e4b 
>   ambari-web/app/models/repository.js 
> 0b7ee69d0f108132c9a6b694b3b8918864d784c4 
>   ambari-web/app/router.js 02707711b8c132d2815854a7bc902ac39a034aae 
>

Review Request 52747: Migration to Bootstrap3 framework

2016-10-11 Thread Aleksandr Kovalenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52747/
---

Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Zhe (Joe) Wang, 
and Yusaku Sako.


Bugs: AMBARI-18573
https://issues.apache.org/jira/browse/AMBARI-18573


Repository: ambari


Description
---

Migrate from Bootstrap2 to Bootstrap3 framework.


Diffs
-

  LICENSE.txt 906c0590c2a749b910139dee2af70e4b4b17c949 
  ambari-web/app/app.js 53394a055bb5997c3589b0e18413e2f984b6 
  ambari-web/app/assets/fonts/glyphicons-halflings-regular.eot PRE-CREATION 
  ambari-web/app/assets/fonts/glyphicons-halflings-regular.svg PRE-CREATION 
  ambari-web/app/assets/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 
  ambari-web/app/assets/fonts/glyphicons-halflings-regular.woff PRE-CREATION 
  ambari-web/app/assets/fonts/glyphicons-halflings-regular.woff2 PRE-CREATION 
  ambari-web/app/config.js 4550eb8905d6064f44a194d31ee3727c55e9bfb5 
  ambari-web/app/controllers/application.js 
dca689f949dfa3583fac3e2d181e2d876716664d 
  ambari-web/app/controllers/main/admin/service_auto_start.js 
b425c785770ef05c4b7b519d50645be0f1b655ea 
  ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 
d00a652f8da42fba20fb86394e06dcedba18edfc 
  ambari-web/app/controllers/main/admin/stack_upgrade_history_controller.js 
f05d366057d75ca47418891c86504f18e8e3f1c4 
  
ambari-web/app/controllers/main/alerts/add_alert_definition/step1_controller.js 
43e25c8c5338d9c264aa8346cce1b12d195f64f0 
  
ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js 
6ca3e786d65cfe515615e10aa141a3d5dca2fbd5 
  ambari-web/app/controllers/main/alerts/alert_instances_controller.js 
5913070d3ba799b6d2415361381aea781b1f313d 
  ambari-web/app/controllers/main/alerts/manage_alert_groups_controller.js 
6ba595738234aa840de8bdbca47884a5d699b843 
  ambari-web/app/controllers/main/charts/heatmap.js 
73d18005202e956b2af4732abf3467a72a7d96f2 
  ambari-web/app/controllers/main/service/info/summary.js 
c16bb3fc728fe89743d308e0ab96b073e5a8845f 
  ambari-web/app/controllers/main/service/manage_config_groups_controller.js 
539d03eb3d0c5b0e7ea8e5284b5a1c796d3af3cc 
  ambari-web/app/controllers/wizard/step10_controller.js 
8c4b5dbe371e78fd5cb0bc7e87e0a7a965486f2d 
  ambari-web/app/controllers/wizard/step1_controller.js 
a1ebad83cbe9e5082c4cc56b391c7d1a25108e00 
  ambari-web/app/controllers/wizard/step7/assign_master_controller.js 
399000eaac97dc4bcfa121b5b3906db7bf71013f 
  ambari-web/app/data/host/categories.js 
7e010d5fb117bcb9e1c633484748b8b4aaf35f97 
  ambari-web/app/messages.js 71500810a0993c5c02102bfd0ffa15028f78d842 
  ambari-web/app/mixins/common/configs/configs_saver.js 
6592203d614d55c7940657e56e119d4a2f2809bd 
  ambari-web/app/mixins/common/widgets/widget_mixin.js 
5ec4dd6cad9320220da375891894bc41ece71908 
  ambari-web/app/mixins/main/dashboard/widgets/editable.js 
c5d3bb4967d02f7193c32a0212550acf69ae8b5a 
  ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js 
b10d386ebfb6624dad507f63904edc6d03665fe3 
  ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js 
cbb81b369b98baafe5c7962242812522f53ab823 
  ambari-web/app/mixins/main/host/details/host_components/decommissionable.js 
38d5b1770a53704c650008afc6ab6a1bbda08d1d 
  ambari-web/app/mixins/main/service/configs/config_overridable.js 
a8bd273e2ebc25834559224cd0f9d2e78f91 
  ambari-web/app/mixins/main/service/configs/widget_popover_support.js 
96a25781e27d2be364454aa0337ffec21b85aaf1 
  ambari-web/app/mixins/wizard/wizardProgressPageView.js 
81970866b4e9dd158e0a6821c4f53c01df845855 
  ambari-web/app/models/alerts/alert_config.js 
efbfebff5840dcdafea7657ff44ba0c7206b05bb 
  ambari-web/app/models/alerts/alert_definition.js 
4da7199320bc925977071b41d2a0ee1c0b03bcbe 
  ambari-web/app/models/alerts/alert_instance.js 
b366802acfe56eac234abbe130198c9ae6bc8e00 
  ambari-web/app/models/authentication.js 
436c18410c79928edd33367c99fe9ec94d8454d8 
  ambari-web/app/models/host_component.js 
11ea659089742d261ceb9f31aaecfd668b553bfa 
  ambari-web/app/models/hosts.js 9275b3e320136d6932e91b18d9f832eeb7d93e4b 
  ambari-web/app/models/repository.js 0b7ee69d0f108132c9a6b694b3b8918864d784c4 
  ambari-web/app/router.js 02707711b8c132d2815854a7bc902ac39a034aae 
  ambari-web/app/routes/activate_hawq_standby_routes.js 
8ab19dba452a33d389f66b030626c87afa2f9489 
  ambari-web/app/routes/add_alert_definition_routes.js 
15d010394e81fae48b63964f3d5e18e02f2e6f03 
  ambari-web/app/routes/add_hawq_standby_routes.js 
d802808e91c99523e166639311b533fe16c87629 
  ambari-web/app/routes/add_host_routes.js 
c733a6665637cd9a8c749a844d531a530abe071b 
  ambari-web/app/routes/add_kerberos_routes.js 
1568577b3a2591c3ac1059c3625d6c64cf0f7913 
  ambari-web/app/routes/add_service_routes.js 
692d186d8a941409b5127fe02115e072d33d0160