Re: Review Request 52822: Ambari Hive View 'Upload Table' does not support UTF8 files with BOM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52822/#review154501 --- Ship it! Ship It! - Pallav Kulshreshtha On Oct. 13, 2016, 8:56 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52822/ > --- > > (Updated Oct. 13, 2016, 8:56 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-18583 > https://issues.apache.org/jira/browse/AMBARI-18583 > > > Repository: ambari > > > Description > --- > > Ealiear BOM characters in the file were creating problem in upload. Now they > are removed using apache commons io library. > > > Diffs > - > > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java > 9800c22 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java > 7dccbd4 > > Diff: https://reviews.apache.org/r/52822/diff/ > > > Testing > --- > > manual testing done to verify support for both Big-endian and little-endian > BOM. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 52822: Ambari Hive View 'Upload Table' does not support UTF8 files with BOM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52822/#review154494 --- Ship it! Ship It! - Gaurav Nagar On Oct. 13, 2016, 8:56 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52822/ > --- > > (Updated Oct. 13, 2016, 8:56 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-18583 > https://issues.apache.org/jira/browse/AMBARI-18583 > > > Repository: ambari > > > Description > --- > > Ealiear BOM characters in the file were creating problem in upload. Now they > are removed using apache commons io library. > > > Diffs > - > > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java > 9800c22 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java > 7dccbd4 > > Diff: https://reviews.apache.org/r/52822/diff/ > > > Testing > --- > > manual testing done to verify support for both Big-endian and little-endian > BOM. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 52822: Ambari Hive View 'Upload Table' does not support UTF8 files with BOM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52822/#review152474 --- Ship it! Ship It! - Ashwin Rajeev On Oct. 13, 2016, 8:56 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52822/ > --- > > (Updated Oct. 13, 2016, 8:56 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-18583 > https://issues.apache.org/jira/browse/AMBARI-18583 > > > Repository: ambari > > > Description > --- > > Ealiear BOM characters in the file were creating problem in upload. Now they > are removed using apache commons io library. > > > Diffs > - > > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java > 9800c22 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java > 7dccbd4 > > Diff: https://reviews.apache.org/r/52822/diff/ > > > Testing > --- > > manual testing done to verify support for both Big-endian and little-endian > BOM. > > > Thanks, > > Nitiraj Rathore > >
Review Request 52822: Ambari Hive View 'Upload Table' does not support UTF8 files with BOM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52822/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. Bugs: AMBARI-18583 https://issues.apache.org/jira/browse/AMBARI-18583 Repository: ambari Description --- Ealiear BOM characters in the file were creating problem in upload. Now they are removed using apache commons io library. Diffs - contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java 9800c22 contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java 7dccbd4 Diff: https://reviews.apache.org/r/52822/diff/ Testing --- manual testing done to verify support for both Big-endian and little-endian BOM. Thanks, Nitiraj Rathore
