Re: Review Request 53356: Perf: Allow running multiple Ambari Agents on the same host

2016-11-02 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53356/#review154541
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Лис. 1, 2016, 10:49 після полудня, Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53356/
> ---
> 
> (Updated Лис. 1, 2016, 10:49 після полудня)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Myroslav Papirkovskyy, Sumit 
> Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18733
> https://issues.apache.org/jira/browse/AMBARI-18733
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently there are limitations to running multiple Ambari Agents on the same 
> host because it uses a single path for
> /etc/ambari-agent/conf/ambari-agent.ini
> /var/run/ambari-agent/ambari-agent.pid
> /var/lib/ambari-agent/data
> /var/log/ambari-agent/
> 
> Ambari Agent already has a way to change the port, log dir, and pid dir 
> through its config file, so we also need it to support its own unique home 
> directory with its own unique config file.
> Furthermore, the agent will have to override its hostname.
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent 30897dd 
>   ambari-agent/conf/windows/service_wrapper.py d031c34 
>   ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 78b34e5 
>   ambari-agent/src/main/python/ambari_agent/Facter.py a1f815d 
>   ambari-agent/src/main/python/ambari_agent/Hardware.py a65c1cd 
>   ambari-agent/src/main/python/ambari_agent/Heartbeat.py 82ea9b6 
>   ambari-agent/src/main/python/ambari_agent/Register.py 2d85b03 
>   ambari-agent/src/main/python/ambari_agent/main.py 8cbb839 
>   ambari-agent/src/test/python/ambari_agent/TestCheckWebUI.py 4980477 
>   ambari-agent/src/test/python/ambari_agent/TestHardware.py 5c014db 
>   ambari-agent/src/test/python/ambari_agent/TestMain.py ffb5d83 
> 
> Diff: https://reviews.apache.org/r/53356/diff/
> 
> 
> Testing
> ---
> 
> Verified on the PERF stack and up to 100 Ambari Agents running on the same 
> host.
> Unit tests passed.
> 
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
> approved: 22 licence.
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main  SUCCESS [  8.093 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.036 
> s]
> [INFO] Ambari Web . SUCCESS [01:35 
> min]
> [INFO] Ambari Views ... SUCCESS [  2.245 
> s]
> [INFO] Ambari Admin View .. SUCCESS [  9.764 
> s]
> [INFO] utility  SUCCESS [  0.294 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.728 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  5.304 
> s]
> [INFO] Ambari Metrics Hadoop Sink . SUCCESS [  5.745 
> s]
> [INFO] Ambari Metrics Flume Sink .. SUCCESS [  3.696 
> s]
> [INFO] Ambari Metrics Kafka Sink .. SUCCESS [  3.889 
> s]
> [INFO] Ambari Metrics Storm Sink .. SUCCESS [  2.480 
> s]
> [INFO] Ambari Metrics Storm Sink (Legacy) . SUCCESS [  1.526 
> s]
> [INFO] Ambari Metrics Collector ... SUCCESS [07:44 
> min]
> [INFO] Ambari Metrics Monitor . SUCCESS [  3.375 
> s]
> [INFO] Ambari Metrics Grafana . SUCCESS [  7.694 
> s]
> [INFO] Ambari Metrics Assembly  SUCCESS [ 16.058 
> s]
> [INFO] Ambari Server .. SUCCESS [23:02 
> min]
> [INFO] Ambari Functional Tests  SUCCESS [  2.103 
> s]
> [INFO] Ambari Agent ... SUCCESS [ 16.735 
> s]
> [INFO] Ambari Client .. SUCCESS [  0.037 
> s]
> [INFO] Ambari Python Client ... SUCCESS [  0.368 
> s]
> [INFO] Ambari Groovy Client ... SUCCESS [  5.294 
> s]
> [INFO] Ambari Shell ... SUCCESS [  0.033 
> s]
> [INFO] Ambari Python Shell  SUCCESS [  0.036 
> s]
> [INFO] Ambari Groovy Shell  SUCCESS [  3.017 
> s]
> [INFO] ambari-logsearch ... SUCCESS [  0.274 
> s]
> [INFO] Ambari Logsearch Appender .. SUCCESS [  0.329 
> s]
> [INFO] Ambari Logsearch Solr Client ...

Re: Review Request 53356: Perf: Allow running multiple Ambari Agents on the same host

2016-11-01 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53356/#review154475
---




ambari-agent/conf/windows/service_wrapper.py (line 127)


All TODOs will be fixed by AMBARI-18734.


- Alejandro Fernandez


On Nov. 1, 2016, 10:49 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53356/
> ---
> 
> (Updated Nov. 1, 2016, 10:49 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Myroslav Papirkovskyy, Sumit 
> Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18733
> https://issues.apache.org/jira/browse/AMBARI-18733
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently there are limitations to running multiple Ambari Agents on the same 
> host because it uses a single path for
> /etc/ambari-agent/conf/ambari-agent.ini
> /var/run/ambari-agent/ambari-agent.pid
> /var/lib/ambari-agent/data
> /var/log/ambari-agent/
> 
> Ambari Agent already has a way to change the port, log dir, and pid dir 
> through its config file, so we also need it to support its own unique home 
> directory with its own unique config file.
> Furthermore, the agent will have to override its hostname.
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent 30897dd 
>   ambari-agent/conf/windows/service_wrapper.py d031c34 
>   ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 78b34e5 
>   ambari-agent/src/main/python/ambari_agent/Facter.py a1f815d 
>   ambari-agent/src/main/python/ambari_agent/Hardware.py a65c1cd 
>   ambari-agent/src/main/python/ambari_agent/Heartbeat.py 82ea9b6 
>   ambari-agent/src/main/python/ambari_agent/Register.py 2d85b03 
>   ambari-agent/src/main/python/ambari_agent/main.py 8cbb839 
>   ambari-agent/src/test/python/ambari_agent/TestCheckWebUI.py 4980477 
>   ambari-agent/src/test/python/ambari_agent/TestHardware.py 5c014db 
>   ambari-agent/src/test/python/ambari_agent/TestMain.py ffb5d83 
> 
> Diff: https://reviews.apache.org/r/53356/diff/
> 
> 
> Testing
> ---
> 
> Verified on the PERF stack and up to 100 Ambari Agents running on the same 
> host.
> Unit tests passed.
> 
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
> approved: 22 licence.
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main  SUCCESS [  8.093 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.036 
> s]
> [INFO] Ambari Web . SUCCESS [01:35 
> min]
> [INFO] Ambari Views ... SUCCESS [  2.245 
> s]
> [INFO] Ambari Admin View .. SUCCESS [  9.764 
> s]
> [INFO] utility  SUCCESS [  0.294 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.728 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  5.304 
> s]
> [INFO] Ambari Metrics Hadoop Sink . SUCCESS [  5.745 
> s]
> [INFO] Ambari Metrics Flume Sink .. SUCCESS [  3.696 
> s]
> [INFO] Ambari Metrics Kafka Sink .. SUCCESS [  3.889 
> s]
> [INFO] Ambari Metrics Storm Sink .. SUCCESS [  2.480 
> s]
> [INFO] Ambari Metrics Storm Sink (Legacy) . SUCCESS [  1.526 
> s]
> [INFO] Ambari Metrics Collector ... SUCCESS [07:44 
> min]
> [INFO] Ambari Metrics Monitor . SUCCESS [  3.375 
> s]
> [INFO] Ambari Metrics Grafana . SUCCESS [  7.694 
> s]
> [INFO] Ambari Metrics Assembly  SUCCESS [ 16.058 
> s]
> [INFO] Ambari Server .. SUCCESS [23:02 
> min]
> [INFO] Ambari Functional Tests  SUCCESS [  2.103 
> s]
> [INFO] Ambari Agent ... SUCCESS [ 16.735 
> s]
> [INFO] Ambari Client .. SUCCESS [  0.037 
> s]
> [INFO] Ambari Python Client ... SUCCESS [  0.368 
> s]
> [INFO] Ambari Groovy Client ... SUCCESS [  5.294 
> s]
> [INFO] Ambari Shell ... SUCCESS [  0.033 
> s]
> [INFO] Ambari Python Shell  SUCCESS [  0.036 
> s]
> [INFO] Ambari Groovy Shell  SUCCESS [  3.017 
> s]
> [INFO] ambari-logsearch ... SUCCESS [  0.274 
> s]
> [INFO] Ambari

Review Request 53356: Perf: Allow running multiple Ambari Agents on the same host

2016-11-01 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53356/
---

Review request for Ambari, Aravindan Vijayan, Myroslav Papirkovskyy, Sumit 
Mohanty, Sid Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-18733
https://issues.apache.org/jira/browse/AMBARI-18733


Repository: ambari


Description
---

Currently there are limitations to running multiple Ambari Agents on the same 
host because it uses a single path for
/etc/ambari-agent/conf/ambari-agent.ini
/var/run/ambari-agent/ambari-agent.pid
/var/lib/ambari-agent/data
/var/log/ambari-agent/

Ambari Agent already has a way to change the port, log dir, and pid dir through 
its config file, so we also need it to support its own unique home directory 
with its own unique config file.
Furthermore, the agent will have to override its hostname.


Diffs
-

  ambari-agent/conf/unix/ambari-agent 30897dd 
  ambari-agent/conf/windows/service_wrapper.py d031c34 
  ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 78b34e5 
  ambari-agent/src/main/python/ambari_agent/Facter.py a1f815d 
  ambari-agent/src/main/python/ambari_agent/Hardware.py a65c1cd 
  ambari-agent/src/main/python/ambari_agent/Heartbeat.py 82ea9b6 
  ambari-agent/src/main/python/ambari_agent/Register.py 2d85b03 
  ambari-agent/src/main/python/ambari_agent/main.py 8cbb839 
  ambari-agent/src/test/python/ambari_agent/TestCheckWebUI.py 4980477 
  ambari-agent/src/test/python/ambari_agent/TestHardware.py 5c014db 
  ambari-agent/src/test/python/ambari_agent/TestMain.py ffb5d83 

Diff: https://reviews.apache.org/r/53356/diff/


Testing
---

Verified on the PERF stack and up to 100 Ambari Agents running on the same host.
Unit tests passed.

[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
approved: 22 licence.
[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main  SUCCESS [  8.093 s]
[INFO] Apache Ambari Project POM .. SUCCESS [  0.036 s]
[INFO] Ambari Web . SUCCESS [01:35 min]
[INFO] Ambari Views ... SUCCESS [  2.245 s]
[INFO] Ambari Admin View .. SUCCESS [  9.764 s]
[INFO] utility  SUCCESS [  0.294 s]
[INFO] ambari-metrics . SUCCESS [  0.728 s]
[INFO] Ambari Metrics Common .. SUCCESS [  5.304 s]
[INFO] Ambari Metrics Hadoop Sink . SUCCESS [  5.745 s]
[INFO] Ambari Metrics Flume Sink .. SUCCESS [  3.696 s]
[INFO] Ambari Metrics Kafka Sink .. SUCCESS [  3.889 s]
[INFO] Ambari Metrics Storm Sink .. SUCCESS [  2.480 s]
[INFO] Ambari Metrics Storm Sink (Legacy) . SUCCESS [  1.526 s]
[INFO] Ambari Metrics Collector ... SUCCESS [07:44 min]
[INFO] Ambari Metrics Monitor . SUCCESS [  3.375 s]
[INFO] Ambari Metrics Grafana . SUCCESS [  7.694 s]
[INFO] Ambari Metrics Assembly  SUCCESS [ 16.058 s]
[INFO] Ambari Server .. SUCCESS [23:02 min]
[INFO] Ambari Functional Tests  SUCCESS [  2.103 s]
[INFO] Ambari Agent ... SUCCESS [ 16.735 s]
[INFO] Ambari Client .. SUCCESS [  0.037 s]
[INFO] Ambari Python Client ... SUCCESS [  0.368 s]
[INFO] Ambari Groovy Client ... SUCCESS [  5.294 s]
[INFO] Ambari Shell ... SUCCESS [  0.033 s]
[INFO] Ambari Python Shell  SUCCESS [  0.036 s]
[INFO] Ambari Groovy Shell  SUCCESS [  3.017 s]
[INFO] ambari-logsearch ... SUCCESS [  0.274 s]
[INFO] Ambari Logsearch Appender .. SUCCESS [  0.329 s]
[INFO] Ambari Logsearch Solr Client ... SUCCESS [  2.076 s]
[INFO] Ambari Logsearch Portal  SUCCESS [  1.739 s]
[INFO] Ambari Logsearch Log Feeder  SUCCESS [  7.252 s]
[INFO] Ambari Logsearch Assembly .. SUCCESS [  0.068 s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 34:14 min
[INFO] Finished at: 2016-11-01T15:43:50-07:00
[INFO] Final Memory: 182M/4025M
[INFO] 


Thanks,

Alejandro Ferna