Re: Review Request 53922: AMBARI-18942 - Auto-start services: Avoid full page reload after "Save" / "Discard"

2016-11-21 Thread Yusaku Sako

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53922/#review156508
---


Ship it!




Ship It!

- Yusaku Sako


On Nov. 19, 2016, 3:10 a.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53922/
> ---
> 
> (Updated Nov. 19, 2016, 3:10 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18942
> https://issues.apache.org/jira/browse/AMBARI-18942
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Avoid reload after save / discard
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/admin/service_auto_start.js b425c78 
>   ambari-web/app/templates/main/admin/service_auto_start.hbs 9dc4dfb 
>   ambari-web/app/views/main/admin/service_auto_start.js dcbbfc9 
>   ambari-web/app/views/main/admin/service_auto_start/component_auto_start.js 
> a25d835 
> 
> Diff: https://reviews.apache.org/r/53922/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster.
> All unit tests passed.
>   25461 tests complete (22 seconds)
>   57 tests pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>



Review Request 53922: AMBARI-18942 - Auto-start services: Avoid full page reload after "Save" / "Discard"

2016-11-18 Thread Richard Zang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53922/
---

Review request for Ambari, Jaimin Jetly, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-18942
https://issues.apache.org/jira/browse/AMBARI-18942


Repository: ambari


Description
---

Avoid reload after save / discard


Diffs
-

  ambari-web/app/controllers/main/admin/service_auto_start.js b425c78 
  ambari-web/app/templates/main/admin/service_auto_start.hbs 9dc4dfb 
  ambari-web/app/views/main/admin/service_auto_start.js dcbbfc9 
  ambari-web/app/views/main/admin/service_auto_start/component_auto_start.js 
a25d835 

Diff: https://reviews.apache.org/r/53922/diff/


Testing
---

Manually tested on live cluster.
All unit tests passed.
  25461 tests complete (22 seconds)
  57 tests pending


Thanks,

Richard Zang