Re: Review Request 54399: Broken links in ambari-server/docs/api/v1/schemas.md

2016-12-09 Thread Masahiro Tanaka


> On 12月 6, 2016, 4:38 p.m., Attila Doroszlai wrote:
> > Ship It!

Thanks again!


- Masahiro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54399/#review158128
---


On 12月 6, 2016, 9:06 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54399/
> ---
> 
> (Updated 12月 6, 2016, 9:06 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Sandor Magyari, and Tom 
> Beerbower.
> 
> 
> Bugs: AMBARI-19076
> https://issues.apache.org/jira/browse/AMBARI-19076
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is very trivial thing. When I see API document on 
> https://github.com/apache/ambari/blob/trunk/ambari-server/docs/api/v1/schemas.md,
>  I can't jump to {code} [POST/PUT/DELETE resource] {code} by clicking the 
> link.
> 
> We can jump to there by using 
> https://github.com/apache/ambari/blob/trunk/ambari-server/docs/api/v1/schemas.md#postputdelete-resource.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/api/v1/schemas.md f52bc10 
> 
> Diff: https://reviews.apache.org/r/54399/diff/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>



Re: Review Request 54399: Broken links in ambari-server/docs/api/v1/schemas.md

2016-12-06 Thread Sandor Magyari

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54399/#review158130
---


Ship it!




Ship It!

- Sandor Magyari


On Dec. 6, 2016, 12:06 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54399/
> ---
> 
> (Updated Dec. 6, 2016, 12:06 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Sandor Magyari, and Tom 
> Beerbower.
> 
> 
> Bugs: AMBARI-19076
> https://issues.apache.org/jira/browse/AMBARI-19076
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is very trivial thing. When I see API document on 
> https://github.com/apache/ambari/blob/trunk/ambari-server/docs/api/v1/schemas.md,
>  I can't jump to {code} [POST/PUT/DELETE resource] {code} by clicking the 
> link.
> 
> We can jump to there by using 
> https://github.com/apache/ambari/blob/trunk/ambari-server/docs/api/v1/schemas.md#postputdelete-resource.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/api/v1/schemas.md f52bc10 
> 
> Diff: https://reviews.apache.org/r/54399/diff/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>



Re: Review Request 54399: Broken links in ambari-server/docs/api/v1/schemas.md

2016-12-05 Thread Attila Doroszlai

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54399/#review158128
---


Ship it!




Ship It!

- Attila Doroszlai


On Dec. 6, 2016, 1:06 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54399/
> ---
> 
> (Updated Dec. 6, 2016, 1:06 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Sandor Magyari, and Tom 
> Beerbower.
> 
> 
> Bugs: AMBARI-19076
> https://issues.apache.org/jira/browse/AMBARI-19076
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is very trivial thing. When I see API document on 
> https://github.com/apache/ambari/blob/trunk/ambari-server/docs/api/v1/schemas.md,
>  I can't jump to {code} [POST/PUT/DELETE resource] {code} by clicking the 
> link.
> 
> We can jump to there by using 
> https://github.com/apache/ambari/blob/trunk/ambari-server/docs/api/v1/schemas.md#postputdelete-resource.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/api/v1/schemas.md f52bc10 
> 
> Diff: https://reviews.apache.org/r/54399/diff/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>



Review Request 54399: Broken links in ambari-server/docs/api/v1/schemas.md

2016-12-05 Thread Masahiro Tanaka

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54399/
---

Review request for Ambari, Attila Doroszlai, Sandor Magyari, and Tom Beerbower.


Bugs: AMBARI-19076
https://issues.apache.org/jira/browse/AMBARI-19076


Repository: ambari


Description
---

This is very trivial thing. When I see API document on 
https://github.com/apache/ambari/blob/trunk/ambari-server/docs/api/v1/schemas.md,
 I can't jump to {code} [POST/PUT/DELETE resource] {code} by clicking the link.

We can jump to there by using 
https://github.com/apache/ambari/blob/trunk/ambari-server/docs/api/v1/schemas.md#postputdelete-resource.


Diffs
-

  ambari-server/docs/api/v1/schemas.md f52bc10 

Diff: https://reviews.apache.org/r/54399/diff/


Testing
---

manually tested


Thanks,

Masahiro Tanaka