Re: Review Request 54667: Add Service Page in Atlas doesn't show config on change

2016-12-12 Thread Alexandr Antonenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54667/#review158882
---


Ship it!




Ship It!

- Alexandr Antonenko


On Dec. 12, 2016, 5:25 p.m., Aleksandr Kovalenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54667/
> ---
> 
> (Updated Dec. 12, 2016, 5:25 p.m.)
> 
> 
> Review request for Ambari and Alexandr Antonenko.
> 
> 
> Bugs: AMBARI-19169
> https://issues.apache.org/jira/browse/AMBARI-19169
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Steps to reproduce:
> Add Atlas service
> Under Authentication Tab > Enable LDAP Authentication
> This will open LDAP/AD section below
> Now in LDAP/AD section > select LDAP Authentication Type as AD, here the 
> properties related to AD are not shown.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/views/common/configs/service_configs_by_category_view.js 
> 16258cf 
>   ambari-web/app/views/common/configs/widgets/config_widget_view.js 62b6057 
> 
> Diff: https://reviews.apache.org/r/54667/diff/
> 
> 
> Testing
> ---
> 
> 19878 tests complete (29 seconds)
>   155 tests pending
> 
> 
> Thanks,
> 
> Aleksandr Kovalenko
> 
>



Re: Review Request 54667: Add Service Page in Atlas doesn't show config on change

2016-12-12 Thread Aleksandr Kovalenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54667/
---

(Updated Дек. 12, 2016, 5:25 п.п.)


Review request for Ambari and Alexandr Antonenko.


Bugs: AMBARI-19169
https://issues.apache.org/jira/browse/AMBARI-19169


Repository: ambari


Description
---

Steps to reproduce:
Add Atlas service
Under Authentication Tab > Enable LDAP Authentication
This will open LDAP/AD section below
Now in LDAP/AD section > select LDAP Authentication Type as AD, here the 
properties related to AD are not shown.


Diffs
-

  ambari-web/app/views/common/configs/service_configs_by_category_view.js 
16258cf 
  ambari-web/app/views/common/configs/widgets/config_widget_view.js 62b6057 

Diff: https://reviews.apache.org/r/54667/diff/


Testing
---

19878 tests complete (29 seconds)
  155 tests pending


Thanks,

Aleksandr Kovalenko



Review Request 54667: Add Service Page in Atlas doesn't show config on change

2016-12-12 Thread Aleksandr Kovalenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54667/
---

Review request for Ambari and Alexandr Antonenko.


Repository: ambari


Description
---

Steps to reproduce:
Add Atlas service
Under Authentication Tab > Enable LDAP Authentication
This will open LDAP/AD section below
Now in LDAP/AD section > select LDAP Authentication Type as AD, here the 
properties related to AD are not shown.


Diffs
-

  ambari-web/app/views/common/configs/service_configs_by_category_view.js 
16258cf 
  ambari-web/app/views/common/configs/widgets/config_widget_view.js 62b6057 

Diff: https://reviews.apache.org/r/54667/diff/


Testing
---

19878 tests complete (29 seconds)
  155 tests pending


Thanks,

Aleksandr Kovalenko