---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54703/#review158994
---
Ship it!
Ship It!
- Alexandr Antonenko
On Dec. 13, 2016, 1:10 p.m., Andriy Babiichuk wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54703/
> ---
>
> (Updated Dec. 13, 2016, 1:10 p.m.)
>
>
> Review request for Ambari and Alexandr Antonenko.
>
>
> Bugs: AMBARI-19189
> https://issues.apache.org/jira/browse/AMBARI-19189
>
>
> Repository: ambari
>
>
> Description
> ---
>
> **STR:**
> 1. Navigate to Hosts details page and click on Add button
> 2. While adding components like ZooKeeper Server and some other host
> components, ambari-web also changes some configurations
>
> **Actual Result:** Before changing configurations, ambari-web warns user that
> a list of configurations will be changed in a modal popup. But UI does not
> show current and the new value that will be changed to the end-user in the
> popup, neither does it allow user to add component without changing
> configurations if user wants to do that
> **Expected Result:** Similar popup with the ux as the one shown for the stack
> advisor recommendation response should be shown which shows current value and
> new value of the config with checkboxes which user can choose to uncheck.
>
>
> Diffs
> -
>
> ambari-web/app/controllers/main/host/details.js ecb3219
> ambari-web/app/messages.js 26f2ce5
> ambari-web/app/templates/common/modal_popups/dependent_configs_list.hbs
> d117dd1
>
> ambari-web/app/templates/main/host/details/addComponentWithConfigsChanges.hbs
> PRE-CREATION
> ambari-web/app/views/common/modal_popups/dependent_configs_list_popup.js
> 728634e
> ambari-web/test/controllers/main/host/details_test.js 9a56ab2
>
> Diff: https://reviews.apache.org/r/54703/diff/
>
>
> Testing
> ---
>
> 19881 tests complete (22 seconds)
> 153 tests pending
>
>
> Thanks,
>
> Andriy Babiichuk
>
>
