Re: Review Request 55062: Improve and Fix "Services page" after new guidelines

2016-12-28 Thread Jaimin Jetly

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55062/#review160250
---


Ship it!




Ship It!

- Jaimin Jetly


On Dec. 28, 2016, 2:52 a.m., Xi Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55062/
> ---
> 
> (Updated Dec. 28, 2016, 2:52 a.m.)
> 
> 
> Review request for Ambari, Richard Zang, Vivek Ratnavel Subramanian, and 
> Yusaku Sako.
> 
> 
> Bugs: AMBARI-19305
> https://issues.apache.org/jira/browse/AMBARI-19305
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Create wizard > Step 2:
> The preview should be centered.
> During "+ Add Metric" selection, when a metric/operator got selected, the 
> submenu should not disappear.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/enhanced_service_dashboard.less 0d549d7 
>   ambari-web/app/views/main/service/widgets/create/expression_view.js 436e3e9 
> 
> Diff: https://reviews.apache.org/r/55062/diff/
> 
> 
> Testing
> ---
> 
> 19829 passing (21s)
> 153 pending
> 
> 
> Thanks,
> 
> Xi Wang
> 
>



Re: Review Request 55062: Improve and Fix "Services page" after new guidelines

2016-12-28 Thread Vivek Ratnavel Subramanian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55062/#review160241
---


Ship it!




Ship It!

- Vivek Ratnavel Subramanian


On Dec. 28, 2016, 2:52 a.m., Xi Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55062/
> ---
> 
> (Updated Dec. 28, 2016, 2:52 a.m.)
> 
> 
> Review request for Ambari, Richard Zang, Vivek Ratnavel Subramanian, and 
> Yusaku Sako.
> 
> 
> Bugs: AMBARI-19305
> https://issues.apache.org/jira/browse/AMBARI-19305
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Create wizard > Step 2:
> The preview should be centered.
> During "+ Add Metric" selection, when a metric/operator got selected, the 
> submenu should not disappear.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/enhanced_service_dashboard.less 0d549d7 
>   ambari-web/app/views/main/service/widgets/create/expression_view.js 436e3e9 
> 
> Diff: https://reviews.apache.org/r/55062/diff/
> 
> 
> Testing
> ---
> 
> 19829 passing (21s)
> 153 pending
> 
> 
> Thanks,
> 
> Xi Wang
> 
>



Review Request 55062: Improve and Fix "Services page" after new guidelines

2016-12-27 Thread Xi Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55062/
---

Review request for Ambari, Richard Zang, Vivek Ratnavel Subramanian, and Yusaku 
Sako.


Bugs: AMBARI-19305
https://issues.apache.org/jira/browse/AMBARI-19305


Repository: ambari


Description
---

Create wizard > Step 2:
The preview should be centered.
During "+ Add Metric" selection, when a metric/operator got selected, the 
submenu should not disappear.


Diffs
-

  ambari-web/app/styles/enhanced_service_dashboard.less 0d549d7 
  ambari-web/app/views/main/service/widgets/create/expression_view.js 436e3e9 

Diff: https://reviews.apache.org/r/55062/diff/


Testing
---

19829 passing (21s)
153 pending


Thanks,

Xi Wang