Re: Review Request 55130: AMBARI-19336 : User should be prompted to enter valid workflow xml file name while Submit/Validate

[Madhan Reddy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55130/
---

(Updated Jan. 4, 2017, 5:54 a.m.)


Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav 
Kulshreshtha.


Bugs: AMBARI-19336
https://issues.apache.org/jira/browse/AMBARI-19336


Repository: ambari


Description
---

User should be prompted to enter valid workflow xml file name while 
Submit/Validate
As of now user can provide any file name. Also user is not restricted even if 
he provides a directory structure.
For example if user provides xml file as /tmp/testPath, a file 'testPath' is 
getting created under directory /tmp/
This file has permission : 'rw-rr-'
Due to this restricted permission, below issues are faced :
Issue 1 : User is not able to import the saved workflow.
Issue 2 : From the dashboard, if user selects any instance of the workflow and 
decides to edit the workflow, user is shown with below error :
There is some problem while importing.Please try again. Hide Log
org.apache.hadoop.security.AccessControlException: Permission denied: 
user=admin, access=EXECUTE, 
inode="/oozieex/mr-ex1/workflow.xml":admin:hadoop:-rw-r--r--

at sun.reflect.GeneratedConstructorAccessor263.newInstance(Unknown Source)

at 
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)

at java.lang.reflect.Constructor.newInstance(Constructor.java:423)

at 
org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:106)


Diffs
-

  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java
 9dd02d4 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java
 f98df0d 

Diff: https://reviews.apache.org/r/55130/diff/


Testing
---

Manual


Thanks,

Madhan Reddy

Re: Review Request 55130: AMBARI-19336 : User should be prompted to enter valid workflow xml file name while Submit/Validate

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55130/#review160371
---


Ship it!




Ship It!

- Gaurav Nagar


On Jan. 3, 2017, 9:18 a.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55130/
> ---
> 
> (Updated Jan. 3, 2017, 9:18 a.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav 
> Kulshreshtha.
> 
> 
> Bugs: AMBARI-19336
> https://issues.apache.org/jira/browse/AMBARI-19336
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> User should be prompted to enter valid workflow xml file name while 
> Submit/Validate
> As of now user can provide any file name. Also user is not restricted even if 
> he provides a directory structure.
> For example if user provides xml file as /tmp/testPath, a file 'testPath' is 
> getting created under directory /tmp/
> This file has permission : 'rw-rr-'
> Due to this restricted permission, below issues are faced :
> Issue 1 : User is not able to import the saved workflow.
> Issue 2 : From the dashboard, if user selects any instance of the workflow 
> and decides to edit the workflow, user is shown with below error :
> There is some problem while importing.Please try again. Hide Log
> org.apache.hadoop.security.AccessControlException: Permission denied: 
> user=admin, access=EXECUTE, 
> inode="/oozieex/mr-ex1/workflow.xml":admin:hadoop:-rw-r--r--
> 
> at sun.reflect.GeneratedConstructorAccessor263.newInstance(Unknown Source)
> 
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> 
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> 
> at 
> org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:106)
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java
>  9dd02d4 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java
>  f98df0d 
> 
> Diff: https://reviews.apache.org/r/55130/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Re: Review Request 55130: AMBARI-19336 : User should be prompted to enter valid workflow xml file name while Submit/Validate

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55130/#review160366
---


Ship it!




Ship It!


contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java
 


typo in naming method? ..DrafFile.. instead of ..DraftFile.. You may think 
of cleaning this up. Its not an issue though.


- Nitiraj Rathore


On Jan. 3, 2017, 9:18 a.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55130/
> ---
> 
> (Updated Jan. 3, 2017, 9:18 a.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav 
> Kulshreshtha.
> 
> 
> Bugs: AMBARI-19336
> https://issues.apache.org/jira/browse/AMBARI-19336
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> User should be prompted to enter valid workflow xml file name while 
> Submit/Validate
> As of now user can provide any file name. Also user is not restricted even if 
> he provides a directory structure.
> For example if user provides xml file as /tmp/testPath, a file 'testPath' is 
> getting created under directory /tmp/
> This file has permission : 'rw-rr-'
> Due to this restricted permission, below issues are faced :
> Issue 1 : User is not able to import the saved workflow.
> Issue 2 : From the dashboard, if user selects any instance of the workflow 
> and decides to edit the workflow, user is shown with below error :
> There is some problem while importing.Please try again. Hide Log
> org.apache.hadoop.security.AccessControlException: Permission denied: 
> user=admin, access=EXECUTE, 
> inode="/oozieex/mr-ex1/workflow.xml":admin:hadoop:-rw-r--r--
> 
> at sun.reflect.GeneratedConstructorAccessor263.newInstance(Unknown Source)
> 
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> 
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> 
> at 
> org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:106)
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java
>  9dd02d4 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java
>  f98df0d 
> 
> Diff: https://reviews.apache.org/r/55130/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Review Request 55130: AMBARI-19336 : User should be prompted to enter valid workflow xml file name while Submit/Validate

[Madhan Reddy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55130/
---

Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav 
Kulshreshtha.


Bugs: AMBARI-19336
https://issues.apache.org/jira/browse/AMBARI-19336


Repository: ambari


Description
---

User should be prompted to enter valid workflow xml file name while 
Submit/Validate
As of now user can provide any file name. Also user is not restricted even if 
he provides a directory structure.
For example if user provides xml file as /tmp/testPath, a file 'testPath' is 
getting created under directory /tmp/
This file has permission : 'rw-rr-'
Due to this restricted permission, below issues are faced :
Issue 1 : User is not able to import the saved workflow.
Issue 2 : From the dashboard, if user selects any instance of the workflow and 
decides to edit the workflow, user is shown with below error :
There is some problem while importing.Please try again. Hide Log
org.apache.hadoop.security.AccessControlException: Permission denied: 
user=admin, access=EXECUTE, 
inode="/oozieex/mr-ex1/workflow.xml":admin:hadoop:-rw-r--r--

at sun.reflect.GeneratedConstructorAccessor263.newInstance(Unknown Source)

at 
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)

at java.lang.reflect.Constructor.newInstance(Constructor.java:423)

at 
org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:106)


Diffs
-

  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java
 9dd02d4 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java
 f98df0d 

Diff: https://reviews.apache.org/r/55130/diff/


Testing
---

Manual


Thanks,

Madhan Reddy