Re: Review Request 55609: Add Livy session recovery configurations in Ambari

2017-02-10 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55609/#review165145
---




ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_livy.py
 (line 47)


Should these permissions be more restrictive?


- Alejandro Fernandez


On Feb. 10, 2017, 7:41 a.m., Saisai Shao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55609/
> ---
> 
> (Updated Feb. 10, 2017, 7:41 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19577
> https://issues.apache.org/jira/browse/AMBARI-19577
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Livy session recovery configurations in Ambari
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  82cd0b2 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_livy.py
>  07b704f 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
>  c19f88c 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_livy2.py
>  f2178f7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-conf.xml
>  23583c0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/configuration/livy2-conf.xml
>  231ef70 
>   ambari-server/src/test/python/stacks/2.5/SPARK/test_spark_livy.py b56474a 
>   ambari-server/src/test/python/stacks/2.6/SPARK2/test_spark_livy2.py 6244d87 
> 
> Diff: https://reviews.apache.org/r/55609/diff/
> 
> 
> Testing
> ---
> 
> Manual verification.
> 
> 
> Thanks,
> 
> Saisai Shao
> 
>



Re: Review Request 55609: Add Livy session recovery configurations in Ambari

2017-02-10 Thread Sumit Mohanty

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55609/#review165132
---


Ship it!




Ship It!

- Sumit Mohanty


On Feb. 10, 2017, 7:41 a.m., Saisai Shao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55609/
> ---
> 
> (Updated Feb. 10, 2017, 7:41 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19577
> https://issues.apache.org/jira/browse/AMBARI-19577
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Livy session recovery configurations in Ambari
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  82cd0b2 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_livy.py
>  07b704f 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
>  c19f88c 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_livy2.py
>  f2178f7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-conf.xml
>  23583c0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/configuration/livy2-conf.xml
>  231ef70 
>   ambari-server/src/test/python/stacks/2.5/SPARK/test_spark_livy.py b56474a 
>   ambari-server/src/test/python/stacks/2.6/SPARK2/test_spark_livy2.py 6244d87 
> 
> Diff: https://reviews.apache.org/r/55609/diff/
> 
> 
> Testing
> ---
> 
> Manual verification.
> 
> 
> Thanks,
> 
> Saisai Shao
> 
>



Re: Review Request 55609: Add Livy session recovery configurations in Ambari

2017-01-25 Thread Saisai Shao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55609/
---

(Updated Jan. 26, 2017, 1:29 a.m.)


Review request for Ambari, Jayush Luniya and Sumit Mohanty.


Bugs: AMBARI-19577
https://issues.apache.org/jira/browse/AMBARI-19577


Repository: ambari


Description
---

Add Livy session recovery configurations in Ambari


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
 82cd0b2 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_livy.py
 07b704f 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
 c19f88c 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_livy2.py
 f2178f7 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-conf.xml
 b7bfa73 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/configuration/livy2-conf.xml
 457869d 

Diff: https://reviews.apache.org/r/55609/diff/


Testing
---

Manual verification.


Thanks,

Saisai Shao



Re: Review Request 55609: Add Livy session recovery configurations in Ambari

2017-01-25 Thread Saisai Shao


> On Jan. 25, 2017, 6:49 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-conf.xml,
> >  line 92
> > 
> >
> > Does this need the attribute of "directory"?
> 
> Saisai Shao wrote:
> I'm not sure the usage of attribute "directory", but this configuration 
> do means a directory, and will be created in livy setup.

But one thing should be noted that this directory is a HDFS directory, not a 
local one, do we necessary to add this attribute?


- Saisai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55609/#review162995
---


On Jan. 25, 2017, 5:35 a.m., Saisai Shao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55609/
> ---
> 
> (Updated Jan. 25, 2017, 5:35 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19577
> https://issues.apache.org/jira/browse/AMBARI-19577
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Livy session recovery configurations in Ambari
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  82cd0b2 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_livy.py
>  07b704f 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
>  c19f88c 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_livy2.py
>  f2178f7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-conf.xml
>  b7bfa73 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/configuration/livy2-conf.xml
>  457869d 
> 
> Diff: https://reviews.apache.org/r/55609/diff/
> 
> 
> Testing
> ---
> 
> Manual verification.
> 
> 
> Thanks,
> 
> Saisai Shao
> 
>



Re: Review Request 55609: Add Livy session recovery configurations in Ambari

2017-01-25 Thread Saisai Shao


> On Jan. 25, 2017, 6:49 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-conf.xml,
> >  line 79
> > 
> >
> > For all of these props, 
> > set 

What's the purpose of using "false", I see all the configurations added using 
true.


> On Jan. 25, 2017, 6:49 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-conf.xml,
> >  line 92
> > 
> >
> > Does this need the attribute of "directory"?

I'm not sure the usage of attribute "directory", but this configuration do 
means a directory, and will be created in livy setup.


- Saisai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55609/#review162995
---


On Jan. 25, 2017, 5:35 a.m., Saisai Shao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55609/
> ---
> 
> (Updated Jan. 25, 2017, 5:35 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19577
> https://issues.apache.org/jira/browse/AMBARI-19577
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Livy session recovery configurations in Ambari
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  82cd0b2 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_livy.py
>  07b704f 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
>  c19f88c 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_livy2.py
>  f2178f7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-conf.xml
>  b7bfa73 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/configuration/livy2-conf.xml
>  457869d 
> 
> Diff: https://reviews.apache.org/r/55609/diff/
> 
> 
> Testing
> ---
> 
> Manual verification.
> 
> 
> Thanks,
> 
> Saisai Shao
> 
>



Re: Review Request 55609: Add Livy session recovery configurations in Ambari

2017-01-25 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55609/#review162995
---


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
 (line 211)


Use the default() method

livy2_recovery_dir = 
default("/configurations/livy2-conf/livy.server.recovery.state-store.url", 
"/livery2-recovery")



ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-conf.xml
 (line 77)


What are the other possible options? Can you include them in the config 
description.



ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-conf.xml
 (line 79)


For all of these props, 
set 



ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-conf.xml
 (line 92)


Does this need the attribute of "directory"?



ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/configuration/livy2-conf.xml
 (line 97)


Does this need the attribute of "directory"?


- Alejandro Fernandez


On Jan. 25, 2017, 5:35 a.m., Saisai Shao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55609/
> ---
> 
> (Updated Jan. 25, 2017, 5:35 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19577
> https://issues.apache.org/jira/browse/AMBARI-19577
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Livy session recovery configurations in Ambari
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  82cd0b2 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_livy.py
>  07b704f 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
>  c19f88c 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_livy2.py
>  f2178f7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-conf.xml
>  b7bfa73 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/configuration/livy2-conf.xml
>  457869d 
> 
> Diff: https://reviews.apache.org/r/55609/diff/
> 
> 
> Testing
> ---
> 
> Manual verification.
> 
> 
> Thanks,
> 
> Saisai Shao
> 
>



Re: Review Request 55609: Add Livy session recovery configurations in Ambari

2017-01-24 Thread Saisai Shao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55609/
---

(Updated Jan. 25, 2017, 5:35 a.m.)


Review request for Ambari, Jayush Luniya and Sumit Mohanty.


Bugs: AMBARI-19577
https://issues.apache.org/jira/browse/AMBARI-19577


Repository: ambari


Description
---

Add Livy session recovery configurations in Ambari


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
 82cd0b2 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_livy.py
 07b704f 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
 c19f88c 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_livy2.py
 f2178f7 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-conf.xml
 b7bfa73 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/configuration/livy2-conf.xml
 457869d 

Diff: https://reviews.apache.org/r/55609/diff/


Testing
---

Manual verification.


Thanks,

Saisai Shao



Re: Review Request 55609: Add Livy session recovery configurations in Ambari

2017-01-23 Thread Saisai Shao


> On Jan. 19, 2017, 4:59 a.m., Bikas Saha wrote:
> > Should the URL for recovery be something like 
> > /apps/{livy|spark}/livy-recovery? Having /livy-recovery as a top level HDFS 
> > dir seems distracting.
> 
> Saisai Shao wrote:
> It will not be in the top level HDFS dirs. It will be in User livy's 
> current home directory, which is "/user/livy/livy-recovery".
> 
> Bikas Saha wrote:
> My suggestion would be to change that to /apps/spark where such system 
> data tends to go for other apps. That would be the convention. What do the 
> Ambari folks think? Of course my understanding of existing convention might 
> be wrong :) In which case /user/livy/ is also ok.
> 
> Saisai Shao wrote:
> Bikas, there's no /apps/spark, and it actually is 
> "/hdp/apps/2.6.0.0-389/spark", which is hdp version specific. So I will 
> follow what spark history did "/spark-history", to create "/livy-recovery" 
> and "/livy2-recovery".

What do you think?


- Saisai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55609/#review162240
---


On Jan. 18, 2017, 2:25 a.m., Saisai Shao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55609/
> ---
> 
> (Updated Jan. 18, 2017, 2:25 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19577
> https://issues.apache.org/jira/browse/AMBARI-19577
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Livy session recovery configurations in Ambari
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-conf.xml
>  b7bfa73 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/configuration/livy2-conf.xml
>  457869d 
> 
> Diff: https://reviews.apache.org/r/55609/diff/
> 
> 
> Testing
> ---
> 
> Manual verification.
> 
> 
> Thanks,
> 
> Saisai Shao
> 
>



Re: Review Request 55609: Add Livy session recovery configurations in Ambari

2017-01-23 Thread Saisai Shao


> On Jan. 19, 2017, 4:59 a.m., Bikas Saha wrote:
> > Should the URL for recovery be something like 
> > /apps/{livy|spark}/livy-recovery? Having /livy-recovery as a top level HDFS 
> > dir seems distracting.
> 
> Saisai Shao wrote:
> It will not be in the top level HDFS dirs. It will be in User livy's 
> current home directory, which is "/user/livy/livy-recovery".
> 
> Bikas Saha wrote:
> My suggestion would be to change that to /apps/spark where such system 
> data tends to go for other apps. That would be the convention. What do the 
> Ambari folks think? Of course my understanding of existing convention might 
> be wrong :) In which case /user/livy/ is also ok.

Bikas, there's no /apps/spark, and it actually is 
"/hdp/apps/2.6.0.0-389/spark", which is hdp version specific. So I will follow 
what spark history did "/spark-history", to create "/livy-recovery" and 
"/livy2-recovery".


- Saisai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55609/#review162240
---


On Jan. 18, 2017, 2:25 a.m., Saisai Shao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55609/
> ---
> 
> (Updated Jan. 18, 2017, 2:25 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19577
> https://issues.apache.org/jira/browse/AMBARI-19577
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Livy session recovery configurations in Ambari
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-conf.xml
>  b7bfa73 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/configuration/livy2-conf.xml
>  457869d 
> 
> Diff: https://reviews.apache.org/r/55609/diff/
> 
> 
> Testing
> ---
> 
> Manual verification.
> 
> 
> Thanks,
> 
> Saisai Shao
> 
>



Re: Review Request 55609: Add Livy session recovery configurations in Ambari

2017-01-19 Thread bikas


> On Jan. 18, 2017, 8:59 p.m., bikassaha wrote:
> > Should the URL for recovery be something like 
> > /apps/{livy|spark}/livy-recovery? Having /livy-recovery as a top level HDFS 
> > dir seems distracting.
> 
> Saisai Shao wrote:
> It will not be in the top level HDFS dirs. It will be in User livy's 
> current home directory, which is "/user/livy/livy-recovery".

My suggestion would be to change that to /apps/spark where such system data 
tends to go for other apps. That would be the convention. What do the Ambari 
folks think? Of course my understanding of existing convention might be wrong 
:) In which case /user/livy/ is also ok.


- bikassaha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55609/#review162240
---


On Jan. 17, 2017, 6:25 p.m., Saisai Shao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55609/
> ---
> 
> (Updated Jan. 17, 2017, 6:25 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19577
> https://issues.apache.org/jira/browse/AMBARI-19577
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Livy session recovery configurations in Ambari
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-conf.xml
>  b7bfa73 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/configuration/livy2-conf.xml
>  457869d 
> 
> Diff: https://reviews.apache.org/r/55609/diff/
> 
> 
> Testing
> ---
> 
> Manual verification.
> 
> 
> Thanks,
> 
> Saisai Shao
> 
>



Re: Review Request 55609: Add Livy session recovery configurations in Ambari

2017-01-18 Thread Saisai Shao


> On Jan. 19, 2017, 4:59 a.m., bikassaha wrote:
> > Should the URL for recovery be something like 
> > /apps/{livy|spark}/livy-recovery? Having /livy-recovery as a top level HDFS 
> > dir seems distracting.

It will not be in the top level HDFS dirs. It will be in User livy's current 
home directory, which is "/user/livy/livy-recovery".


- Saisai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55609/#review162240
---


On Jan. 18, 2017, 2:25 a.m., Saisai Shao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55609/
> ---
> 
> (Updated Jan. 18, 2017, 2:25 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19577
> https://issues.apache.org/jira/browse/AMBARI-19577
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Livy session recovery configurations in Ambari
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-conf.xml
>  b7bfa73 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/configuration/livy2-conf.xml
>  457869d 
> 
> Diff: https://reviews.apache.org/r/55609/diff/
> 
> 
> Testing
> ---
> 
> Manual verification.
> 
> 
> Thanks,
> 
> Saisai Shao
> 
>



Re: Review Request 55609: Add Livy session recovery configurations in Ambari

2017-01-18 Thread bikas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55609/#review162240
---



Should the URL for recovery be something like /apps/{livy|spark}/livy-recovery? 
Having /livy-recovery as a top level HDFS dir seems distracting.

- bikassaha


On Jan. 17, 2017, 6:25 p.m., Saisai Shao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55609/
> ---
> 
> (Updated Jan. 17, 2017, 6:25 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19577
> https://issues.apache.org/jira/browse/AMBARI-19577
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Livy session recovery configurations in Ambari
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-conf.xml
>  b7bfa73 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/configuration/livy2-conf.xml
>  457869d 
> 
> Diff: https://reviews.apache.org/r/55609/diff/
> 
> 
> Testing
> ---
> 
> Manual verification.
> 
> 
> Thanks,
> 
> Saisai Shao
> 
>



Re: Review Request 55609: Add Livy session recovery configurations in Ambari

2017-01-18 Thread Jayush Luniya

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55609/#review162172
---


Ship it!




Ship It!

- Jayush Luniya


On Jan. 18, 2017, 2:25 a.m., Saisai Shao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55609/
> ---
> 
> (Updated Jan. 18, 2017, 2:25 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19577
> https://issues.apache.org/jira/browse/AMBARI-19577
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Livy session recovery configurations in Ambari
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-conf.xml
>  b7bfa73 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/configuration/livy2-conf.xml
>  457869d 
> 
> Diff: https://reviews.apache.org/r/55609/diff/
> 
> 
> Testing
> ---
> 
> Manual verification.
> 
> 
> Thanks,
> 
> Saisai Shao
> 
>



Review Request 55609: Add Livy session recovery configurations in Ambari

2017-01-17 Thread Saisai Shao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55609/
---

Review request for Ambari and Sumit Mohanty.


Bugs: AMBARI-19577
https://issues.apache.org/jira/browse/AMBARI-19577


Repository: ambari


Description
---

Add Livy session recovery configurations in Ambari


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-conf.xml
 b7bfa73 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/configuration/livy2-conf.xml
 457869d 

Diff: https://reviews.apache.org/r/55609/diff/


Testing
---

Manual verification.


Thanks,

Saisai Shao