Re: Review Request 55618: Ranger Admin HA Wizard should display configs changes explicitly

2017-01-17 Thread Oleg Nechiporenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55618/#review161862
---


Ship it!




Ship It!

- Oleg Nechiporenko


On Jan. 17, 2017, 1:48 p.m., Andriy Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55618/
> ---
> 
> (Updated Jan. 17, 2017, 1:48 p.m.)
> 
> 
> Review request for Ambari and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-19586
> https://issues.apache.org/jira/browse/AMBARI-19586
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Configs changes in Ranger Admin HA Wizard aren't shown explicitly (just the 
> message mentioning the affected property is displayed instead).
> 
> 
> Diffs
> -
> 
>   ambari-web/app/assets/test/tests.js 604d96b 
>   
> ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/step3_controller.js
>  475cc52 
>   
> ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/step4_controller.js
>  b7818d9 
>   
> ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/wizard_controller.js
>  2bc6e37 
>   ambari-web/app/routes/ra_high_availability_routes.js ac975ab 
>   ambari-web/app/templates/main/admin/highAvailability/rangerAdmin/step3.hbs 
> 3c798c8 
>   ambari-web/app/views/main/admin/highAvailability/rangerAdmin/step3_view.js 
> 8aa0125 
>   
> ambari-web/test/controllers/main/admin/highAvailability/rangerAdmin/step3_controller_test.js
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/55618/diff/
> 
> 
> Testing
> ---
> 
> 20395 tests complete (39 seconds)
>   153 tests pending
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>



Review Request 55618: Ranger Admin HA Wizard should display configs changes explicitly

2017-01-17 Thread Andriy Babiichuk

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55618/
---

Review request for Ambari and Oleg Nechiporenko.


Bugs: AMBARI-19586
https://issues.apache.org/jira/browse/AMBARI-19586


Repository: ambari


Description
---

Configs changes in Ranger Admin HA Wizard aren't shown explicitly (just the 
message mentioning the affected property is displayed instead).


Diffs
-

  ambari-web/app/assets/test/tests.js 604d96b 
  
ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/step3_controller.js
 475cc52 
  
ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/step4_controller.js
 b7818d9 
  
ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/wizard_controller.js
 2bc6e37 
  ambari-web/app/routes/ra_high_availability_routes.js ac975ab 
  ambari-web/app/templates/main/admin/highAvailability/rangerAdmin/step3.hbs 
3c798c8 
  ambari-web/app/views/main/admin/highAvailability/rangerAdmin/step3_view.js 
8aa0125 
  
ambari-web/test/controllers/main/admin/highAvailability/rangerAdmin/step3_controller_test.js
 PRE-CREATION 

Diff: https://reviews.apache.org/r/55618/diff/


Testing
---

20395 tests complete (39 seconds)
  153 tests pending


Thanks,

Andriy Babiichuk