---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55628/#review161882
---
Ship it!
Ship It!
- Alexandr Antonenko
On Jan. 17, 2017, 4:32 p.m., Andriy Babiichuk wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55628/
> ---
>
> (Updated Jan. 17, 2017, 4:32 p.m.)
>
>
> Review request for Ambari and Alexandr Antonenko.
>
>
> Bugs: AMBARI-19590
> https://issues.apache.org/jira/browse/AMBARI-19590
>
>
> Repository: ambari
>
>
> Description
> ---
>
> - Information div similar to "Recommended Changes" one should be added for
> "Required Changes" as well. This should say "The following configuration
> changes are required and will be applied automatically."
> - There's not enough spacing between confirnation message and the information
> div itself.
> - The information div for recommended changes should come after the header
> "Recommended Changes". Similarly, the information div for required changes
> should come after the header "Required Changes".
>
>
> Diffs
> -
>
> ambari-web/app/messages.js cacb798
> ambari-web/app/templates/common/modal_popups/dependent_configs_list.hbs
> af84306
>
> Diff: https://reviews.apache.org/r/55628/diff/
>
>
> Testing
> ---
>
> 20395 tests complete (33 seconds)
> 153 tests pending
>
>
> Thanks,
>
> Andriy Babiichuk
>
>