Re: Review Request 56014: User preference like opened tabs/work in progress should not be available to a different user
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56014/#review163264 --- Ship it! Ship It! - Gaurav Nagar On Jan. 27, 2017, 1:17 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56014/ > --- > > (Updated Jan. 27, 2017, 1:17 p.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Pallav Kulshreshtha, > and Rohit Choudhary. > > > Bugs: AMBARI-19742 > https://issues.apache.org/jira/browse/AMBARI-19742 > > > Repository: ambari > > > Description > --- > > Login to user1. > create workspace by creating a workflow. > logout > login to user2. > the workspace of user1 is restored. > Expected. > each user should maintain their own preference while working in same browser. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js > e29935c > > contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js > fa664c7 > > contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js > 53fd27d > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > 0a0d2f2 > contrib/views/wfmanager/src/main/resources/ui/app/services/user-info.js > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/app/services/workspace-manager.js > 24ab53c > > contrib/views/wfmanager/src/main/resources/ui/tests/unit/services/user-info-test.js > PRE-CREATION > > Diff: https://reviews.apache.org/r/56014/diff/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Re: Review Request 56014: User preference like opened tabs/work in progress should not be available to a different user
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56014/#review163263 --- Ship it! Ship It! - Renjith Kamath On Jan. 27, 2017, 1:17 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56014/ > --- > > (Updated Jan. 27, 2017, 1:17 p.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Pallav Kulshreshtha, > and Rohit Choudhary. > > > Bugs: AMBARI-19742 > https://issues.apache.org/jira/browse/AMBARI-19742 > > > Repository: ambari > > > Description > --- > > Login to user1. > create workspace by creating a workflow. > logout > login to user2. > the workspace of user1 is restored. > Expected. > each user should maintain their own preference while working in same browser. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js > e29935c > > contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js > fa664c7 > > contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js > 53fd27d > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > 0a0d2f2 > contrib/views/wfmanager/src/main/resources/ui/app/services/user-info.js > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/app/services/workspace-manager.js > 24ab53c > > contrib/views/wfmanager/src/main/resources/ui/tests/unit/services/user-info-test.js > PRE-CREATION > > Diff: https://reviews.apache.org/r/56014/diff/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Re: Review Request 56014: User preference like opened tabs/work in progress should not be available to a different user
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56014/#review163262 --- Ship it! Ship It! - Pallav Kulshreshtha On Jan. 27, 2017, 1:17 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56014/ > --- > > (Updated Jan. 27, 2017, 1:17 p.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Pallav Kulshreshtha, > and Rohit Choudhary. > > > Bugs: AMBARI-19742 > https://issues.apache.org/jira/browse/AMBARI-19742 > > > Repository: ambari > > > Description > --- > > Login to user1. > create workspace by creating a workflow. > logout > login to user2. > the workspace of user1 is restored. > Expected. > each user should maintain their own preference while working in same browser. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js > e29935c > > contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js > fa664c7 > > contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js > 53fd27d > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > 0a0d2f2 > contrib/views/wfmanager/src/main/resources/ui/app/services/user-info.js > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/app/services/workspace-manager.js > 24ab53c > > contrib/views/wfmanager/src/main/resources/ui/tests/unit/services/user-info-test.js > PRE-CREATION > > Diff: https://reviews.apache.org/r/56014/diff/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Re: Review Request 56014: User preference like opened tabs/work in progress should not be available to a different user
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56014/ --- (Updated Jan. 27, 2017, 1:17 p.m.) Review request for Ambari, belliraj hb, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary. Bugs: AMBARI-19742 https://issues.apache.org/jira/browse/AMBARI-19742 Repository: ambari Description --- Login to user1. create workspace by creating a workflow. logout login to user2. the workspace of user1 is restored. Expected. each user should maintain their own preference while working in same browser. Diffs (updated) - contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js e29935c contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js fa664c7 contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js 53fd27d contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 0a0d2f2 contrib/views/wfmanager/src/main/resources/ui/app/services/user-info.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/services/workspace-manager.js 24ab53c contrib/views/wfmanager/src/main/resources/ui/tests/unit/services/user-info-test.js PRE-CREATION Diff: https://reviews.apache.org/r/56014/diff/ Testing --- Manual testing done. Thanks, venkat sairam
Review Request 56014: User preference like opened tabs/work in progress should not be available to a different user
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56014/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary. Bugs: AMBARI-19742 https://issues.apache.org/jira/browse/AMBARI-19742 Repository: ambari Description --- Login to user1. create workspace by creating a workflow. logout login to user2. the workspace of user1 is restored. Expected. each user should maintain their own preference while working in same browser. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js e29935c contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js fa664c7 contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js 53fd27d contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 0a0d2f2 contrib/views/wfmanager/src/main/resources/ui/app/services/user-info.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/services/workspace-manager.js 24ab53c contrib/views/wfmanager/src/main/resources/ui/tests/unit/services/user-info-test.js PRE-CREATION Diff: https://reviews.apache.org/r/56014/diff/ Testing --- Manual testing done. Thanks, venkat sairam
