Re: Review Request 56071: AMBARI-19766:Not able to set the sla for an action node

2017-01-30 Thread belliraj hb

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56071/#review163491
---


Ship it!




Ship It!

- belliraj hb


On Jan. 30, 2017, 9:15 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56071/
> ---
> 
> (Updated Jan. 30, 2017, 9:15 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19766
> https://issues.apache.org/jira/browse/AMBARI-19766
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added an if condition for not deleting the sla object of an action if the 
> action is not a custom action.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js
>  f2d3ba8 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sla-info.hbs
>  447bac2 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sqoop-action.hbs
>  3f0ec61 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-actions.hbs
>  badf320 
> 
> Diff: https://reviews.apache.org/r/56071/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>



Re: Review Request 56071: AMBARI-19766:Not able to set the sla for an action node

2017-01-30 Thread Padma Priya N

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56071/
---

(Updated Jan. 30, 2017, 9:15 a.m.)


Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
Pallav Kulshreshtha.


Bugs: AMBARI-19766
https://issues.apache.org/jira/browse/AMBARI-19766


Repository: ambari


Description
---

Added an if condition for not deleting the sla object of an action if the 
action is not a custom action.


Diffs (updated)
-

  
contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js
 f2d3ba8 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sla-info.hbs
 447bac2 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sqoop-action.hbs
 3f0ec61 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-actions.hbs
 badf320 

Diff: https://reviews.apache.org/r/56071/diff/


Testing
---

Manual


Thanks,

Padma Priya N



Review Request 56071: AMBARI-19766:Not able to set the sla for an action node

2017-01-30 Thread Padma Priya N

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56071/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
Pallav Kulshreshtha.


Bugs: AMBARI-19766
https://issues.apache.org/jira/browse/AMBARI-19766


Repository: ambari


Description
---

Added an if condition for not deleting the sla object of an action if the 
action is not a custom action.


Diffs
-

  
contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js
 f2d3ba8 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sla-info.hbs
 447bac2 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sqoop-action.hbs
 3f0ec61 

Diff: https://reviews.apache.org/r/56071/diff/


Testing
---

Manual


Thanks,

Padma Priya N