---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56176/#review163826
---
Ship it!
Ship It!
- Aleksandr Kovalenko
On Фев. 1, 2017, 4:31 п.п., Andriy Babiichuk wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56176/
> ---
>
> (Updated Фев. 1, 2017, 4:31 п.п.)
>
>
> Review request for Ambari and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-19821
> https://issues.apache.org/jira/browse/AMBARI-19821
>
>
> Repository: ambari
>
>
> Description
> ---
>
> As result of configs recommendation API call, the changes to be made are
> displayed in popup, so that user can discard some of them. There should be no
> discard ability for non-editable properties.
> The above is correct for delete service popup, service configs page and
> 'configure services' wizard step.
>
>
> Diffs
> -
>
> ambari-web/app/mixins/common/configs/config_recommendation_parser.js
> b014ede
> ambari-web/app/mixins/common/configs/config_recommendations.js 7427a54
>
> ambari-web/app/mixins/common/configs/config_with_override_recommendation_parser.js
> 86ccb65
> ambari-web/app/mixins/common/configs/enhanced_configs.js c86f132
> ambari-web/app/views/common/modal_popups/dependent_configs_list_popup.js
> ffb3add
> ambari-web/test/mixins/common/configs/config_recommendations_test.js
> baa8ed6
> ambari-web/test/mixins/common/configs/enhanced_configs_test.js 0955a8f
>
> ambari-web/test/views/common/modal_popups/dependent_configs_list_popup_test.js
> 9dc4bf6
>
> Diff: https://reviews.apache.org/r/56176/diff/
>
>
> Testing
> ---
>
> 20325 passing (20s)
> 153 pending
>
>
> Thanks,
>
> Andriy Babiichuk
>
>
