Re: Review Request 56273: JS error on host configs page

2017-02-03 Thread Denys Buzhor

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56273/#review164106
---


Ship it!




Ship It!

- Denys Buzhor


On Feb. 3, 2017, 8:49 a.m., Oleg Nechiporenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56273/
> ---
> 
> (Updated Feb. 3, 2017, 8:49 a.m.)
> 
> 
> Review request for Ambari and Denys Buzhor.
> 
> 
> Bugs: ambari-19862
> https://issues.apache.org/jira/browse/ambari-19862
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> {{app.js:193861 Uncaught TypeError: Cannot read property 'someProperty' of 
> undefined}}
> 
> on the 
> 
> {{return (isCustomPropertiesCategory && this.get('controller.filter') === '' 
> && !this.get('mainView.columns').someProperty('selected')) ||}}
> 
> 
> Diffs
> -
> 
>   ambari-web/app/views/common/configs/service_configs_by_category_view.js 
> d9b4409 
> 
> Diff: https://reviews.apache.org/r/56273/diff/
> 
> 
> Testing
> ---
> 
> 30313 passing (23s)
>   157 pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>



Review Request 56273: JS error on host configs page

2017-02-03 Thread Oleg Nechiporenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56273/
---

Review request for Ambari and Denys Buzhor.


Bugs: ambari-19862
https://issues.apache.org/jira/browse/ambari-19862


Repository: ambari


Description
---

{{app.js:193861 Uncaught TypeError: Cannot read property 'someProperty' of 
undefined}}

on the 

{{return (isCustomPropertiesCategory && this.get('controller.filter') === '' && 
!this.get('mainView.columns').someProperty('selected')) ||}}


Diffs
-

  ambari-web/app/views/common/configs/service_configs_by_category_view.js 
d9b4409 

Diff: https://reviews.apache.org/r/56273/diff/


Testing
---

30313 passing (23s)
  157 pending


Thanks,

Oleg Nechiporenko