Re: Review Request 56956: Remove OrderedDict python module code from ranger stack

2017-02-22 Thread Mugdha Varadkar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56956/#review166481
---


Ship it!




Ship It!

- Mugdha Varadkar


On Feb. 22, 2017, 11:16 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56956/
> ---
> 
> (Updated Feb. 22, 2017, 11:16 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Miklos Gergely, Mugdha Varadkar, 
> and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20124
> https://issues.apache.org/jira/browse/AMBARI-20124
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> remove collections.OrderedDict from ranger stack code. (it seems on my 
> environemnt that module was installed with python 2.6.6, but its supported 
> from 2.7, in 2.6 ordereddict.OrderedDict can be an option)
> But: use list of tuples instead of it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  b3eb919 
> 
> Diff: https://reviews.apache.org/r/56956/diff/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>



Re: Review Request 56956: Remove OrderedDict python module code from ranger stack

2017-02-22 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56956/#review166444
---


Ship it!




Ship It!

- Alejandro Fernandez


On Feb. 22, 2017, 11:16 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56956/
> ---
> 
> (Updated Feb. 22, 2017, 11:16 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Miklos Gergely, Mugdha Varadkar, 
> and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20124
> https://issues.apache.org/jira/browse/AMBARI-20124
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> remove collections.OrderedDict from ranger stack code. (it seems on my 
> environemnt that module was installed with python 2.6.6, but its supported 
> from 2.7, in 2.6 ordereddict.OrderedDict can be an option)
> But: use list of tuples instead of it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  b3eb919 
> 
> Diff: https://reviews.apache.org/r/56956/diff/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>



Re: Review Request 56956: Remove OrderedDict python module code from ranger stack

2017-02-22 Thread Miklos Gergely

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56956/#review166442
---


Ship it!




Ship It!

- Miklos Gergely


On Feb. 22, 2017, 11:16 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56956/
> ---
> 
> (Updated Feb. 22, 2017, 11:16 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Miklos Gergely, Mugdha Varadkar, 
> and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20124
> https://issues.apache.org/jira/browse/AMBARI-20124
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> remove collections.OrderedDict from ranger stack code. (it seems on my 
> environemnt that module was installed with python 2.6.6, but its supported 
> from 2.7, in 2.6 ordereddict.OrderedDict can be an option)
> But: use list of tuples instead of it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  b3eb919 
> 
> Diff: https://reviews.apache.org/r/56956/diff/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>



Review Request 56956: Remove OrderedDict python module code from ranger stack

2017-02-22 Thread Oliver Szabo

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56956/
---

Review request for Ambari, Jonathan Hurley, Miklos Gergely, Mugdha Varadkar, 
and Robert Nettleton.


Bugs: AMBARI-20124
https://issues.apache.org/jira/browse/AMBARI-20124


Repository: ambari


Description
---

remove collections.OrderedDict from ranger stack code. (it seems on my 
environemnt that module was installed with python 2.6.6, but its supported from 
2.7, in 2.6 ordereddict.OrderedDict can be an option)
But: use list of tuples instead of it.


Diffs
-

  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 b3eb919 

Diff: https://reviews.apache.org/r/56956/diff/


Testing
---

done.


Thanks,

Oliver Szabo