Re: Review Request 56979: AMBARI-20050. Issue while importing workflow with insufficient permissions

2017-02-23 Thread Gaurav Nagar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56979/#review166518
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 23, 2017, 12:04 p.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56979/
> ---
> 
> (Updated Feb. 23, 2017, 12:04 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20050
> https://issues.apache.org/jira/browse/AMBARI-20050
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Exception handling properly
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieDelegate.java
>  55c4312 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java
>  6603a9c 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetResource.java
>  ef3b508 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/exception/ErrorCode.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/exception/WfmException.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/exception/WfmWebException.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsManagerResource.java
>  a0aa234 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 
> 3ccbc07 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
> bbd619d 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/designer-errors.js
>  7a7c38d 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> f97add8 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/stack-trace-dialog.js
>  PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less e98d182 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs
>  ca58431 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs
>  7b607ca 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-errors.hbs
>  8438255 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
>  1a73421 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/stack-trace-dialog.hbs
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/stack-trace-dialog-test.js
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56979/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>



Re: Review Request 56979: AMBARI-20050. Issue while importing workflow with insufficient permissions

2017-02-23 Thread belliraj hb

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56979/#review166508
---


Ship it!




Ship It!

- belliraj hb


On Feb. 23, 2017, 12:04 p.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56979/
> ---
> 
> (Updated Feb. 23, 2017, 12:04 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20050
> https://issues.apache.org/jira/browse/AMBARI-20050
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Exception handling properly
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieDelegate.java
>  55c4312 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java
>  6603a9c 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetResource.java
>  ef3b508 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/exception/ErrorCode.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/exception/WfmException.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/exception/WfmWebException.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsManagerResource.java
>  a0aa234 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 
> 3ccbc07 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
> bbd619d 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/designer-errors.js
>  7a7c38d 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> f97add8 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/stack-trace-dialog.js
>  PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less e98d182 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs
>  ca58431 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs
>  7b607ca 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-errors.hbs
>  8438255 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
>  1a73421 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/stack-trace-dialog.hbs
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/stack-trace-dialog-test.js
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56979/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>



Review Request 56979: AMBARI-20050. Issue while importing workflow with insufficient permissions

2017-02-23 Thread Madhan Reddy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56979/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.


Bugs: AMBARI-20050
https://issues.apache.org/jira/browse/AMBARI-20050


Repository: ambari


Description
---

Exception handling properly


Diffs
-

  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieDelegate.java
 55c4312 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java
 6603a9c 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetResource.java
 ef3b508 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/exception/ErrorCode.java
 PRE-CREATION 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/exception/WfmException.java
 PRE-CREATION 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/exception/WfmWebException.java
 PRE-CREATION 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsManagerResource.java
 a0aa234 
  contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 
3ccbc07 
  contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
bbd619d 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/designer-errors.js 
7a7c38d 
  contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
f97add8 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/stack-trace-dialog.js
 PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less e98d182 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs
 ca58431 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs
 7b607ca 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-errors.hbs
 8438255 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
 1a73421 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/stack-trace-dialog.hbs
 PRE-CREATION 
  
contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/stack-trace-dialog-test.js
 PRE-CREATION 

Diff: https://reviews.apache.org/r/56979/diff/


Testing
---

Manual


Thanks,

Madhan Reddy