Re: Review Request 57196: Tez UI throwing 404 error, Button to minimise TEZ UI, Worksheet save issues, creation of duplicate tabs and other tab issues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57196/ --- (Updated March 1, 2017, 3:46 p.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary. Changes --- Fixed merge conflict Bugs: AMBARI-20251 https://issues.apache.org/jira/browse/AMBARI-20251 Repository: ambari Description --- Tez UI errors are handled in query page, button to maximise and minimise Tez UI is given, issue of creation of duplicate tabs is solved by using ID in route instead of title, issues in saving a query and opening the saved query have been solved as we are now using tab instead if title. Diffs (updated) - contrib/views/hive20/src/main/resources/ui/app/routes/queries/index.js f2af6bc contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 62e5562 contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/visual-explain.js c85db19 contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js 5369f8e contrib/views/hive20/src/main/resources/ui/app/services/tez-view-info.js 943d002 contrib/views/hive20/src/main/resources/ui/app/templates/queries.hbs 6fc7486 contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/tez-ui.hbs edc1e8e Diff: https://reviews.apache.org/r/57196/diff/3/ Changes: https://reviews.apache.org/r/57196/diff/2-3/ Testing --- Manual testing done Thanks, venkat sairam
Re: Review Request 57196: Tez UI throwing 404 error, Button to minimise TEZ UI, Worksheet save issues, creation of duplicate tabs and other tab issues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57196/#review167271 --- Ship it! Ship It! - Pallav Kulshreshtha On March 1, 2017, 12:41 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57196/ > --- > > (Updated March 1, 2017, 12:41 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20251 > https://issues.apache.org/jira/browse/AMBARI-20251 > > > Repository: ambari > > > Description > --- > > Tez UI errors are handled in query page, button to maximise and minimise Tez > UI is given, issue of creation of duplicate tabs is solved by using ID in > route instead of title, issues in saving a query and opening the saved query > have been solved as we are now using tab instead if title. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/routes/queries/index.js > f2af6bc > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > 4ac93db > > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/visual-explain.js > c85db19 > contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js > 5369f8e > contrib/views/hive20/src/main/resources/ui/app/services/tez-view-info.js > 943d002 > contrib/views/hive20/src/main/resources/ui/app/templates/queries.hbs > 6fc7486 > > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/tez-ui.hbs > edc1e8e > > > Diff: https://reviews.apache.org/r/57196/diff/2/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 57196: Tez UI throwing 404 error, Button to minimise TEZ UI, Worksheet save issues, creation of duplicate tabs and other tab issues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57196/ --- (Updated March 1, 2017, 12:41 p.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary. Bugs: AMBARI-20251 https://issues.apache.org/jira/browse/AMBARI-20251 Repository: ambari Description --- Tez UI errors are handled in query page, button to maximise and minimise Tez UI is given, issue of creation of duplicate tabs is solved by using ID in route instead of title, issues in saving a query and opening the saved query have been solved as we are now using tab instead if title. Diffs (updated) - contrib/views/hive20/src/main/resources/ui/app/routes/queries/index.js f2af6bc contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 4ac93db contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/visual-explain.js c85db19 contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js 5369f8e contrib/views/hive20/src/main/resources/ui/app/services/tez-view-info.js 943d002 contrib/views/hive20/src/main/resources/ui/app/templates/queries.hbs 6fc7486 contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/tez-ui.hbs edc1e8e Diff: https://reviews.apache.org/r/57196/diff/2/ Changes: https://reviews.apache.org/r/57196/diff/1-2/ Testing --- Manual testing done Thanks, venkat sairam
Re: Review Request 57196: Tez UI throwing 404 error, Button to minimise TEZ UI, Worksheet save issues, creation of duplicate tabs and other tab issues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57196/#review167251 --- Ship it! Ship It! - Gaurav Nagar On March 1, 2017, 10:32 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57196/ > --- > > (Updated March 1, 2017, 10:32 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20251 > https://issues.apache.org/jira/browse/AMBARI-20251 > > > Repository: ambari > > > Description > --- > > Tez UI errors are handled in query page, button to maximise and minimise Tez > UI is given, issue of creation of duplicate tabs is solved by using ID in > route instead of title, issues in saving a query and opening the saved query > have been solved as we are now using tab instead if title. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/routes/queries/index.js > f2af6bc > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > 4ac93db > > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/visual-explain.js > c85db19 > contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js > 5369f8e > contrib/views/hive20/src/main/resources/ui/app/services/tez-view-info.js > 943d002 > contrib/views/hive20/src/main/resources/ui/app/templates/queries.hbs > 6fc7486 > > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/tez-ui.hbs > edc1e8e > > > Diff: https://reviews.apache.org/r/57196/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Review Request 57196: Tez UI throwing 404 error, Button to minimise TEZ UI, Worksheet save issues, creation of duplicate tabs and other tab issues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57196/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary. Bugs: AMBARI-20251 https://issues.apache.org/jira/browse/AMBARI-20251 Repository: ambari Description --- Tez UI errors are handled in query page, button to maximise and minimise Tez UI is given, issue of creation of duplicate tabs is solved by using ID in route instead of title, issues in saving a query and opening the saved query have been solved as we are now using tab instead if title. Diffs - contrib/views/hive20/src/main/resources/ui/app/routes/queries/index.js f2af6bc contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 4ac93db contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/visual-explain.js c85db19 contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js 5369f8e contrib/views/hive20/src/main/resources/ui/app/services/tez-view-info.js 943d002 contrib/views/hive20/src/main/resources/ui/app/templates/queries.hbs 6fc7486 contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/tez-ui.hbs edc1e8e Diff: https://reviews.apache.org/r/57196/diff/1/ Testing --- Manual testing done Thanks, venkat sairam
