Re: Review Request 57259: AMBARI-20285. Spark2 Thrift Server stopped due to incompletely uploaded tar.gz

2017-03-03 Thread Sandor Magyari

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57259/#review167804
---


Ship it!




Ship It!

- Sandor Magyari


On March 2, 2017, 11:08 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57259/
> ---
> 
> (Updated March 2, 2017, 11:08 p.m.)
> 
> 
> Review request for Ambari, Bikas Saha, Laszlo Puskas, Sandor Magyari, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-20285
> https://issues.apache.org/jira/browse/AMBARI-20285
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Explicitly set permissions.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py
>  12988c8 
> 
> 
> Diff: https://reviews.apache.org/r/57259/diff/1/
> 
> 
> Testing
> ---
> 
> Manual test: create cluster via blueprint, verify 
> `/tmp/spark2/spark2-hdp-yarn-archive.tar.gz` is world readable, and that 
> Spark2 Thrift Server does not stop soon after start.
> 
> Existing unit tests:
> 
> ```
> $ mvn -am -pl ambari-server -DskipSurefireTests clean test
> ...
> Total run:1192
> Total errors:0
> Total failures:0
> OK
> ...
> [INFO] BUILD SUCCESS
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>



Re: Review Request 57259: AMBARI-20285. Spark2 Thrift Server stopped due to incompletely uploaded tar.gz

2017-03-03 Thread Sebastian Toader

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57259/#review167803
---


Ship it!




Ship It!

- Sebastian Toader


On March 3, 2017, 12:08 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57259/
> ---
> 
> (Updated March 3, 2017, 12:08 a.m.)
> 
> 
> Review request for Ambari, Bikas Saha, Laszlo Puskas, Sandor Magyari, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-20285
> https://issues.apache.org/jira/browse/AMBARI-20285
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Explicitly set permissions.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py
>  12988c8 
> 
> 
> Diff: https://reviews.apache.org/r/57259/diff/1/
> 
> 
> Testing
> ---
> 
> Manual test: create cluster via blueprint, verify 
> `/tmp/spark2/spark2-hdp-yarn-archive.tar.gz` is world readable, and that 
> Spark2 Thrift Server does not stop soon after start.
> 
> Existing unit tests:
> 
> ```
> $ mvn -am -pl ambari-server -DskipSurefireTests clean test
> ...
> Total run:1192
> Total errors:0
> Total failures:0
> OK
> ...
> [INFO] BUILD SUCCESS
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>



Review Request 57259: AMBARI-20285. Spark2 Thrift Server stopped due to incompletely uploaded tar.gz

2017-03-02 Thread Attila Doroszlai

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57259/
---

Review request for Ambari, Bikas Saha, Laszlo Puskas, Sandor Magyari, and 
Sebastian Toader.


Bugs: AMBARI-20285
https://issues.apache.org/jira/browse/AMBARI-20285


Repository: ambari


Description
---

Explicitly set permissions.


Diffs
-

  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py
 12988c8 


Diff: https://reviews.apache.org/r/57259/diff/1/


Testing
---

Manual test: create cluster via blueprint, verify 
`/tmp/spark2/spark2-hdp-yarn-archive.tar.gz` is world readable, and that Spark2 
Thrift Server does not stop soon after start.

Existing unit tests:

```
$ mvn -am -pl ambari-server -DskipSurefireTests clean test
...
Total run:1192
Total errors:0
Total failures:0
OK
...
[INFO] BUILD SUCCESS
```


Thanks,

Attila Doroszlai