Re: Review Request 57293: All HBase Masters listed as in standby if Hbase ssl is enabled.

2017-03-04 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57293/#review167942
---


Ship it!




Ship It!

- Alejandro Fernandez


On March 3, 2017, 3:43 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57293/
> ---
> 
> (Updated March 3, 2017, 3:43 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20305
> https://issues.apache.org/jira/browse/AMBARI-20305
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari fails to get jmx metrics from Hbase if it's running with https protocol
> 03 Mar 2017 15:24:00,903 ERROR [ambari-metrics-retrieval-service-thread-17] 
> MetricsRetrievalService:481 - Unable to retrieve metrics from 
> http://host1:30010/jmx. Subsequent failures will be suppressed from the log 
> for 20 minutes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
>  6967fee 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java
>  270d50a 
> 
> 
> Diff: https://reviews.apache.org/r/57293/diff/1/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 57293: All HBase Masters listed as in standby if Hbase ssl is enabled.

2017-03-03 Thread Sumit Mohanty 


> On March 3, 2017, 9:56 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
> > Line 178 (original), 178 (patched)
> > 
> >
> > Should this be an OR - if hbase.ssl.enabled is true or 
> > hbase.http.policy is true?

I see that Josh from HBase has reviewed it. +1


- Sumit


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57293/#review167875
---


On March 3, 2017, 3:43 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57293/
> ---
> 
> (Updated March 3, 2017, 3:43 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20305
> https://issues.apache.org/jira/browse/AMBARI-20305
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari fails to get jmx metrics from Hbase if it's running with https protocol
> 03 Mar 2017 15:24:00,903 ERROR [ambari-metrics-retrieval-service-thread-17] 
> MetricsRetrievalService:481 - Unable to retrieve metrics from 
> http://host1:30010/jmx. Subsequent failures will be suppressed from the log 
> for 20 minutes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
>  6967fee 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java
>  270d50a 
> 
> 
> Diff: https://reviews.apache.org/r/57293/diff/1/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 57293: All HBase Masters listed as in standby if Hbase ssl is enabled.

2017-03-03 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57293/#review167875
---




ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
Line 178 (original), 178 (patched)


Should this be an OR - if hbase.ssl.enabled is true or hbase.http.policy is 
true?


- Sumit Mohanty


On March 3, 2017, 3:43 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57293/
> ---
> 
> (Updated March 3, 2017, 3:43 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20305
> https://issues.apache.org/jira/browse/AMBARI-20305
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari fails to get jmx metrics from Hbase if it's running with https protocol
> 03 Mar 2017 15:24:00,903 ERROR [ambari-metrics-retrieval-service-thread-17] 
> MetricsRetrievalService:481 - Unable to retrieve metrics from 
> http://host1:30010/jmx. Subsequent failures will be suppressed from the log 
> for 20 minutes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
>  6967fee 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java
>  270d50a 
> 
> 
> Diff: https://reviews.apache.org/r/57293/diff/1/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 57293: All HBase Masters listed as in standby if Hbase ssl is enabled.

2017-03-03 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57293/#review167862
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Березень 3, 2017, 3:43 після полудня, Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57293/
> ---
> 
> (Updated Березень 3, 2017, 3:43 після полудня)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20305
> https://issues.apache.org/jira/browse/AMBARI-20305
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari fails to get jmx metrics from Hbase if it's running with https protocol
> 03 Mar 2017 15:24:00,903 ERROR [ambari-metrics-retrieval-service-thread-17] 
> MetricsRetrievalService:481 - Unable to retrieve metrics from 
> http://host1:30010/jmx. Subsequent failures will be suppressed from the log 
> for 20 minutes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
>  6967fee 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java
>  270d50a 
> 
> 
> Diff: https://reviews.apache.org/r/57293/diff/1/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Review Request 57293: All HBase Masters listed as in standby if Hbase ssl is enabled.

2017-03-03 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57293/
---

Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and 
Vitalyi Brodetskyi.


Bugs: AMBARI-20305
https://issues.apache.org/jira/browse/AMBARI-20305


Repository: ambari


Description
---

Ambari fails to get jmx metrics from Hbase if it's running with https protocol
03 Mar 2017 15:24:00,903 ERROR [ambari-metrics-retrieval-service-thread-17] 
MetricsRetrievalService:481 - Unable to retrieve metrics from 
http://host1:30010/jmx. Subsequent failures will be suppressed from the log for 
20 minutes.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
 6967fee 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java
 270d50a 


Diff: https://reviews.apache.org/r/57293/diff/1/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen