Re: Review Request 57297: Cluster deployment using blueprint with empty configuration doesn't work with stack advisor enabled

2017-03-08 Thread Amruta Borkar


> On March 8, 2017, 10:49 p.m., Alejandro Fernandez wrote:
> > Ship It!

Thank you Alejandro,
Could you please help me push this to trunk?


- Amruta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57297/#review168366
---


On March 8, 2017, 11:08 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57297/
> ---
> 
> (Updated March 8, 2017, 11:08 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, Robert Nettleton, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20288
> https://issues.apache.org/jira/browse/AMBARI-20288
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a blueprint deployment is made with empty configuration for a particular 
> config-type and when stack advisor is returning a ValueAttributeInfo for for 
> that config-type with a property marked "true" for "Delete" flag
> 
> Cluster deployment gets stuck at TOPOLOGY_RESOLUTION phase showing message
> Config type not resolved yet, Blueprint deployment will wait until 
> configuration update is completed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  d4880b9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  928d1e0 
> 
> 
> Diff: https://reviews.apache.org/r/57297/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> Modified test case to address the scenario.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>



Re: Review Request 57297: Cluster deployment using blueprint with empty configuration doesn't work with stack advisor enabled

2017-03-08 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57297/#review168366
---


Ship it!




Ship It!

- Alejandro Fernandez


On March 3, 2017, 6:59 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57297/
> ---
> 
> (Updated March 3, 2017, 6:59 p.m.)
> 
> 
> Review request for Ambari, Di Li, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20288
> https://issues.apache.org/jira/browse/AMBARI-20288
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a blueprint deployment is made with empty configuration for a particular 
> config-type and when stack advisor is returning a ValueAttributeInfo for for 
> that config-type with a property marked "true" for "Delete" flag
> 
> Cluster deployment gets stuck at TOPOLOGY_RESOLUTION phase showing message
> Config type not resolved yet, Blueprint deployment will wait until 
> configuration update is completed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  d4880b9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  928d1e0 
> 
> 
> Diff: https://reviews.apache.org/r/57297/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> Modified test case to address the scenario.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>



Re: Review Request 57297: Cluster deployment using blueprint with empty configuration doesn't work with stack advisor enabled

2017-03-08 Thread Sumit Mohanty

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57297/#review168361
---


Ship it!




Ship It!

- Sumit Mohanty


On March 3, 2017, 6:59 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57297/
> ---
> 
> (Updated March 3, 2017, 6:59 p.m.)
> 
> 
> Review request for Ambari, Di Li, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20288
> https://issues.apache.org/jira/browse/AMBARI-20288
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a blueprint deployment is made with empty configuration for a particular 
> config-type and when stack advisor is returning a ValueAttributeInfo for for 
> that config-type with a property marked "true" for "Delete" flag
> 
> Cluster deployment gets stuck at TOPOLOGY_RESOLUTION phase showing message
> Config type not resolved yet, Blueprint deployment will wait until 
> configuration update is completed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  d4880b9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  928d1e0 
> 
> 
> Diff: https://reviews.apache.org/r/57297/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> Modified test case to address the scenario.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>



Re: Review Request 57297: Cluster deployment using blueprint with empty configuration doesn't work with stack advisor enabled

2017-03-06 Thread Di Li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57297/#review168042
---


Ship it!




Ship It!

- Di Li


On March 3, 2017, 6:59 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57297/
> ---
> 
> (Updated March 3, 2017, 6:59 p.m.)
> 
> 
> Review request for Ambari, Di Li, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20288
> https://issues.apache.org/jira/browse/AMBARI-20288
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a blueprint deployment is made with empty configuration for a particular 
> config-type and when stack advisor is returning a ValueAttributeInfo for for 
> that config-type with a property marked "true" for "Delete" flag
> 
> Cluster deployment gets stuck at TOPOLOGY_RESOLUTION phase showing message
> Config type not resolved yet, Blueprint deployment will wait until 
> configuration update is completed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  d4880b9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  928d1e0 
> 
> 
> Diff: https://reviews.apache.org/r/57297/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> Modified test case to address the scenario.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>