Re: Review Request 57304: Code review request for AMBARI-20157
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57304/#review168188 --- Ship it! Ship It! - Amarnath reddy pappu On March 3, 2017, 8:23 p.m., Amarnath reddy pappu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57304/ > --- > > (Updated March 3, 2017, 8:23 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sid > Wagle. > > > Bugs: AMBARI-20157 > https://issues.apache.org/jira/browse/AMBARI-20157 > > > Repository: ambari > > > Description > --- > > Fix for SNMP notification order > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity.java > ba86687 > > > Diff: https://reviews.apache.org/r/57304/diff/1/ > > > Testing > --- > > 1. Added the debug statements in "AlertNoticeDispatchService.java" file to > see the order before it actually dispatches the notifications > Expected Result: it should print he notifications in correct order , smaller > notification_id notification first and bigger one later. > Actual Result: PASS > > --- > > sample ambari-server.log > > ambari-server.log:03 Mar 2017 11:45:09,787 INFO [AlertNoticeDispatchService > RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2951 > uuid:d237b8f4-9a89-4e62-9fe3-562119908732 > ambari-server.log:03 Mar 2017 11:45:09,787 INFO [AlertNoticeDispatchService > RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2952 > uuid:697a1597-bf4d-4196-aea6-d0b6ac6a8703 > ambari-server.log:03 Mar 2017 11:45:09,787 INFO [AlertNoticeDispatchService > RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2953 > uuid:37bf8683--4c94-b2d0-763e85ef3d5c > ambari-server.log:03 Mar 2017 11:45:09,787 INFO [AlertNoticeDispatchService > RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2954 > uuid:62d6ea6f-2190-4771-9497-eb07d45a4537 > > > -- > > > Thanks, > > Amarnath reddy pappu > >
Re: Review Request 57304: Code review request for AMBARI-20157
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57304/#review167886 --- Ship it! Ship It! - Jonathan Hurley On March 3, 2017, 3:23 p.m., Amarnath reddy pappu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57304/ > --- > > (Updated March 3, 2017, 3:23 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sid > Wagle. > > > Bugs: AMBARI-20157 > https://issues.apache.org/jira/browse/AMBARI-20157 > > > Repository: ambari > > > Description > --- > > Fix for SNMP notification order > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity.java > ba86687 > > > Diff: https://reviews.apache.org/r/57304/diff/1/ > > > Testing > --- > > 1. Added the debug statements in "AlertNoticeDispatchService.java" file to > see the order before it actually dispatches the notifications > Expected Result: it should print he notifications in correct order , smaller > notification_id notification first and bigger one later. > Actual Result: PASS > > --- > > sample ambari-server.log > > ambari-server.log:03 Mar 2017 11:45:09,787 INFO [AlertNoticeDispatchService > RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2951 > uuid:d237b8f4-9a89-4e62-9fe3-562119908732 > ambari-server.log:03 Mar 2017 11:45:09,787 INFO [AlertNoticeDispatchService > RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2952 > uuid:697a1597-bf4d-4196-aea6-d0b6ac6a8703 > ambari-server.log:03 Mar 2017 11:45:09,787 INFO [AlertNoticeDispatchService > RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2953 > uuid:37bf8683--4c94-b2d0-763e85ef3d5c > ambari-server.log:03 Mar 2017 11:45:09,787 INFO [AlertNoticeDispatchService > RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2954 > uuid:62d6ea6f-2190-4771-9497-eb07d45a4537 > > > -- > > > Thanks, > > Amarnath reddy pappu > >
Re: Review Request 57304: Code review request for AMBARI-20157
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57304/#review167866 --- Ship it! Ship It! - Alejandro Fernandez On March 3, 2017, 8:23 p.m., Amarnath reddy pappu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57304/ > --- > > (Updated March 3, 2017, 8:23 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sid > Wagle. > > > Bugs: AMBARI-20157 > https://issues.apache.org/jira/browse/AMBARI-20157 > > > Repository: ambari > > > Description > --- > > Fix for SNMP notification order > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity.java > ba86687 > > > Diff: https://reviews.apache.org/r/57304/diff/1/ > > > Testing > --- > > 1. Added the debug statements in "AlertNoticeDispatchService.java" file to > see the order before it actually dispatches the notifications > Expected Result: it should print he notifications in correct order , smaller > notification_id notification first and bigger one later. > Actual Result: PASS > > --- > > sample ambari-server.log > > ambari-server.log:03 Mar 2017 11:45:09,787 INFO [AlertNoticeDispatchService > RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2951 > uuid:d237b8f4-9a89-4e62-9fe3-562119908732 > ambari-server.log:03 Mar 2017 11:45:09,787 INFO [AlertNoticeDispatchService > RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2952 > uuid:697a1597-bf4d-4196-aea6-d0b6ac6a8703 > ambari-server.log:03 Mar 2017 11:45:09,787 INFO [AlertNoticeDispatchService > RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2953 > uuid:37bf8683--4c94-b2d0-763e85ef3d5c > ambari-server.log:03 Mar 2017 11:45:09,787 INFO [AlertNoticeDispatchService > RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2954 > uuid:62d6ea6f-2190-4771-9497-eb07d45a4537 > > > -- > > > Thanks, > > Amarnath reddy pappu > >
Review Request 57304: Code review request for AMBARI-20157
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57304/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sid Wagle. Bugs: AMBARI-20157 https://issues.apache.org/jira/browse/AMBARI-20157 Repository: ambari Description --- Fix for SNMP notification order Diffs - ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity.java ba86687 Diff: https://reviews.apache.org/r/57304/diff/1/ Testing --- 1. Added the debug statements in "AlertNoticeDispatchService.java" file to see the order before it actually dispatches the notifications Expected Result: it should print he notifications in correct order , smaller notification_id notification first and bigger one later. Actual Result: PASS --- sample ambari-server.log ambari-server.log:03 Mar 2017 11:45:09,787 INFO [AlertNoticeDispatchService RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2951 uuid:d237b8f4-9a89-4e62-9fe3-562119908732 ambari-server.log:03 Mar 2017 11:45:09,787 INFO [AlertNoticeDispatchService RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2952 uuid:697a1597-bf4d-4196-aea6-d0b6ac6a8703 ambari-server.log:03 Mar 2017 11:45:09,787 INFO [AlertNoticeDispatchService RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2953 uuid:37bf8683--4c94-b2d0-763e85ef3d5c ambari-server.log:03 Mar 2017 11:45:09,787 INFO [AlertNoticeDispatchService RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2954 uuid:62d6ea6f-2190-4771-9497-eb07d45a4537 -- Thanks, Amarnath reddy pappu
