Re: Review Request 57337: AMBARI-20317 Update stack advisor logic for getting enable atlas hook flag value

2017-03-06 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57337/#review168007
---


Ship it!




Ship It!

- Alejandro Fernandez


On March 6, 2017, 1:31 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57337/
> ---
> 
> (Updated March 6, 2017, 1:31 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-20317
> https://issues.apache.org/jira/browse/AMBARI-20317
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack advisor recommendation for atlas hooks not working as expected due to 
> AMBARI-20304 changes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/configuration/sqoop-site.xml
>  5d87c4d 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> f18bfe9 
> 
> 
> Diff: https://reviews.apache.org/r/57337/diff/1/
> 
> 
> Testing
> ---
> 
> test_recommendHiveConfigurations_with_atlas 
> (test_stack_advisor.TestHDP23StackAdvisor) ... ok
> test_recommendSqoopConfigurations (test_stack_advisor.TestHDP23StackAdvisor) 
> ... ok
> test_recommendStormConfigurations (test_stack_advisor.TestHDP23StackAdvisor) 
> ... ok
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>



Review Request 57337: AMBARI-20317 Update stack advisor logic for getting enable atlas hook flag value

2017-03-06 Thread Mugdha Varadkar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57337/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, and Sumit Mohanty.


Bugs: AMBARI-20317
https://issues.apache.org/jira/browse/AMBARI-20317


Repository: ambari


Description
---

Stack advisor recommendation for atlas hooks not working as expected due to 
AMBARI-20304 changes.


Diffs
-

  
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/configuration/sqoop-site.xml
 5d87c4d 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
f18bfe9 


Diff: https://reviews.apache.org/r/57337/diff/1/


Testing
---

test_recommendHiveConfigurations_with_atlas 
(test_stack_advisor.TestHDP23StackAdvisor) ... ok
test_recommendSqoopConfigurations (test_stack_advisor.TestHDP23StackAdvisor) 
... ok
test_recommendStormConfigurations (test_stack_advisor.TestHDP23StackAdvisor) 
... ok


Thanks,

Mugdha Varadkar