Re: Review Request 57367: Alert Definition Name with brackets marked as invalid

2017-03-07 Thread Denys Buzhor

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57367/#review168110
---


Ship it!




Ship It!

- Denys Buzhor


On March 7, 2017, 10:26 a.m., Oleg Nechiporenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57367/
> ---
> 
> (Updated March 7, 2017, 10:26 a.m.)
> 
> 
> Review request for Ambari and Denys Buzhor.
> 
> 
> Bugs: ambari-20338
> https://issues.apache.org/jira/browse/ambari-20338
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Go to definition details page "NameNode Heap Usage (Daily)"
> * Click Edit definition name
> * It's already marked as invalid
> 
> *ER* Name with brackets should not be marked as invalid
> 
> 
> Diffs
> -
> 
>   ambari-web/app/messages.js 44bf13e 
>   ambari-web/app/utils/validator.js 5173702 
>   ambari-web/test/utils/validator_test.js 8565b3d 
> 
> 
> Diff: https://reviews.apache.org/r/57367/diff/1/
> 
> 
> Testing
> ---
> 
> 20575 passing (23s)
>   153 pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>



Review Request 57367: Alert Definition Name with brackets marked as invalid

2017-03-07 Thread Oleg Nechiporenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57367/
---

Review request for Ambari and Denys Buzhor.


Bugs: ambari-20338
https://issues.apache.org/jira/browse/ambari-20338


Repository: ambari


Description
---

* Go to definition details page "NameNode Heap Usage (Daily)"
* Click Edit definition name
* It's already marked as invalid

*ER* Name with brackets should not be marked as invalid


Diffs
-

  ambari-web/app/messages.js 44bf13e 
  ambari-web/app/utils/validator.js 5173702 
  ambari-web/test/utils/validator_test.js 8565b3d 


Diff: https://reviews.apache.org/r/57367/diff/1/


Testing
---

20575 passing (23s)
  153 pending


Thanks,

Oleg Nechiporenko