Re: Review Request 57396: AMBARI-20329 After restarting Ranger, PAM files are overwritten by default template
> On March 8, 2017, 1:31 p.m., Robert Levas wrote: > > This seems good, but how often will either ranger_remote_pam.j2 or > > ranger_admin_pam.j2 change. And if they do, how will the updated file get > > created? Thanks for your review Robert! The idea is user need to manually modify in the ranger-admin and ranger-remote pam files for customized pam settings. These two files will only be created at the first time using default template. And after that these two file will not be rewritten in case there are customed changes there. - Shi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57396/#review168293 --- On March 7, 2017, 10:45 p.m., Shi Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57396/ > --- > > (Updated March 7, 2017, 10:45 p.m.) > > > Review request for Ambari, Mugdha Varadkar and Robert Levas. > > > Bugs: AMBARI-20329 > https://issues.apache.org/jira/browse/AMBARI-20329 > > > Repository: ambari > > > Description > --- > > AMBARI-18425 add PAM support for ranger authentication in Ambari, but every > time restart ranger-admin it will generate the files again, which will > overwrite the user change. Need to check first if these files already exist, > do not generate again. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > 15f7cf7 > > > Diff: https://reviews.apache.org/r/57396/diff/1/ > > > Testing > --- > > 1. Change ranger pam files > 2. Restart ranger > 3. Check if pam files settings will be overwritten by template. > > > Thanks, > > Shi Wang > >
Re: Review Request 57396: AMBARI-20329 After restarting Ranger, PAM files are overwritten by default template
> On March 8, 2017, 4:23 a.m., Mugdha Varadkar wrote: > > Ship It! Thanks for your review Mugdha! - Shi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57396/#review168246 --- On March 7, 2017, 10:45 p.m., Shi Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57396/ > --- > > (Updated March 7, 2017, 10:45 p.m.) > > > Review request for Ambari, Mugdha Varadkar and Robert Levas. > > > Bugs: AMBARI-20329 > https://issues.apache.org/jira/browse/AMBARI-20329 > > > Repository: ambari > > > Description > --- > > AMBARI-18425 add PAM support for ranger authentication in Ambari, but every > time restart ranger-admin it will generate the files again, which will > overwrite the user change. Need to check first if these files already exist, > do not generate again. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > 15f7cf7 > > > Diff: https://reviews.apache.org/r/57396/diff/1/ > > > Testing > --- > > 1. Change ranger pam files > 2. Restart ranger > 3. Check if pam files settings will be overwritten by template. > > > Thanks, > > Shi Wang > >
Re: Review Request 57396: AMBARI-20329 After restarting Ranger, PAM files are overwritten by default template
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57396/#review168295 --- Ship it! Ship It! - Robert Levas On March 7, 2017, 5:45 p.m., Shi Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57396/ > --- > > (Updated March 7, 2017, 5:45 p.m.) > > > Review request for Ambari, Mugdha Varadkar and Robert Levas. > > > Bugs: AMBARI-20329 > https://issues.apache.org/jira/browse/AMBARI-20329 > > > Repository: ambari > > > Description > --- > > AMBARI-18425 add PAM support for ranger authentication in Ambari, but every > time restart ranger-admin it will generate the files again, which will > overwrite the user change. Need to check first if these files already exist, > do not generate again. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > 15f7cf7 > > > Diff: https://reviews.apache.org/r/57396/diff/1/ > > > Testing > --- > > 1. Change ranger pam files > 2. Restart ranger > 3. Check if pam files settings will be overwritten by template. > > > Thanks, > > Shi Wang > >
Re: Review Request 57396: AMBARI-20329 After restarting Ranger, PAM files are overwritten by default template
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57396/#review168293 --- This seems good, but how often will either ranger_remote_pam.j2 or ranger_admin_pam.j2 change. And if they do, how will the updated file get created? - Robert Levas On March 7, 2017, 5:45 p.m., Shi Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57396/ > --- > > (Updated March 7, 2017, 5:45 p.m.) > > > Review request for Ambari, Mugdha Varadkar and Robert Levas. > > > Bugs: AMBARI-20329 > https://issues.apache.org/jira/browse/AMBARI-20329 > > > Repository: ambari > > > Description > --- > > AMBARI-18425 add PAM support for ranger authentication in Ambari, but every > time restart ranger-admin it will generate the files again, which will > overwrite the user change. Need to check first if these files already exist, > do not generate again. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > 15f7cf7 > > > Diff: https://reviews.apache.org/r/57396/diff/1/ > > > Testing > --- > > 1. Change ranger pam files > 2. Restart ranger > 3. Check if pam files settings will be overwritten by template. > > > Thanks, > > Shi Wang > >
Re: Review Request 57396: AMBARI-20329 After restarting Ranger, PAM files are overwritten by default template
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57396/#review168246 --- Ship it! Ship It! - Mugdha Varadkar On March 7, 2017, 10:45 p.m., Shi Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57396/ > --- > > (Updated March 7, 2017, 10:45 p.m.) > > > Review request for Ambari, Mugdha Varadkar and Robert Levas. > > > Bugs: AMBARI-20329 > https://issues.apache.org/jira/browse/AMBARI-20329 > > > Repository: ambari > > > Description > --- > > AMBARI-18425 add PAM support for ranger authentication in Ambari, but every > time restart ranger-admin it will generate the files again, which will > overwrite the user change. Need to check first if these files already exist, > do not generate again. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > 15f7cf7 > > > Diff: https://reviews.apache.org/r/57396/diff/1/ > > > Testing > --- > > 1. Change ranger pam files > 2. Restart ranger > 3. Check if pam files settings will be overwritten by template. > > > Thanks, > > Shi Wang > >
Review Request 57396: AMBARI-20329 After restarting Ranger, PAM files are overwritten by default template
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57396/ --- Review request for Ambari, Mugdha Varadkar and Robert Levas. Bugs: AMBARI-20329 https://issues.apache.org/jira/browse/AMBARI-20329 Repository: ambari Description --- AMBARI-18425 add PAM support for ranger authentication in Ambari, but every time restart ranger-admin it will generate the files again, which will overwrite the user change. Need to check first if these files already exist, do not generate again. Diffs - ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 15f7cf7 Diff: https://reviews.apache.org/r/57396/diff/1/ Testing --- 1. Change ranger pam files 2. Restart ranger 3. Check if pam files settings will be overwritten by template. Thanks, Shi Wang
