Re: Review Request 57414: AMBARI-20337. Need to show timer while loading coordinator name while bundle creation

2017-03-08 Thread Gaurav Nagar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57414/#review168267
---


Ship it!




Ship It!

- Gaurav Nagar


On March 8, 2017, 10:14 a.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57414/
> ---
> 
> (Updated March 8, 2017, 10:14 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20337
> https://issues.apache.org/jira/browse/AMBARI-20337
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added the loading icon while fetching the coordinator name. And also showing 
> the error message if any exception occurs.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-coord-config.js
>  2280f82 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs
>  2d374a5 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-coord-config.hbs
>  56cacd6 
> 
> 
> Diff: https://reviews.apache.org/r/57414/diff/1/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>



Re: Review Request 57414: AMBARI-20337. Need to show timer while loading coordinator name while bundle creation

2017-03-08 Thread belliraj hb

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57414/#review168266
---


Ship it!




Ship It!

- belliraj hb


On March 8, 2017, 10:14 a.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57414/
> ---
> 
> (Updated March 8, 2017, 10:14 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20337
> https://issues.apache.org/jira/browse/AMBARI-20337
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added the loading icon while fetching the coordinator name. And also showing 
> the error message if any exception occurs.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-coord-config.js
>  2280f82 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs
>  2d374a5 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-coord-config.hbs
>  56cacd6 
> 
> 
> Diff: https://reviews.apache.org/r/57414/diff/1/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>



Review Request 57414: AMBARI-20337. Need to show timer while loading coordinator name while bundle creation

2017-03-08 Thread Madhan Reddy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57414/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.


Bugs: AMBARI-20337
https://issues.apache.org/jira/browse/AMBARI-20337


Repository: ambari


Description
---

Added the loading icon while fetching the coordinator name. And also showing 
the error message if any exception occurs.


Diffs
-

  
contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-coord-config.js
 2280f82 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs
 2d374a5 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-coord-config.hbs
 56cacd6 


Diff: https://reviews.apache.org/r/57414/diff/1/


Testing
---

Manual


Thanks,

Madhan Reddy