Re: Review Request 57656: Side Nav: several issues and adjustments

2017-03-16 Thread Richard Zang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57656/#review169213
---


Ship it!




Ship It!

- Richard Zang


On March 15, 2017, 6:37 p.m., Xi Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57656/
> ---
> 
> (Updated March 15, 2017, 6:37 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
> Subramanian, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20464
> https://issues.apache.org/jira/browse/AMBARI-20464
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Scrolling on Side Nav menu can trigger scrolling on the main content. The 
> same issue for modals, wizards .etc.
> 2. Service Actions icon "..." should occupy more space to click on. 
> Current behavior: need to click exactly on the icon to show actions dropdown.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/theme/bootstrap-ambari.css 98606e9 
>   ambari-web/vendor/scripts/theme/bootstrap-ambari.js 1f61104 
> 
> 
> Diff: https://reviews.apache.org/r/57656/diff/1/
> 
> 
> Testing
> ---
> 
> 20577 passing (28s)
> 153 pending
> 
> 
> Thanks,
> 
> Xi Wang
> 
>



Review Request 57656: Side Nav: several issues and adjustments

2017-03-15 Thread Xi Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57656/
---

Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
Subramanian, and Yusaku Sako.


Bugs: AMBARI-20464
https://issues.apache.org/jira/browse/AMBARI-20464


Repository: ambari


Description
---

1. Scrolling on Side Nav menu can trigger scrolling on the main content. The 
same issue for modals, wizards .etc.
2. Service Actions icon "..." should occupy more space to click on. 
Current behavior: need to click exactly on the icon to show actions dropdown.


Diffs
-

  ambari-web/app/styles/theme/bootstrap-ambari.css 98606e9 
  ambari-web/vendor/scripts/theme/bootstrap-ambari.js 1f61104 


Diff: https://reviews.apache.org/r/57656/diff/1/


Testing
---

20577 passing (28s)
153 pending


Thanks,

Xi Wang