Re: Review Request 57810: Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test Kerberos Client command

2017-03-21 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57810/#review169586
---


Ship it!




Ship It!

- Robert Levas


On March 21, 2017, 1:19 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57810/
> ---
> 
> (Updated March 21, 2017, 1:19 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Robert Levas, Sid Wagle, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20518
> https://issues.apache.org/jira/browse/AMBARI-20518
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test 
> Kerberos Client command
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 555cf4d 
> 
> 
> Diff: https://reviews.apache.org/r/57810/diff/3/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 57810: Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test Kerberos Client command

2017-03-21 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57810/
---

(Updated Март 21, 2017, 5:19 п.п.)


Review request for Ambari, Alejandro Fernandez, Robert Levas, Sid Wagle, and 
Vitalyi Brodetskyi.


Bugs: AMBARI-20518
https://issues.apache.org/jira/browse/AMBARI-20518


Repository: ambari


Description
---

Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test 
Kerberos Client command


Diffs (updated)
-

  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
555cf4d 


Diff: https://reviews.apache.org/r/57810/diff/3/

Changes: https://reviews.apache.org/r/57810/diff/2-3/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 57810: Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test Kerberos Client command

2017-03-21 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57810/
---

(Updated Март 21, 2017, 5:17 п.п.)


Review request for Ambari, Alejandro Fernandez, Robert Levas, Sid Wagle, and 
Vitalyi Brodetskyi.


Bugs: AMBARI-20518
https://issues.apache.org/jira/browse/AMBARI-20518


Repository: ambari


Description
---

Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test 
Kerberos Client command


Diffs (updated)
-

  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
555cf4d 


Diff: https://reviews.apache.org/r/57810/diff/2/

Changes: https://reviews.apache.org/r/57810/diff/1-2/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 57810: Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test Kerberos Client command

2017-03-21 Thread Robert Levas 


> On March 21, 2017, 12:18 p.m., Robert Levas wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py
> > Lines 499-503 (original), 499-503 (patched)
> > 
> >
> > What should `numbus.authorizer` be set to if security is enabled and 
> > the Ranger plug-in is not enabled?

Oops... I misread the code... but there is still no clause to support 
`rangerPluginEnabled` = `None` or `rangerPluginEnabled` = `''` - 
`rangerPluginEnabled` resolving to false.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57810/#review169567
---


On March 21, 2017, 11:52 a.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57810/
> ---
> 
> (Updated March 21, 2017, 11:52 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Robert Levas, Sid Wagle, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20518
> https://issues.apache.org/jira/browse/AMBARI-20518
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test 
> Kerberos Client command
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 555cf4d 
> 
> 
> Diff: https://reviews.apache.org/r/57810/diff/1/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 57810: Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test Kerberos Client command

2017-03-21 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57810/#review169567
---


Fix it, then Ship it!




Ship It!


ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py
Lines 499-503 (original), 499-503 (patched)


What should `numbus.authorizer` be set to if security is enabled and the 
Ranger plug-in is not enabled?



ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py
Line 502 (original), 502 (patched)


Does `'No'.lower()` != `'no'`?


- Robert Levas


On March 21, 2017, 11:52 a.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57810/
> ---
> 
> (Updated March 21, 2017, 11:52 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Robert Levas, Sid Wagle, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20518
> https://issues.apache.org/jira/browse/AMBARI-20518
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test 
> Kerberos Client command
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 555cf4d 
> 
> 
> Diff: https://reviews.apache.org/r/57810/diff/1/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Review Request 57810: Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test Kerberos Client command

2017-03-21 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57810/
---

Review request for Ambari, Alejandro Fernandez, Robert Levas, Sid Wagle, and 
Vitalyi Brodetskyi.


Bugs: AMBARI-20518
https://issues.apache.org/jira/browse/AMBARI-20518


Repository: ambari


Description
---

Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test 
Kerberos Client command


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
555cf4d 


Diff: https://reviews.apache.org/r/57810/diff/1/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen