Re: Review Request 57907: Versions page: unable to set 'Skip Repository Base URL validation' option
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57907/ --- (Updated Березень 24, 2017, 11:52 до полудня) Review request for Ambari and Oleg Nechiporenko. Bugs: AMBARI-20557 https://issues.apache.org/jira/browse/AMBARI-20557 Repository: ambari Description (updated) --- **STR** 1. Go to Versions page. 2. Open Details for any stack version. 2. In opened popup, click 'Edit' icon. 3. In another opened popup, try to set 'Skip Repository Base URL validation' option. **Result** JS error thrown: ``` Uncaught TypeError: Cannot read property 'forEach' of undefined at Class.change (app.js:206179) ``` Option is not set. Diffs - ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_box_view.js a714149 ambari-web/test/views/main/admin/stack_upgrade/upgrade_version_box_view_test.js 58067a2 Diff: https://reviews.apache.org/r/57907/diff/1/ Testing --- 20604 passing (20s) 128 pending Thanks, Andrii Babiichuk
Re: Review Request 57907: Versions page: unable to set 'Skip Repository Base URL validation' option
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57907/#review17 --- Ship it! Ship It! - Oleg Nechiporenko On March 24, 2017, 11:49 a.m., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57907/ > --- > > (Updated March 24, 2017, 11:49 a.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-20557 > https://issues.apache.org/jira/browse/AMBARI-20557 > > > Repository: ambari > > > Description > --- > > **STR** > 1. Go to Versions page. > 2. Open Details for any stack version. > 2. In opened popup, click 'Edit' icon. > 3. In another opened popup, try to set 'Skip Repository Base URL validation' > option. > > **Result** > - JS error thrown: > ``` > Uncaught TypeError: Cannot read property 'forEach' of undefined > at Class.change (app.js:206179) > ``` > - Option is not set. > > > Diffs > - > > ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_box_view.js > a714149 > > ambari-web/test/views/main/admin/stack_upgrade/upgrade_version_box_view_test.js > 58067a2 > > > Diff: https://reviews.apache.org/r/57907/diff/1/ > > > Testing > --- > > 20604 passing (20s) > 128 pending > > > Thanks, > > Andrii Babiichuk > >
Review Request 57907: Versions page: unable to set 'Skip Repository Base URL validation' option
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57907/ --- Review request for Ambari and Oleg Nechiporenko. Bugs: AMBARI-20557 https://issues.apache.org/jira/browse/AMBARI-20557 Repository: ambari Description --- **STR** 1. Go to Versions page. 2. Open Details for any stack version. 2. In opened popup, click 'Edit' icon. 3. In another opened popup, try to set 'Skip Repository Base URL validation' option. **Result** - JS error thrown: ``` Uncaught TypeError: Cannot read property 'forEach' of undefined at Class.change (app.js:206179) ``` - Option is not set. Diffs - ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_box_view.js a714149 ambari-web/test/views/main/admin/stack_upgrade/upgrade_version_box_view_test.js 58067a2 Diff: https://reviews.apache.org/r/57907/diff/1/ Testing --- 20604 passing (20s) 128 pending Thanks, Andrii Babiichuk
