Re: Review Request 57966: Validate HIVE dependency on MYSQL_SERVER on blueprint deployments based on the configuration

2017-03-28 Thread Laszlo Puskas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57966/
---

(Updated March 28, 2017, 2:26 p.m.)


Review request for Ambari, Attila Doroszlai, Robert Levas, Robert Nettleton, 
and Sebastian Toader.


Bugs: AMBARI-20594
https://issues.apache.org/jira/browse/AMBARI-20594


Repository: ambari


Description (updated)
---

Problem:
On blueprint deployments when the HIVE service is configured with default 
values the cluster provisioning fails if the MYSQL_SERVER component is not 
explicitly listed in the blueprint. The failure happens during the cluster 
provisioning and the root cause is hard to be detected.

Solution:
When the cluster template is posted (so that all the configuration is together) 
the cluster topology is validated:

* if HIVE service is required
* if the default hive database is to be used (internal mysql database)
* if the MYSQL_SERVER is not listed in the blueprint

then the cluster creation is interrupted and appropriate error is returned.

pushed to *trunk*:

author  lpuskas 
Mon, 27 Mar 2017 20:31:31 +0200 (20:31 +0200)
committer   lpuskas 
Tue, 28 Mar 2017 16:23:40 +0200 (16:23 +0200)
commit  fa6aa0782e973ff975c7a6b69b410d7a3c5204d4


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
 a63013a 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/HiveServiceValidator.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java
 d92193f 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/validators/HiveServiceValidatorTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/57966/diff/5/


Testing
---

Added unit tests.
Unit tests successfully ran.
Manually tested on local cluster:
- blueprint with HIVE, default configuration, *no* MYSQL_SERVER listed - 
validation failed
- blueprint with HIVE, default configuration, MYSQL_SERVER listed - validation 
passed
- blueprint with HIVE, hive-env/hive_database set to custom value - validation 
passed


Thanks,

Laszlo Puskas

Re: Review Request 57966: Validate HIVE dependency on MYSQL_SERVER on blueprint deployments based on the configuration

2017-03-28 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57966/#review170310
---


Ship it!




Ship It!

- Sebastian Toader


On March 28, 2017, 2:24 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57966/
> ---
> 
> (Updated March 28, 2017, 2:24 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Robert Levas, Robert Nettleton, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20594
> https://issues.apache.org/jira/browse/AMBARI-20594
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problem:
> On blueprint deployments when the HIVE service is configured with default 
> values the cluster provisioning fails if the MYSQL_SERVER component is not 
> explicitly listed in the blueprint. The failure happens during the cluster 
> provisioning and the root cause is hard to be detected.
> 
> Solution:
> When the cluster template is posted (so that all the configuration is 
> together) the cluster topology is validated:
> 
> * if HIVE service is required
> * if the default hive database is to be used (internal mysql database)
> * if the MYSQL_SERVER is not listed in the blueprint
> 
> then the cluster creation is interrupted and appropriate error is returned.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
>  a63013a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/HiveServiceValidator.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java
>  d92193f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/validators/HiveServiceValidatorTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57966/diff/5/
> 
> 
> Testing
> ---
> 
> Added unit tests.
> Unit tests successfully ran.
> Manually tested on local cluster:
> - blueprint with HIVE, default configuration, *no* MYSQL_SERVER listed - 
> validation failed
> - blueprint with HIVE, default configuration, MYSQL_SERVER listed - 
> validation passed
> - blueprint with HIVE, hive-env/hive_database set to custom value - 
> validation passed
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 57966: Validate HIVE dependency on MYSQL_SERVER on blueprint deployments based on the configuration

2017-03-28 Thread Laszlo Puskas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57966/
---

(Updated March 28, 2017, 12:14 p.m.)


Review request for Ambari, Attila Doroszlai, Robert Levas, Robert Nettleton, 
and Sebastian Toader.


Bugs: AMBARI-20594
https://issues.apache.org/jira/browse/AMBARI-20594


Repository: ambari


Description
---

Problem:
On blueprint deployments when the HIVE service is configured with default 
values the cluster provisioning fails if the MYSQL_SERVER component is not 
explicitly listed in the blueprint. The failure happens during the cluster 
provisioning and the root cause is hard to be detected.

Solution:
When the cluster template is posted (so that all the configuration is together) 
the cluster topology is validated:

* if HIVE service is required
* if the default hive database is to be used (internal mysql database)
* if the MYSQL_SERVER is not listed in the blueprint

then the cluster creation is interrupted and appropriate error is returned.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
 a63013a 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/HiveServiceValidator.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java
 d92193f 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/validators/HiveServiceValidatorTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/57966/diff/4/

Changes: https://reviews.apache.org/r/57966/diff/3-4/


Testing
---

Added unit tests.
Unit tests successfully ran.
Manually tested on local cluster:
- blueprint with HIVE, default configuration, *no* MYSQL_SERVER listed - 
validation failed
- blueprint with HIVE, default configuration, MYSQL_SERVER listed - validation 
passed
- blueprint with HIVE, hive-env/hive_database set to custom value - validation 
passed


Thanks,

Laszlo Puskas

Re: Review Request 57966: Validate HIVE dependency on MYSQL_SERVER on blueprint deployments based on the configuration

2017-03-28 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57966/#review170300
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/topology/validators/HiveServiceValidator.java
Lines 51 (patched)


2x String.format


- Attila Doroszlai


On March 28, 2017, 1:46 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57966/
> ---
> 
> (Updated March 28, 2017, 1:46 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Robert Levas, Robert Nettleton, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20594
> https://issues.apache.org/jira/browse/AMBARI-20594
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problem:
> On blueprint deployments when the HIVE service is configured with default 
> values the cluster provisioning fails if the MYSQL_SERVER component is not 
> explicitly listed in the blueprint. The failure happens during the cluster 
> provisioning and the root cause is hard to be detected.
> 
> Solution:
> When the cluster template is posted (so that all the configuration is 
> together) the cluster topology is validated:
> 
> * if HIVE service is required
> * if the default hive database is to be used (internal mysql database)
> * if the MYSQL_SERVER is not listed in the blueprint
> 
> then the cluster creation is interrupted and appropriate error is returned.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
>  a63013a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/HiveServiceValidator.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java
>  d92193f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/validators/HiveServiceValidatorTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57966/diff/3/
> 
> 
> Testing
> ---
> 
> Added unit tests.
> Unit tests successfully ran.
> Manually tested on local cluster:
> - blueprint with HIVE, default configuration, *no* MYSQL_SERVER listed - 
> validation failed
> - blueprint with HIVE, default configuration, MYSQL_SERVER listed - 
> validation passed
> - blueprint with HIVE, hive-env/hive_database set to custom value - 
> validation passed
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 57966: Validate HIVE dependency on MYSQL_SERVER on blueprint deployments based on the configuration

2017-03-28 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57966/#review170274
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/topology/validators/HiveServiceValidator.java
Lines 1 (patched)


missing licence



ambari-server/src/main/java/org/apache/ambari/server/topology/validators/HiveServiceValidator.java
Lines 37-38 (patched)


please reduce duplication in error message



ambari-server/src/main/java/org/apache/ambari/server/topology/validators/HiveServiceValidator.java
Lines 49-52 (patched)


please reduce duplication of error messages



ambari-server/src/test/java/org/apache/ambari/server/topology/validators/HiveServiceValidatorTest.java
Lines 1 (patched)


missing licence


- Attila Doroszlai


On March 27, 2017, 10:12 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57966/
> ---
> 
> (Updated March 27, 2017, 10:12 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Robert Levas, Robert Nettleton, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20594
> https://issues.apache.org/jira/browse/AMBARI-20594
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problem:
> On blueprint deployments when the HIVE service is configured with default 
> values the cluster provisioning fails if the MYSQL_SERVER component is not 
> explicitly listed in the blueprint. The failure happens during the cluster 
> provisioning and the root cause is hard to be detected.
> 
> Solution:
> When the cluster template is posted (so that all the configuration is 
> together) the cluster topology is validated:
> 
> * if HIVE service is required
> * if the default hive database is to be used (internal mysql database)
> * if the MYSQL_SERVER is not listed in the blueprint
> 
> then the cluster creation is interrupted and appropriate error is returned.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
>  a63013a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/HiveServiceValidator.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java
>  d92193f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/validators/HiveServiceValidatorTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57966/diff/2/
> 
> 
> Testing
> ---
> 
> Added unit tests.
> Unit tests successfully ran.
> Manually tested on local cluster:
> - blueprint with HIVE, default configuration, *no* MYSQL_SERVER listed - 
> validation failed
> - blueprint with HIVE, default configuration, MYSQL_SERVER listed - 
> validation passed
> - blueprint with HIVE, hive-env/hive_database set to custom value - 
> validation passed
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 57966: Validate HIVE dependency on MYSQL_SERVER on blueprint deployments based on the configuration

2017-03-28 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57966/#review170261
---




ambari-server/src/main/java/org/apache/ambari/server/topology/validators/HiveServiceValidator.java
Lines 42 (patched)


HIVE_DB_DEFAULT.equals() is safer to avoid any NPE.


- Sebastian Toader


On March 27, 2017, 10:12 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57966/
> ---
> 
> (Updated March 27, 2017, 10:12 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Robert Levas, Robert Nettleton, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20594
> https://issues.apache.org/jira/browse/AMBARI-20594
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problem:
> On blueprint deployments when the HIVE service is configured with default 
> values the cluster provisioning fails if the MYSQL_SERVER component is not 
> explicitly listed in the blueprint. The failure happens during the cluster 
> provisioning and the root cause is hard to be detected.
> 
> Solution:
> When the cluster template is posted (so that all the configuration is 
> together) the cluster topology is validated:
> 
> * if HIVE service is required
> * if the default hive database is to be used (internal mysql database)
> * if the MYSQL_SERVER is not listed in the blueprint
> 
> then the cluster creation is interrupted and appropriate error is returned.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
>  a63013a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/HiveServiceValidator.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java
>  d92193f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/validators/HiveServiceValidatorTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57966/diff/2/
> 
> 
> Testing
> ---
> 
> Added unit tests.
> Unit tests successfully ran.
> Manually tested on local cluster:
> - blueprint with HIVE, default configuration, *no* MYSQL_SERVER listed - 
> validation failed
> - blueprint with HIVE, default configuration, MYSQL_SERVER listed - 
> validation passed
> - blueprint with HIVE, hive-env/hive_database set to custom value - 
> validation passed
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 57966: Validate HIVE dependency on MYSQL_SERVER on blueprint deployments based on the configuration

2017-03-27 Thread Laszlo Puskas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57966/
---

(Updated March 27, 2017, 8:12 p.m.)


Review request for Ambari, Attila Doroszlai, Robert Levas, Robert Nettleton, 
and Sebastian Toader.


Bugs: AMBARI-20594
https://issues.apache.org/jira/browse/AMBARI-20594


Repository: ambari


Description (updated)
---

Problem:
On blueprint deployments when the HIVE service is configured with default 
values the cluster provisioning fails if the MYSQL_SERVER component is not 
explicitly listed in the blueprint. The failure happens during the cluster 
provisioning and the root cause is hard to be detected.

Solution:
When the cluster template is posted (so that all the configuration is together) 
the cluster topology is validated:

* if HIVE service is required
* if the default hive database is to be used (internal mysql database)
* if the MYSQL_SERVER is not listed in the blueprint

then the cluster creation is interrupted and appropriate error is returned.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
 a63013a 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/HiveServiceValidator.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java
 d92193f 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/validators/HiveServiceValidatorTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/57966/diff/2/


Testing (updated)
---

Added unit tests.
Unit tests successfully ran.
Manually tested on local cluster:
- blueprint with HIVE, default configuration, *no* MYSQL_SERVER listed - 
validation failed
- blueprint with HIVE, default configuration, MYSQL_SERVER listed - validation 
passed
- blueprint with HIVE, hive-env/hive_database set to custom value - validation 
passed


Thanks,

Laszlo Puskas

Re: Review Request 57966: Validate HIVE dependency on MYSQL_SERVER on blueprint deployments based on the configuration

2017-03-27 Thread Laszlo Puskas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57966/
---

(Updated March 27, 2017, 7:45 p.m.)


Review request for Ambari, Attila Doroszlai, Robert Levas, Robert Nettleton, 
and Sebastian Toader.


Changes
---

Fixed failing unit tests. Formatted strings.


Bugs: AMBARI-20594
https://issues.apache.org/jira/browse/AMBARI-20594


Repository: ambari


Description
---

Problem:
On blueprint deployments when the HIVE service is configured with default 
values the cluster provisioning fails if the MYSQL_SERVER component is not 
explicitly listed in the blueprint. The filure happens during the cluster 
provisioning and the root cause is hard to be detected.

Solution:
When the cluster template is posted (so that all the configuration is together) 
the cluster topology is validated:

* if HIVE service is required
* if the default hive database is to be used (internal mysql database)
* if the MYSQL_SERVER is not listed in the blueprint

then the cluster creation is interrupted and appropriate error is returned.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
 a63013a 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/HiveServiceValidator.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java
 d92193f 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/validators/HiveServiceValidatorTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/57966/diff/2/

Changes: https://reviews.apache.org/r/57966/diff/1-2/


Testing (updated)
---

Added unit tests.
Unit tests successfully ran.
Manual testing in progress.


Thanks,

Laszlo Puskas

Re: Review Request 57966: Validate HIVE dependency on MYSQL_SERVER on blueprint deployments based on the configuration

2017-03-27 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57966/#review170211
---


Ship it!




Ship It!

- Robert Levas


On March 27, 2017, 2:54 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57966/
> ---
> 
> (Updated March 27, 2017, 2:54 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Robert Levas, Robert Nettleton, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20594
> https://issues.apache.org/jira/browse/AMBARI-20594
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problem:
> On blueprint deployments when the HIVE service is configured with default 
> values the cluster provisioning fails if the MYSQL_SERVER component is not 
> explicitly listed in the blueprint. The filure happens during the cluster 
> provisioning and the root cause is hard to be detected.
> 
> Solution:
> When the cluster template is posted (so that all the configuration is 
> together) the cluster topology is validated:
> 
> * if HIVE service is required
> * if the default hive database is to be used (internal mysql database)
> * if the MYSQL_SERVER is not listed in the blueprint
> 
> then the cluster creation is interrupted and appropriate error is returned.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
>  a63013a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/HiveServiceValidator.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/validators/HiveServiceValidatorTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57966/diff/1/
> 
> 
> Testing
> ---
> 
> Added unit tests.
> Related unit tests being fixed.
> Manual testing in progress.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 57966: Validate HIVE dependency on MYSQL_SERVER on blueprint deployments based on the configuration

2017-03-27 Thread Laszlo Puskas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57966/
---

(Updated March 27, 2017, 6:54 p.m.)


Review request for Ambari, Attila Doroszlai, Robert Levas, Robert Nettleton, 
and Sebastian Toader.


Bugs: AMBARI-20594
https://issues.apache.org/jira/browse/AMBARI-20594


Repository: ambari


Description (updated)
---

Problem:
On blueprint deployments when the HIVE service is configured with default 
values the cluster provisioning fails if the MYSQL_SERVER component is not 
explicitly listed in the blueprint. The filure happens during the cluster 
provisioning and the root cause is hard to be detected.

Solution:
When the cluster template is posted (so that all the configuration is together) 
the cluster topology is validated:

* if HIVE service is required
* if the default hive database is to be used (internal mysql database)
* if the MYSQL_SERVER is not listed in the blueprint

then the cluster creation is interrupted and appropriate error is returned.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
 a63013a 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/HiveServiceValidator.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/validators/HiveServiceValidatorTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/57966/diff/1/


Testing
---

Added unit tests.
Related unit tests being fixed.
Manual testing in progress.


Thanks,

Laszlo Puskas

Review Request 57966: Validate HIVE dependency on MYSQL_SERVER on blueprint deployments based on the configuration

2017-03-27 Thread Laszlo Puskas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57966/
---

Review request for Ambari, Attila Doroszlai, Robert Levas, Robert Nettleton, 
and Sebastian Toader.


Bugs: AMBARI-20594
https://issues.apache.org/jira/browse/AMBARI-20594


Repository: ambari


Description
---

Problem:
On blueprint deployments when the HIVE service is configured with default 
values the cluster provisioning fails if the MYSQL_SERVER component is not 
explicitly listed in the blueprint. The filure happens during the cluster 
provisioning and the root cause is hard to be detected.

Solution:
When the cluster template is posted (so that all the configuration is together) 
the cluster topology is validated:

* if hive service is required
* if the default hive database is to be used
* if the MYSQL_SERVER is not listed in the blueprint

then the cluster creation is interrupted and appropriate error is returned.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
 a63013a 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/HiveServiceValidator.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/validators/HiveServiceValidatorTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/57966/diff/1/


Testing
---

Added unit tests.
Related unit tests being fixed.
Manual testing in progress.


Thanks,

Laszlo Puskas