Re: Review Request 58022: AMBARI-19149. Code cleanup: redundant type arguments

2017-03-29 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58022/#review170386
---


Ship it!




Ship It!

- Nate Cole


On March 29, 2017, 7:06 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58022/
> ---
> 
> (Updated March 29, 2017, 7:06 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Sandor 
> Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19149
> https://issues.apache.org/jira/browse/AMBARI-19149
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Removed type arguments that Java 7 can infer.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/KdcServerConnectionVerification.java
>  99e714dd5a6625825dc8cb3d8630f99da06bdce4 
>   ambari-server/src/main/java/org/apache/ambari/server/Role.java 
> 1fceb293ec8cecaa8a92657b3add8ab60254030e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
>  14f02d29690dc08209814603cff1f0b838bdc247 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java
>  237214d83567458ecc18e063326c38db0e103f85 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
>  c8e45321ca40cacc011bda8818ee19350ecc88ba 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java
>  502c016f40f4b8a23a2bfc859a7eb71f71083f6b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 
> f7ceca21676ac4663a944acf8ba945b31cd67135 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/ActionQueue.java 
> d6d5a35e2d97d7b4e721a613fd92b9a106aaf714 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/AgentRequests.java 
> d0b7cc6b2fed514db6e5b695b7904965181d5569 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  edf12514a2966d4f29877e93c702f107ed83f37a 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeat.java 
> 0323479b85f34ab002d77aec5cf1bb4d7690c8be 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  7c833f6b5719c0393e274396826963c0a1f9e70c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatResponse.java
>  02970a1dff2423d325ac8109cc0db2f1c5189ad9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  0042f53c7edd17c8ab7c1b571839fd4945a3dd2e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  4fbc161d9405e427b149d620208ac02e914e0ae8 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HostInfo.java 
> 988e78b5a903c9effeeb3c3fa80aaf9dce1e526f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/RecoveryReport.java
>  40b2260a5c3e59bd2e7304576d71e8c0044c9c54 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/RegistrationResponse.java
>  c12ed82d3354d8b35e1bb053c62327ae40cc656d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/StatusCommand.java 
> 5dd9e6f7765a1cf9384c9295c5321398530a3857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/alerts/AmbariPerformanceRunnable.java
>  11e87d0f759b80d096e112b818d2942eadffe49c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/alerts/StaleAlertRunnable.java
>  7cb679b60ec477bac50d14ec4d7d837adb2b8ef8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/AmbariCsrfProtectionFilter.java
>  60c0e77ed5a40071eac32c331776c419ae97f12c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/AmbariErrorHandler.java
>  3f40ac883a0066f1fb59af1d8591edae7c9a494c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/handlers/QueryCreateHandler.java
>  beb8ea26401b1651d616337d5e9e718214a563ff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryLexer.java
>  f76745424328b512e6341b8a70e0cdd68202da35 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryParser.java
>  738681351d3fa73a7f2abd2cd76b49735ab69c34 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/expressions/AbstractExpression.java
>  db4220ee593e8ef1bc0198112aa81453b91b416f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/expressions/NotLogicalExpression.java
>  225357034eba249995de7dc36085add62f63b3cc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/EqualsOperator.java
>  ddd9e0dccc981d83b642abc4bb6501e46aed906f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/GreaterEqualsOperator.java
>

Re: Review Request 58022: AMBARI-19149. Code cleanup: redundant type arguments

2017-03-29 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58022/#review170385
---


Ship it!




Ship It!

- Sebastian Toader


On March 29, 2017, 1:06 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58022/
> ---
> 
> (Updated March 29, 2017, 1:06 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Sandor 
> Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19149
> https://issues.apache.org/jira/browse/AMBARI-19149
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Removed type arguments that Java 7 can infer.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/KdcServerConnectionVerification.java
>  99e714dd5a6625825dc8cb3d8630f99da06bdce4 
>   ambari-server/src/main/java/org/apache/ambari/server/Role.java 
> 1fceb293ec8cecaa8a92657b3add8ab60254030e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
>  14f02d29690dc08209814603cff1f0b838bdc247 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java
>  237214d83567458ecc18e063326c38db0e103f85 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
>  c8e45321ca40cacc011bda8818ee19350ecc88ba 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java
>  502c016f40f4b8a23a2bfc859a7eb71f71083f6b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 
> f7ceca21676ac4663a944acf8ba945b31cd67135 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/ActionQueue.java 
> d6d5a35e2d97d7b4e721a613fd92b9a106aaf714 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/AgentRequests.java 
> d0b7cc6b2fed514db6e5b695b7904965181d5569 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  edf12514a2966d4f29877e93c702f107ed83f37a 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeat.java 
> 0323479b85f34ab002d77aec5cf1bb4d7690c8be 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  7c833f6b5719c0393e274396826963c0a1f9e70c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatResponse.java
>  02970a1dff2423d325ac8109cc0db2f1c5189ad9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  0042f53c7edd17c8ab7c1b571839fd4945a3dd2e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  4fbc161d9405e427b149d620208ac02e914e0ae8 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HostInfo.java 
> 988e78b5a903c9effeeb3c3fa80aaf9dce1e526f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/RecoveryReport.java
>  40b2260a5c3e59bd2e7304576d71e8c0044c9c54 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/RegistrationResponse.java
>  c12ed82d3354d8b35e1bb053c62327ae40cc656d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/StatusCommand.java 
> 5dd9e6f7765a1cf9384c9295c5321398530a3857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/alerts/AmbariPerformanceRunnable.java
>  11e87d0f759b80d096e112b818d2942eadffe49c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/alerts/StaleAlertRunnable.java
>  7cb679b60ec477bac50d14ec4d7d837adb2b8ef8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/AmbariCsrfProtectionFilter.java
>  60c0e77ed5a40071eac32c331776c419ae97f12c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/AmbariErrorHandler.java
>  3f40ac883a0066f1fb59af1d8591edae7c9a494c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/handlers/QueryCreateHandler.java
>  beb8ea26401b1651d616337d5e9e718214a563ff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryLexer.java
>  f76745424328b512e6341b8a70e0cdd68202da35 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryParser.java
>  738681351d3fa73a7f2abd2cd76b49735ab69c34 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/expressions/AbstractExpression.java
>  db4220ee593e8ef1bc0198112aa81453b91b416f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/expressions/NotLogicalExpression.java
>  225357034eba249995de7dc36085add62f63b3cc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/EqualsOperator.java
>  ddd9e0dccc981d83b642abc4bb6501e46aed906f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/GreaterEqualsOperator.java
>

Re: Review Request 58022: AMBARI-19149. Code cleanup: redundant type arguments

2017-03-29 Thread Laszlo Puskas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58022/#review170377
---


Ship it!




Ship It!

- Laszlo Puskas


On March 29, 2017, 11:06 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58022/
> ---
> 
> (Updated March 29, 2017, 11:06 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Sandor 
> Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19149
> https://issues.apache.org/jira/browse/AMBARI-19149
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Removed type arguments that Java 7 can infer.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/KdcServerConnectionVerification.java
>  99e714dd5a6625825dc8cb3d8630f99da06bdce4 
>   ambari-server/src/main/java/org/apache/ambari/server/Role.java 
> 1fceb293ec8cecaa8a92657b3add8ab60254030e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
>  14f02d29690dc08209814603cff1f0b838bdc247 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java
>  237214d83567458ecc18e063326c38db0e103f85 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
>  c8e45321ca40cacc011bda8818ee19350ecc88ba 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java
>  502c016f40f4b8a23a2bfc859a7eb71f71083f6b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 
> f7ceca21676ac4663a944acf8ba945b31cd67135 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/ActionQueue.java 
> d6d5a35e2d97d7b4e721a613fd92b9a106aaf714 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/AgentRequests.java 
> d0b7cc6b2fed514db6e5b695b7904965181d5569 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  edf12514a2966d4f29877e93c702f107ed83f37a 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeat.java 
> 0323479b85f34ab002d77aec5cf1bb4d7690c8be 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  7c833f6b5719c0393e274396826963c0a1f9e70c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatResponse.java
>  02970a1dff2423d325ac8109cc0db2f1c5189ad9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  0042f53c7edd17c8ab7c1b571839fd4945a3dd2e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  4fbc161d9405e427b149d620208ac02e914e0ae8 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HostInfo.java 
> 988e78b5a903c9effeeb3c3fa80aaf9dce1e526f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/RecoveryReport.java
>  40b2260a5c3e59bd2e7304576d71e8c0044c9c54 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/RegistrationResponse.java
>  c12ed82d3354d8b35e1bb053c62327ae40cc656d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/StatusCommand.java 
> 5dd9e6f7765a1cf9384c9295c5321398530a3857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/alerts/AmbariPerformanceRunnable.java
>  11e87d0f759b80d096e112b818d2942eadffe49c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/alerts/StaleAlertRunnable.java
>  7cb679b60ec477bac50d14ec4d7d837adb2b8ef8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/AmbariCsrfProtectionFilter.java
>  60c0e77ed5a40071eac32c331776c419ae97f12c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/AmbariErrorHandler.java
>  3f40ac883a0066f1fb59af1d8591edae7c9a494c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/handlers/QueryCreateHandler.java
>  beb8ea26401b1651d616337d5e9e718214a563ff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryLexer.java
>  f76745424328b512e6341b8a70e0cdd68202da35 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryParser.java
>  738681351d3fa73a7f2abd2cd76b49735ab69c34 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/expressions/AbstractExpression.java
>  db4220ee593e8ef1bc0198112aa81453b91b416f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/expressions/NotLogicalExpression.java
>  225357034eba249995de7dc36085add62f63b3cc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/EqualsOperator.java
>  ddd9e0dccc981d83b642abc4bb6501e46aed906f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/GreaterEqualsOperator.java
>

Review Request 58022: AMBARI-19149. Code cleanup: redundant type arguments

2017-03-29 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58022/
---

Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Sandor 
Magyari, and Sebastian Toader.


Bugs: AMBARI-19149
https://issues.apache.org/jira/browse/AMBARI-19149


Repository: ambari


Description
---

Removed type arguments that Java 7 can infer.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/KdcServerConnectionVerification.java
 99e714dd5a6625825dc8cb3d8630f99da06bdce4 
  ambari-server/src/main/java/org/apache/ambari/server/Role.java 
1fceb293ec8cecaa8a92657b3add8ab60254030e 
  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
 14f02d29690dc08209814603cff1f0b838bdc247 
  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java
 237214d83567458ecc18e063326c38db0e103f85 
  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
 c8e45321ca40cacc011bda8818ee19350ecc88ba 
  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java 
502c016f40f4b8a23a2bfc859a7eb71f71083f6b 
  ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 
f7ceca21676ac4663a944acf8ba945b31cd67135 
  ambari-server/src/main/java/org/apache/ambari/server/agent/ActionQueue.java 
d6d5a35e2d97d7b4e721a613fd92b9a106aaf714 
  ambari-server/src/main/java/org/apache/ambari/server/agent/AgentRequests.java 
d0b7cc6b2fed514db6e5b695b7904965181d5569 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 edf12514a2966d4f29877e93c702f107ed83f37a 
  ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeat.java 
0323479b85f34ab002d77aec5cf1bb4d7690c8be 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
 7c833f6b5719c0393e274396826963c0a1f9e70c 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatResponse.java
 02970a1dff2423d325ac8109cc0db2f1c5189ad9 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
 0042f53c7edd17c8ab7c1b571839fd4945a3dd2e 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
 4fbc161d9405e427b149d620208ac02e914e0ae8 
  ambari-server/src/main/java/org/apache/ambari/server/agent/HostInfo.java 
988e78b5a903c9effeeb3c3fa80aaf9dce1e526f 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/RecoveryReport.java 
40b2260a5c3e59bd2e7304576d71e8c0044c9c54 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/RegistrationResponse.java
 c12ed82d3354d8b35e1bb053c62327ae40cc656d 
  ambari-server/src/main/java/org/apache/ambari/server/agent/StatusCommand.java 
5dd9e6f7765a1cf9384c9295c5321398530a3857 
  
ambari-server/src/main/java/org/apache/ambari/server/alerts/AmbariPerformanceRunnable.java
 11e87d0f759b80d096e112b818d2942eadffe49c 
  
ambari-server/src/main/java/org/apache/ambari/server/alerts/StaleAlertRunnable.java
 7cb679b60ec477bac50d14ec4d7d837adb2b8ef8 
  
ambari-server/src/main/java/org/apache/ambari/server/api/AmbariCsrfProtectionFilter.java
 60c0e77ed5a40071eac32c331776c419ae97f12c 
  
ambari-server/src/main/java/org/apache/ambari/server/api/AmbariErrorHandler.java
 3f40ac883a0066f1fb59af1d8591edae7c9a494c 
  
ambari-server/src/main/java/org/apache/ambari/server/api/handlers/QueryCreateHandler.java
 beb8ea26401b1651d616337d5e9e718214a563ff 
  
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryLexer.java
 f76745424328b512e6341b8a70e0cdd68202da35 
  
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryParser.java
 738681351d3fa73a7f2abd2cd76b49735ab69c34 
  
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/expressions/AbstractExpression.java
 db4220ee593e8ef1bc0198112aa81453b91b416f 
  
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/expressions/NotLogicalExpression.java
 225357034eba249995de7dc36085add62f63b3cc 
  
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/EqualsOperator.java
 ddd9e0dccc981d83b642abc4bb6501e46aed906f 
  
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/GreaterEqualsOperator.java
 175a255d0d2a6081f075a73095901cd45656c6dd 
  
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/GreaterOperator.java
 832507c0ff3c91cff168c035c18b8de849c17b0d 
  
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/InOperator.java
 b3f7ef644ec5fb46bc9c54c34e2098cfd1fb3b3f 
  
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/LessEqualsOperator.java
 bd6e5681255fbca6c62f5e7d7c9c15e44689e33b 
  
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/LessOperator.java
 8cf378ef292261d850e4023235c72ed5b447b4ae