Re: Review Request 58134: Bad user experience in workflow credential creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58134/ --- (Updated April 4, 2017, 6 a.m.) Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and Pallav Kulshreshtha. Bugs: AMBARI-20653 https://issues.apache.org/jira/browse/AMBARI-20653 Repository: ambari Description --- Removed the save button Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-credentials.js 1072ca4 contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 673ae6a contrib/views/wfmanager/src/main/resources/ui/app/templates/components/credentials-config.hbs 366920d contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-credentials.hbs 464221f Diff: https://reviews.apache.org/r/58134/diff/2/ Testing --- Manual Thanks, Madhan Reddy
Re: Review Request 58134: Bad user experience in workflow credential creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58134/#review170854 --- Ship it! Ship It! - belliraj hb On April 3, 2017, 8:07 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58134/ > --- > > (Updated April 3, 2017, 8:07 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20653 > https://issues.apache.org/jira/browse/AMBARI-20653 > > > Repository: ambari > > > Description > --- > > Removed the save button > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-credentials.js > 1072ca4 > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 673ae6a > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/credentials-config.hbs > 366920d > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-credentials.hbs > 464221f > > > Diff: https://reviews.apache.org/r/58134/diff/2/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 58134: Bad user experience in workflow credential creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58134/#review170823 --- Ship it! Ship It! - Padma Priya N On April 3, 2017, 8:07 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58134/ > --- > > (Updated April 3, 2017, 8:07 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20653 > https://issues.apache.org/jira/browse/AMBARI-20653 > > > Repository: ambari > > > Description > --- > > Removed the save button > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-credentials.js > 1072ca4 > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 673ae6a > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/credentials-config.hbs > 366920d > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-credentials.hbs > 464221f > > > Diff: https://reviews.apache.org/r/58134/diff/2/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 58134: Bad user experience in workflow credential creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58134/ --- (Updated April 3, 2017, 8:07 a.m.) Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and Pallav Kulshreshtha. Bugs: AMBARI-20653 https://issues.apache.org/jira/browse/AMBARI-20653 Repository: ambari Description --- Removed the save button Diffs (updated) - contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-credentials.js 1072ca4 contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 673ae6a contrib/views/wfmanager/src/main/resources/ui/app/templates/components/credentials-config.hbs 366920d contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-credentials.hbs 464221f Diff: https://reviews.apache.org/r/58134/diff/2/ Changes: https://reviews.apache.org/r/58134/diff/1-2/ Testing --- Manual Thanks, Madhan Reddy
Review Request 58134: Bad user experience in workflow credential creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58134/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and Pallav Kulshreshtha. Bugs: AMBARI-20653 https://issues.apache.org/jira/browse/AMBARI-20653 Repository: ambari Description --- Removed the save button Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-credentials.js 1072ca4 contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 673ae6a contrib/views/wfmanager/src/main/resources/ui/app/templates/components/credentials-config.hbs 366920d contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-credentials.hbs 464221f Diff: https://reviews.apache.org/r/58134/diff/1/ Testing --- Manual Thanks, Madhan Reddy
