Re: Review Request 58177: Host checks: incorrect message for single host warnings

2017-04-04 Thread Aleksandr Kovalenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58177/#review170979
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Апрель 4, 2017, 4:23 п.п., Andrii Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58177/
> ---
> 
> (Updated Апрель 4, 2017, 4:23 п.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-20671
> https://issues.apache.org/jira/browse/AMBARI-20671
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If there are some warnings for single host in host checks popup, messages for 
> them are incorrect ('1 hosts' instead of '1 host').
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step3_controller.js 7a07253 
>   ambari-web/app/mixins/main/host/details/actions/check_host.js fbee24c 
>   ambari-web/app/templates/wizard/step3/step3_host_warnings_popup.hbs e8c5201 
>   ambari-web/test/controllers/wizard/step3_test.js fa90065 
> 
> 
> Diff: https://reviews.apache.org/r/58177/diff/1/
> 
> 
> Testing
> ---
> 
> 20674 passing (24s)
>   128 pending
> 
> 
> Thanks,
> 
> Andrii Babiichuk
> 
>



Review Request 58177: Host checks: incorrect message for single host warnings

2017-04-04 Thread Andrii Babiichuk

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58177/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-20671
https://issues.apache.org/jira/browse/AMBARI-20671


Repository: ambari


Description
---

If there are some warnings for single host in host checks popup, messages for 
them are incorrect ('1 hosts' instead of '1 host').


Diffs
-

  ambari-web/app/controllers/wizard/step3_controller.js 7a07253 
  ambari-web/app/mixins/main/host/details/actions/check_host.js fbee24c 
  ambari-web/app/templates/wizard/step3/step3_host_warnings_popup.hbs e8c5201 
  ambari-web/test/controllers/wizard/step3_test.js fa90065 


Diff: https://reviews.apache.org/r/58177/diff/1/


Testing
---

20674 passing (24s)
  128 pending


Thanks,

Andrii Babiichuk