Re: Review Request 58616: Need a confirmation dialog for table / database delete

2017-04-21 Thread Gaurav Nagar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58616/#review172653
---


Ship it!




Ship It!

- Gaurav Nagar


On April 21, 2017, 12:54 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58616/
> ---
> 
> (Updated April 21, 2017, 12:54 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20815
> https://issues.apache.org/jira/browse/AMBARI-20815
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added a dialog for taking confirmation from the user for table delete.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table.js
>  53055cf 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/table.hbs
>  2fe3cfb 
> 
> 
> Diff: https://reviews.apache.org/r/58616/diff/1/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>



Re: Review Request 58616: Need a confirmation dialog for table / database delete

2017-04-21 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58616/#review172652
---


Ship it!




Ship It!

- venkat sairam


On April 21, 2017, 12:54 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58616/
> ---
> 
> (Updated April 21, 2017, 12:54 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20815
> https://issues.apache.org/jira/browse/AMBARI-20815
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added a dialog for taking confirmation from the user for table delete.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table.js
>  53055cf 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/table.hbs
>  2fe3cfb 
> 
> 
> Diff: https://reviews.apache.org/r/58616/diff/1/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>



Review Request 58616: Need a confirmation dialog for table / database delete

2017-04-21 Thread Pallav Kulshreshtha

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58616/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
Rohit Choudhary, and venkat sairam.


Bugs: AMBARI-20815
https://issues.apache.org/jira/browse/AMBARI-20815


Repository: ambari


Description
---

Added a dialog for taking confirmation from the user for table delete.


Diffs
-

  
contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table.js
 53055cf 
  
contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/table.hbs
 2fe3cfb 


Diff: https://reviews.apache.org/r/58616/diff/1/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha