Re: Review Request 59043: AMBARI-20951. Integrate HostService resource with swagger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59043/#review174186 --- Ship it! Ship It! - Balázs Bence Sári On May 8, 2017, 7 a.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59043/ > --- > > (Updated May 8, 2017, 7 a.m.) > > > Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Jayush Luniya, > Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-20951 > https://issues.apache.org/jira/browse/AMBARI-20951 > > > Repository: ambari > > > Description > --- > > * documented `HostService`, `HostRequest`, `HostResponse` > * removed unused attributes > * introduced constants for common Swagger parameters > * subresources are not covered yet > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java > 0185d37f1a9127c2bd414229b8ab7885e849fbf4 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java > c26c5d85d4c90a1aee81cb5aafbcac49d185c5e2 > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/HostEventCreator.java > d05fe9dce86eaa712807c50744c1fb93000fbe56 > > ambari-server/src/main/java/org/apache/ambari/server/controller/HostRequest.java > a6168394bf4be45497924e73c84aae393d1c53fe > > ambari-server/src/main/java/org/apache/ambari/server/controller/HostResponse.java > 8032801dd7014b9532b5358c8fc44e5250b90c66 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java > 40fe3697e98acff0a36dd24f3e51193683b5af93 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java > f604a7f8be9b2dad7810e46444ae79ead73f8a98 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStatusHelper.java > 96457ed6302f98f6b402eb27f49cffc41bfe4585 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProvider.java > c2fb844ff7e81d8291ae27359dac864aadf50430 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java > b5d2f9de8a297b68ee569b92bc475e39b39986d2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java > c747a33a7d352d8614a573a6b9f3f7149ac5df7c > > ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java > db228b194e240a0c895072362ae68d1973742cef > > ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java > 6d12402e9da92985176c8724f6b705304bba03e3 > > ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java > 168d13b44777b1891e72287de035e99d1064ab72 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/HostServiceTest.java > 6aef04dda19693cd2408dcfce9be5ca8751550e4 > > ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/HostEventCreatorTest.java > 2d1cefcfdcb3604d54338c4c0b314c5fbb740b50 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 554e0891020d90593aeee76cbeddf65f5b66e2b0 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java > c7613231b13c8402cffe29f90fac2449e0f0a395 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java > ac6ac1d299947a3b4ba0f0f41f7a6f851b2a72db > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProviderTest.java > f15c9f2baa20fb69b855d24badb144e354b83891 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ScaleClusterRequestTest.java > 48d1351dc527488cea06168d2fe0fcc90d9a6eb7 > > ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java > 2d5978b1788572c716ddfaae2e56b9502097e98f > > > Diff: https://reviews.apache.org/r/59043/diff/1/ > > > Testing > --- > > Unit tests pass, except `ServicePropertiesTest`, which fails due to > [AMBARI-20443](https://issues.apache.org/jira/browse/AMBARI-20443). > > ``` > $ mvn -am -pl ambari-server clean test > ... > Tests in error: > ServicePropertiesTest.validatePropertySchemaOfServiceXMLs:49 » Ambari File > /Us... > > Tests run: 4971, Failures: 0, Errors: 1, Skipped: 39 > ``` > > > Thanks, > > Attila Doroszlai > >
Re: Review Request 59043: AMBARI-20951. Integrate HostService resource with swagger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59043/#review174170 --- Ship it! Ship It! - Jaimin Jetly On May 8, 2017, 7 a.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59043/ > --- > > (Updated May 8, 2017, 7 a.m.) > > > Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Jayush Luniya, > Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-20951 > https://issues.apache.org/jira/browse/AMBARI-20951 > > > Repository: ambari > > > Description > --- > > * documented `HostService`, `HostRequest`, `HostResponse` > * removed unused attributes > * introduced constants for common Swagger parameters > * subresources are not covered yet > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java > 0185d37f1a9127c2bd414229b8ab7885e849fbf4 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java > c26c5d85d4c90a1aee81cb5aafbcac49d185c5e2 > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/HostEventCreator.java > d05fe9dce86eaa712807c50744c1fb93000fbe56 > > ambari-server/src/main/java/org/apache/ambari/server/controller/HostRequest.java > a6168394bf4be45497924e73c84aae393d1c53fe > > ambari-server/src/main/java/org/apache/ambari/server/controller/HostResponse.java > 8032801dd7014b9532b5358c8fc44e5250b90c66 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java > 40fe3697e98acff0a36dd24f3e51193683b5af93 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java > f604a7f8be9b2dad7810e46444ae79ead73f8a98 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStatusHelper.java > 96457ed6302f98f6b402eb27f49cffc41bfe4585 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProvider.java > c2fb844ff7e81d8291ae27359dac864aadf50430 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java > b5d2f9de8a297b68ee569b92bc475e39b39986d2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java > c747a33a7d352d8614a573a6b9f3f7149ac5df7c > > ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java > db228b194e240a0c895072362ae68d1973742cef > > ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java > 6d12402e9da92985176c8724f6b705304bba03e3 > > ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java > 168d13b44777b1891e72287de035e99d1064ab72 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/HostServiceTest.java > 6aef04dda19693cd2408dcfce9be5ca8751550e4 > > ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/HostEventCreatorTest.java > 2d1cefcfdcb3604d54338c4c0b314c5fbb740b50 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 554e0891020d90593aeee76cbeddf65f5b66e2b0 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java > c7613231b13c8402cffe29f90fac2449e0f0a395 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java > ac6ac1d299947a3b4ba0f0f41f7a6f851b2a72db > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProviderTest.java > f15c9f2baa20fb69b855d24badb144e354b83891 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ScaleClusterRequestTest.java > 48d1351dc527488cea06168d2fe0fcc90d9a6eb7 > > ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java > 2d5978b1788572c716ddfaae2e56b9502097e98f > > > Diff: https://reviews.apache.org/r/59043/diff/1/ > > > Testing > --- > > Unit tests pass, except `ServicePropertiesTest`, which fails due to > [AMBARI-20443](https://issues.apache.org/jira/browse/AMBARI-20443). > > ``` > $ mvn -am -pl ambari-server clean test > ... > Tests in error: > ServicePropertiesTest.validatePropertySchemaOfServiceXMLs:49 » Ambari File > /Us... > > Tests run: 4971, Failures: 0, Errors: 1, Skipped: 39 > ``` > > > Thanks, > > Attila Doroszlai > >
Re: Review Request 59043: AMBARI-20951. Integrate HostService resource with swagger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59043/#review174146 --- Ship it! Ship It! - Sebastian Toader On May 8, 2017, 9 a.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59043/ > --- > > (Updated May 8, 2017, 9 a.m.) > > > Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Jayush Luniya, > Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-20951 > https://issues.apache.org/jira/browse/AMBARI-20951 > > > Repository: ambari > > > Description > --- > > * documented `HostService`, `HostRequest`, `HostResponse` > * removed unused attributes > * introduced constants for common Swagger parameters > * subresources are not covered yet > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java > 0185d37f1a9127c2bd414229b8ab7885e849fbf4 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java > c26c5d85d4c90a1aee81cb5aafbcac49d185c5e2 > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/HostEventCreator.java > d05fe9dce86eaa712807c50744c1fb93000fbe56 > > ambari-server/src/main/java/org/apache/ambari/server/controller/HostRequest.java > a6168394bf4be45497924e73c84aae393d1c53fe > > ambari-server/src/main/java/org/apache/ambari/server/controller/HostResponse.java > 8032801dd7014b9532b5358c8fc44e5250b90c66 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java > 40fe3697e98acff0a36dd24f3e51193683b5af93 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java > f604a7f8be9b2dad7810e46444ae79ead73f8a98 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStatusHelper.java > 96457ed6302f98f6b402eb27f49cffc41bfe4585 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProvider.java > c2fb844ff7e81d8291ae27359dac864aadf50430 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java > b5d2f9de8a297b68ee569b92bc475e39b39986d2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java > c747a33a7d352d8614a573a6b9f3f7149ac5df7c > > ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java > db228b194e240a0c895072362ae68d1973742cef > > ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java > 6d12402e9da92985176c8724f6b705304bba03e3 > > ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java > 168d13b44777b1891e72287de035e99d1064ab72 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/HostServiceTest.java > 6aef04dda19693cd2408dcfce9be5ca8751550e4 > > ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/HostEventCreatorTest.java > 2d1cefcfdcb3604d54338c4c0b314c5fbb740b50 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 554e0891020d90593aeee76cbeddf65f5b66e2b0 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java > c7613231b13c8402cffe29f90fac2449e0f0a395 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java > ac6ac1d299947a3b4ba0f0f41f7a6f851b2a72db > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProviderTest.java > f15c9f2baa20fb69b855d24badb144e354b83891 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ScaleClusterRequestTest.java > 48d1351dc527488cea06168d2fe0fcc90d9a6eb7 > > ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java > 2d5978b1788572c716ddfaae2e56b9502097e98f > > > Diff: https://reviews.apache.org/r/59043/diff/1/ > > > Testing > --- > > Unit tests pass, except `ServicePropertiesTest`, which fails due to > [AMBARI-20443](https://issues.apache.org/jira/browse/AMBARI-20443). > > ``` > $ mvn -am -pl ambari-server clean test > ... > Tests in error: > ServicePropertiesTest.validatePropertySchemaOfServiceXMLs:49 » Ambari File > /Us... > > Tests run: 4971, Failures: 0, Errors: 1, Skipped: 39 > ``` > > > Thanks, > > Attila Doroszlai > >
Review Request 59043: AMBARI-20951. Integrate HostService resource with swagger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59043/ --- Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Jayush Luniya, Sumit Mohanty, and Sebastian Toader. Bugs: AMBARI-20951 https://issues.apache.org/jira/browse/AMBARI-20951 Repository: ambari Description --- * documented `HostService`, `HostRequest`, `HostResponse` * removed unused attributes * introduced constants for common Swagger parameters * subresources are not covered yet Diffs - ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java 0185d37f1a9127c2bd414229b8ab7885e849fbf4 ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c26c5d85d4c90a1aee81cb5aafbcac49d185c5e2 ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/HostEventCreator.java d05fe9dce86eaa712807c50744c1fb93000fbe56 ambari-server/src/main/java/org/apache/ambari/server/controller/HostRequest.java a6168394bf4be45497924e73c84aae393d1c53fe ambari-server/src/main/java/org/apache/ambari/server/controller/HostResponse.java 8032801dd7014b9532b5358c8fc44e5250b90c66 ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java 40fe3697e98acff0a36dd24f3e51193683b5af93 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java f604a7f8be9b2dad7810e46444ae79ead73f8a98 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStatusHelper.java 96457ed6302f98f6b402eb27f49cffc41bfe4585 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProvider.java c2fb844ff7e81d8291ae27359dac864aadf50430 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java b5d2f9de8a297b68ee569b92bc475e39b39986d2 ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java c747a33a7d352d8614a573a6b9f3f7149ac5df7c ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java db228b194e240a0c895072362ae68d1973742cef ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java 6d12402e9da92985176c8724f6b705304bba03e3 ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java 168d13b44777b1891e72287de035e99d1064ab72 ambari-server/src/test/java/org/apache/ambari/server/api/services/HostServiceTest.java 6aef04dda19693cd2408dcfce9be5ca8751550e4 ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/HostEventCreatorTest.java 2d1cefcfdcb3604d54338c4c0b314c5fbb740b50 ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e0891020d90593aeee76cbeddf65f5b66e2b0 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java c7613231b13c8402cffe29f90fac2449e0f0a395 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java ac6ac1d299947a3b4ba0f0f41f7a6f851b2a72db ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProviderTest.java f15c9f2baa20fb69b855d24badb144e354b83891 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ScaleClusterRequestTest.java 48d1351dc527488cea06168d2fe0fcc90d9a6eb7 ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java 2d5978b1788572c716ddfaae2e56b9502097e98f Diff: https://reviews.apache.org/r/59043/diff/1/ Testing --- Unit tests pass, except `ServicePropertiesTest`, which fails due to [AMBARI-20443](https://issues.apache.org/jira/browse/AMBARI-20443). ``` $ mvn -am -pl ambari-server clean test ... Tests in error: ServicePropertiesTest.validatePropertySchemaOfServiceXMLs:49 » Ambari File /Us... Tests run: 4971, Failures: 0, Errors: 1, Skipped: 39 ``` Thanks, Attila Doroszlai
