Re: Review Request 59364: AMBARI-21053 Reverting Beacon stack advisor recommendation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59364/#review175655 --- Ship it! Ship It! - Alejandro Fernandez On May 18, 2017, 3:03 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59364/ > --- > > (Updated May 18, 2017, 3:03 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, > Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-21053 > https://issues.apache.org/jira/browse/AMBARI-21053 > > > Repository: ambari > > > Description > --- > > Beacon is an add-on-service installed via management pack. For services > installed via mpack need to use service advisor recommendation, which should > be provided in mpack. > > Because of the stack_advisor code available, service_advisor.py code logic > from mpack is not getting executed. > > > Diffs > - > > ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py > 488562b > > > Diff: https://reviews.apache.org/r/59364/diff/1/ > > > Testing > --- > > Ran 273 tests in 7.202s > > OK > -- > Total run:1171 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 59364: AMBARI-21053 Reverting Beacon stack advisor recommendation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59364/#review175516 --- Ship it! Ship It! - Jayush Luniya On May 18, 2017, 3:03 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59364/ > --- > > (Updated May 18, 2017, 3:03 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, > Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-21053 > https://issues.apache.org/jira/browse/AMBARI-21053 > > > Repository: ambari > > > Description > --- > > Beacon is an add-on-service installed via management pack. For services > installed via mpack need to use service advisor recommendation, which should > be provided in mpack. > > Because of the stack_advisor code available, service_advisor.py code logic > from mpack is not getting executed. > > > Diffs > - > > ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py > 488562b > > > Diff: https://reviews.apache.org/r/59364/diff/1/ > > > Testing > --- > > Ran 273 tests in 7.202s > > OK > -- > Total run:1171 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 59364: AMBARI-21053 Reverting Beacon stack advisor recommendation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59364/ --- (Updated May 18, 2017, 3:03 p.m.) Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, Xi Wang, and Yusaku Sako. Changes --- Updating correct jira ID Summary (updated) - AMBARI-21053 Reverting Beacon stack advisor recommendation Bugs: AMBARI-21053 https://issues.apache.org/jira/browse/AMBARI-21053 Repository: ambari Description --- Beacon is an add-on-service installed via management pack. For services installed via mpack need to use service advisor recommendation, which should be provided in mpack. Because of the stack_advisor code available, service_advisor.py code logic from mpack is not getting executed. Diffs - ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 488562b Diff: https://reviews.apache.org/r/59364/diff/1/ Testing --- Ran 273 tests in 7.202s OK -- Total run:1171 Total errors:0 Total failures:0 OK Thanks, Mugdha Varadkar
