Re: Review Request 59718: mpack install fails when using https links

2017-06-01 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59718/#review176624
---


Ship it!




Address review comment and commit

- Jayush Luniya


On June 1, 2017, 3:03 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59718/
> ---
> 
> (Updated June 1, 2017, 3:03 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Jayush Luniya.
> 
> 
> Bugs: AMBARI-21167
> https://issues.apache.org/jira/browse/AMBARI-21167
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We have https enabled on our public repo's. For customers that want to use 
> https links mpack install fails
> 
> {code}
> [root@arpit-1 ~]# ambari-server install-mpack \
> > --mpack=https://public-repo-1.hortonworks.com/HDF/centos6/2.x/updates/2.1.3.0/tars/hdf_ambari_mp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
> >  \
> > --purge \
> > --verbose
> Using python  /usr/bin/python
> Installing management pack
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: Installing management pack 
> https://public-repo-1.hortonworks.com/HDF/centos6/2.x/updates/2.1.3.0/tars/hdf_ambari_mp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: Download management pack to temp location 
> /var/lib/ambari-server/data/tmp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
> INFO: Downloading 
> https://public-repo-1.hortonworks.com/HDF/centos6/2.x/updates/2.1.3.0/tars/hdf_ambari_mp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
>  to /var/lib/ambari-server/data/tmp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
> Traceback (most recent call last):
>   File "/usr/sbin/ambari-server.py", line 941, in 
> mainBody()
>   File "/usr/sbin/ambari-server.py", line 911, in mainBody
> main(options, args, parser)
>   File "/usr/sbin/ambari-server.py", line 863, in main
> action_obj.execute()
>   File "/usr/sbin/ambari-server.py", line 78, in execute
> self.fn(*self.args, **self.kwargs)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 896, in install_mpack
> (mpack_metadata, mpack_name, mpack_version, mpack_staging_dir, 
> mpack_archive_path) = _install_mpack(options, replay_mode)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 691, in _install_mpack
> tmp_archive_path = download_mpack(mpack_path)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 140, in download_mpack
> download_file(mpack_path, tmp_archive_path)
>   File "/usr/lib/python2.6/site-packages/ambari_commons/inet_utils.py", line 
> 58, in download_file
> force_download_file(link, destination, chunk_size, progress_func = 
> progress_func)
>   File "/usr/lib/python2.6/site-packages/ambari_commons/inet_utils.py", line 
> 126, in force_download_file
> response = urllib2.urlopen(request)
>   File "/usr/lib64/python2.6/urllib2.py", line 126, in urlopen
> return _opener.open(url, data, timeout)
>   File "/usr/lib64/python2.6/urllib2.py", line 391, in open
> response = self._open(req, data)
>   File "/usr/lib64/python2.6/urllib2.py", line 409, in _open
> '_open', req)
>   File "/usr/lib64/python2.6/urllib2.py", line 369, in _call_chain
> result = func(*args)
>   File "/usr/lib64/python2.6/urllib2.py", line 1198, in https_open
> return self.do_open(httplib.HTTPSConnection, req)
>   File "/usr/lib64/python2.6/urllib2.py", line 1165, in do_open
> raise URLError(err)
> urllib2.URLError:  routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure>
> [root@arpit-1 ~]#
> {code}
> 
> 
> {code}
> [root@arpit-1 ~]# rpm -qa | grep ambari
> ambari-server-2.5.1.0-146.x86_64
> [root@arpit-1 ~]#
> {code}
> 
> Marked it for 2.5.1 will let ambari team make call on if this can make it in 
> or not.
> 
> 
> Diffs
> -
> 
>   ambari-common/src/main/python/ambari_commons/inet_utils.py 66f6544 
>   ambari-server/src/main/python/ambari_server/setupMpacks.py 917dd9c 
> 
> 
> Diff: https://reviews.apache.org/r/59718/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 59718: mpack install fails when using https links

2017-06-01 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59718/#review176623
---




ambari-common/src/main/python/ambari_commons/inet_utils.py
Lines 81 (patched)


Looks like this is accidentally commented out


- Jayush Luniya


On June 1, 2017, 3:03 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59718/
> ---
> 
> (Updated June 1, 2017, 3:03 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Jayush Luniya.
> 
> 
> Bugs: AMBARI-21167
> https://issues.apache.org/jira/browse/AMBARI-21167
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We have https enabled on our public repo's. For customers that want to use 
> https links mpack install fails
> 
> {code}
> [root@arpit-1 ~]# ambari-server install-mpack \
> > --mpack=https://public-repo-1.hortonworks.com/HDF/centos6/2.x/updates/2.1.3.0/tars/hdf_ambari_mp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
> >  \
> > --purge \
> > --verbose
> Using python  /usr/bin/python
> Installing management pack
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: Installing management pack 
> https://public-repo-1.hortonworks.com/HDF/centos6/2.x/updates/2.1.3.0/tars/hdf_ambari_mp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: Download management pack to temp location 
> /var/lib/ambari-server/data/tmp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
> INFO: Downloading 
> https://public-repo-1.hortonworks.com/HDF/centos6/2.x/updates/2.1.3.0/tars/hdf_ambari_mp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
>  to /var/lib/ambari-server/data/tmp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
> Traceback (most recent call last):
>   File "/usr/sbin/ambari-server.py", line 941, in 
> mainBody()
>   File "/usr/sbin/ambari-server.py", line 911, in mainBody
> main(options, args, parser)
>   File "/usr/sbin/ambari-server.py", line 863, in main
> action_obj.execute()
>   File "/usr/sbin/ambari-server.py", line 78, in execute
> self.fn(*self.args, **self.kwargs)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 896, in install_mpack
> (mpack_metadata, mpack_name, mpack_version, mpack_staging_dir, 
> mpack_archive_path) = _install_mpack(options, replay_mode)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 691, in _install_mpack
> tmp_archive_path = download_mpack(mpack_path)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 140, in download_mpack
> download_file(mpack_path, tmp_archive_path)
>   File "/usr/lib/python2.6/site-packages/ambari_commons/inet_utils.py", line 
> 58, in download_file
> force_download_file(link, destination, chunk_size, progress_func = 
> progress_func)
>   File "/usr/lib/python2.6/site-packages/ambari_commons/inet_utils.py", line 
> 126, in force_download_file
> response = urllib2.urlopen(request)
>   File "/usr/lib64/python2.6/urllib2.py", line 126, in urlopen
> return _opener.open(url, data, timeout)
>   File "/usr/lib64/python2.6/urllib2.py", line 391, in open
> response = self._open(req, data)
>   File "/usr/lib64/python2.6/urllib2.py", line 409, in _open
> '_open', req)
>   File "/usr/lib64/python2.6/urllib2.py", line 369, in _call_chain
> result = func(*args)
>   File "/usr/lib64/python2.6/urllib2.py", line 1198, in https_open
> return self.do_open(httplib.HTTPSConnection, req)
>   File "/usr/lib64/python2.6/urllib2.py", line 1165, in do_open
> raise URLError(err)
> urllib2.URLError:  routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure>
> [root@arpit-1 ~]#
> {code}
> 
> 
> {code}
> [root@arpit-1 ~]# rpm -qa | grep ambari
> ambari-server-2.5.1.0-146.x86_64
> [root@arpit-1 ~]#
> {code}
> 
> Marked it for 2.5.1 will let ambari team make call on if this can make it in 
> or not.
> 
> 
> Diffs
> -
> 
>   ambari-common/src/main/python/ambari_commons/inet_utils.py 66f6544 
>   ambari-server/src/main/python/ambari_server/setupMpacks.py 917dd9c 
> 
> 
> Diff: https://reviews.apache.org/r/59718/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 59718: mpack install fails when using https links

2017-06-01 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59718/
---

(Updated Червень 1, 2017, 3:03 після полудня)


Review request for Ambari, Andrew Onischuk and Jayush Luniya.


Bugs: AMBARI-21167
https://issues.apache.org/jira/browse/AMBARI-21167


Repository: ambari


Description
---

We have https enabled on our public repo's. For customers that want to use 
https links mpack install fails

{code}
[root@arpit-1 ~]# ambari-server install-mpack \
> --mpack=https://public-repo-1.hortonworks.com/HDF/centos6/2.x/updates/2.1.3.0/tars/hdf_ambari_mp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
>  \
> --purge \
> --verbose
Using python  /usr/bin/python
Installing management pack
INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
INFO: Installing management pack 
https://public-repo-1.hortonworks.com/HDF/centos6/2.x/updates/2.1.3.0/tars/hdf_ambari_mp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
INFO: Download management pack to temp location 
/var/lib/ambari-server/data/tmp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
INFO: Downloading 
https://public-repo-1.hortonworks.com/HDF/centos6/2.x/updates/2.1.3.0/tars/hdf_ambari_mp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
 to /var/lib/ambari-server/data/tmp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
Traceback (most recent call last):
  File "/usr/sbin/ambari-server.py", line 941, in 
mainBody()
  File "/usr/sbin/ambari-server.py", line 911, in mainBody
main(options, args, parser)
  File "/usr/sbin/ambari-server.py", line 863, in main
action_obj.execute()
  File "/usr/sbin/ambari-server.py", line 78, in execute
self.fn(*self.args, **self.kwargs)
  File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
896, in install_mpack
(mpack_metadata, mpack_name, mpack_version, mpack_staging_dir, 
mpack_archive_path) = _install_mpack(options, replay_mode)
  File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
691, in _install_mpack
tmp_archive_path = download_mpack(mpack_path)
  File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
140, in download_mpack
download_file(mpack_path, tmp_archive_path)
  File "/usr/lib/python2.6/site-packages/ambari_commons/inet_utils.py", line 
58, in download_file
force_download_file(link, destination, chunk_size, progress_func = 
progress_func)
  File "/usr/lib/python2.6/site-packages/ambari_commons/inet_utils.py", line 
126, in force_download_file
response = urllib2.urlopen(request)
  File "/usr/lib64/python2.6/urllib2.py", line 126, in urlopen
return _opener.open(url, data, timeout)
  File "/usr/lib64/python2.6/urllib2.py", line 391, in open
response = self._open(req, data)
  File "/usr/lib64/python2.6/urllib2.py", line 409, in _open
'_open', req)
  File "/usr/lib64/python2.6/urllib2.py", line 369, in _call_chain
result = func(*args)
  File "/usr/lib64/python2.6/urllib2.py", line 1198, in https_open
return self.do_open(httplib.HTTPSConnection, req)
  File "/usr/lib64/python2.6/urllib2.py", line 1165, in do_open
raise URLError(err)
urllib2.URLError: 
[root@arpit-1 ~]#
{code}


{code}
[root@arpit-1 ~]# rpm -qa | grep ambari
ambari-server-2.5.1.0-146.x86_64
[root@arpit-1 ~]#
{code}

Marked it for 2.5.1 will let ambari team make call on if this can make it in or 
not.


Diffs (updated)
-

  ambari-common/src/main/python/ambari_commons/inet_utils.py 66f6544 
  ambari-server/src/main/python/ambari_server/setupMpacks.py 917dd9c 


Diff: https://reviews.apache.org/r/59718/diff/2/

Changes: https://reviews.apache.org/r/59718/diff/1-2/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 59718: mpack install fails when using https links

2017-06-01 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59718/#review176613
---


Ship it!




Ship It!

- Jayush Luniya


On June 1, 2017, 1:46 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59718/
> ---
> 
> (Updated June 1, 2017, 1:46 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Jayush Luniya.
> 
> 
> Bugs: AMBARI-21167
> https://issues.apache.org/jira/browse/AMBARI-21167
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We have https enabled on our public repo's. For customers that want to use 
> https links mpack install fails
> 
> {code}
> [root@arpit-1 ~]# ambari-server install-mpack \
> > --mpack=https://public-repo-1.hortonworks.com/HDF/centos6/2.x/updates/2.1.3.0/tars/hdf_ambari_mp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
> >  \
> > --purge \
> > --verbose
> Using python  /usr/bin/python
> Installing management pack
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: Installing management pack 
> https://public-repo-1.hortonworks.com/HDF/centos6/2.x/updates/2.1.3.0/tars/hdf_ambari_mp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: Download management pack to temp location 
> /var/lib/ambari-server/data/tmp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
> INFO: Downloading 
> https://public-repo-1.hortonworks.com/HDF/centos6/2.x/updates/2.1.3.0/tars/hdf_ambari_mp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
>  to /var/lib/ambari-server/data/tmp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
> Traceback (most recent call last):
>   File "/usr/sbin/ambari-server.py", line 941, in 
> mainBody()
>   File "/usr/sbin/ambari-server.py", line 911, in mainBody
> main(options, args, parser)
>   File "/usr/sbin/ambari-server.py", line 863, in main
> action_obj.execute()
>   File "/usr/sbin/ambari-server.py", line 78, in execute
> self.fn(*self.args, **self.kwargs)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 896, in install_mpack
> (mpack_metadata, mpack_name, mpack_version, mpack_staging_dir, 
> mpack_archive_path) = _install_mpack(options, replay_mode)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 691, in _install_mpack
> tmp_archive_path = download_mpack(mpack_path)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 140, in download_mpack
> download_file(mpack_path, tmp_archive_path)
>   File "/usr/lib/python2.6/site-packages/ambari_commons/inet_utils.py", line 
> 58, in download_file
> force_download_file(link, destination, chunk_size, progress_func = 
> progress_func)
>   File "/usr/lib/python2.6/site-packages/ambari_commons/inet_utils.py", line 
> 126, in force_download_file
> response = urllib2.urlopen(request)
>   File "/usr/lib64/python2.6/urllib2.py", line 126, in urlopen
> return _opener.open(url, data, timeout)
>   File "/usr/lib64/python2.6/urllib2.py", line 391, in open
> response = self._open(req, data)
>   File "/usr/lib64/python2.6/urllib2.py", line 409, in _open
> '_open', req)
>   File "/usr/lib64/python2.6/urllib2.py", line 369, in _call_chain
> result = func(*args)
>   File "/usr/lib64/python2.6/urllib2.py", line 1198, in https_open
> return self.do_open(httplib.HTTPSConnection, req)
>   File "/usr/lib64/python2.6/urllib2.py", line 1165, in do_open
> raise URLError(err)
> urllib2.URLError:  routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure>
> [root@arpit-1 ~]#
> {code}
> 
> 
> {code}
> [root@arpit-1 ~]# rpm -qa | grep ambari
> ambari-server-2.5.1.0-146.x86_64
> [root@arpit-1 ~]#
> {code}
> 
> Marked it for 2.5.1 will let ambari team make call on if this can make it in 
> or not.
> 
> 
> Diffs
> -
> 
>   ambari-common/src/main/python/ambari_commons/inet_utils.py 66f6544 
>   ambari-server/src/main/python/ambari_server/setupMpacks.py 917dd9c 
> 
> 
> Diff: https://reviews.apache.org/r/59718/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Review Request 59718: mpack install fails when using https links

2017-06-01 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59718/
---

Review request for Ambari, Andrew Onischuk and Jayush Luniya.


Bugs: AMBARI-21167
https://issues.apache.org/jira/browse/AMBARI-21167


Repository: ambari


Description
---

We have https enabled on our public repo's. For customers that want to use 
https links mpack install fails

{code}
[root@arpit-1 ~]# ambari-server install-mpack \
> --mpack=https://public-repo-1.hortonworks.com/HDF/centos6/2.x/updates/2.1.3.0/tars/hdf_ambari_mp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
>  \
> --purge \
> --verbose
Using python  /usr/bin/python
Installing management pack
INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
INFO: Installing management pack 
https://public-repo-1.hortonworks.com/HDF/centos6/2.x/updates/2.1.3.0/tars/hdf_ambari_mp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
INFO: Download management pack to temp location 
/var/lib/ambari-server/data/tmp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
INFO: Downloading 
https://public-repo-1.hortonworks.com/HDF/centos6/2.x/updates/2.1.3.0/tars/hdf_ambari_mp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
 to /var/lib/ambari-server/data/tmp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
Traceback (most recent call last):
  File "/usr/sbin/ambari-server.py", line 941, in 
mainBody()
  File "/usr/sbin/ambari-server.py", line 911, in mainBody
main(options, args, parser)
  File "/usr/sbin/ambari-server.py", line 863, in main
action_obj.execute()
  File "/usr/sbin/ambari-server.py", line 78, in execute
self.fn(*self.args, **self.kwargs)
  File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
896, in install_mpack
(mpack_metadata, mpack_name, mpack_version, mpack_staging_dir, 
mpack_archive_path) = _install_mpack(options, replay_mode)
  File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
691, in _install_mpack
tmp_archive_path = download_mpack(mpack_path)
  File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
140, in download_mpack
download_file(mpack_path, tmp_archive_path)
  File "/usr/lib/python2.6/site-packages/ambari_commons/inet_utils.py", line 
58, in download_file
force_download_file(link, destination, chunk_size, progress_func = 
progress_func)
  File "/usr/lib/python2.6/site-packages/ambari_commons/inet_utils.py", line 
126, in force_download_file
response = urllib2.urlopen(request)
  File "/usr/lib64/python2.6/urllib2.py", line 126, in urlopen
return _opener.open(url, data, timeout)
  File "/usr/lib64/python2.6/urllib2.py", line 391, in open
response = self._open(req, data)
  File "/usr/lib64/python2.6/urllib2.py", line 409, in _open
'_open', req)
  File "/usr/lib64/python2.6/urllib2.py", line 369, in _call_chain
result = func(*args)
  File "/usr/lib64/python2.6/urllib2.py", line 1198, in https_open
return self.do_open(httplib.HTTPSConnection, req)
  File "/usr/lib64/python2.6/urllib2.py", line 1165, in do_open
raise URLError(err)
urllib2.URLError: 
[root@arpit-1 ~]#
{code}


{code}
[root@arpit-1 ~]# rpm -qa | grep ambari
ambari-server-2.5.1.0-146.x86_64
[root@arpit-1 ~]#
{code}

Marked it for 2.5.1 will let ambari team make call on if this can make it in or 
not.


Diffs
-

  ambari-common/src/main/python/ambari_commons/inet_utils.py 66f6544 
  ambari-server/src/main/python/ambari_server/setupMpacks.py 917dd9c 


Diff: https://reviews.apache.org/r/59718/diff/1/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi