Re: Review Request 59870: Part Two: Specify the script directly in alert target for script-based alert dispatchers
> On 六月 8, 2017, 12:23 a.m., Richard Zang wrote: > > Ship It! Thank for your review. - yao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59870/#review177262 --- On 六月 7, 2017, 4:34 a.m., yao lei wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59870/ > --- > > (Updated 六月 7, 2017, 4:34 a.m.) > > > Review request for Ambari, Alexandr Antonenko, Richard Zang, and Yusaku Sako. > > > Bugs: AMBARI-21123 > https://issues.apache.org/jira/browse/AMBARI-21123 > > > Repository: ambari > > > Description > --- > > Web Codes Part > This patch amis to support creating alert target that inclueds property > ambari.dispatch-property.script.filename on web UI > > More details, please see https://issues.apache.org/jira/browse/AMBARI-20739 > > > Diffs > - > > > ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js > df15513 > ambari-web/app/messages.js 02a54f7 > ambari-web/app/templates/main/alerts/create_alert_notification.hbs 7ec5b1e > ambari-web/app/utils/validator.js c069724 > > ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js > 0d58afa > > > Diff: https://reviews.apache.org/r/59870/diff/1/ > > > Testing > --- > > 1.cd ambari-web & mvn test > 21211 passing (33s) > 128 pending > > 2.Tested in a cluster > > > File Attachments > > > script_alert_notification_1.png > > https://reviews.apache.org/media/uploaded/files/2017/06/07/c77c5e4c-4d64-400a-8df9-11df1369e7fd__script_alert_notification_1.png > script_alert_notification_2.png > > https://reviews.apache.org/media/uploaded/files/2017/06/07/1c230f27-4158-4ef4-90a8-483b3cfd4d52__script_alert_notification_2.png > > > Thanks, > > yao lei > >
Re: Review Request 59870: Part Two: Specify the script directly in alert target for script-based alert dispatchers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59870/#review177262 --- Ship it! Ship It! - Richard Zang On June 7, 2017, 4:34 a.m., yao lei wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59870/ > --- > > (Updated June 7, 2017, 4:34 a.m.) > > > Review request for Ambari, Alexandr Antonenko, Richard Zang, and Yusaku Sako. > > > Bugs: AMBARI-21123 > https://issues.apache.org/jira/browse/AMBARI-21123 > > > Repository: ambari > > > Description > --- > > Web Codes Part > This patch amis to support creating alert target that inclueds property > ambari.dispatch-property.script.filename on web UI > > More details, please see https://issues.apache.org/jira/browse/AMBARI-20739 > > > Diffs > - > > > ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js > df15513 > ambari-web/app/messages.js 02a54f7 > ambari-web/app/templates/main/alerts/create_alert_notification.hbs 7ec5b1e > ambari-web/app/utils/validator.js c069724 > > ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js > 0d58afa > > > Diff: https://reviews.apache.org/r/59870/diff/1/ > > > Testing > --- > > 1.cd ambari-web & mvn test > 21211 passing (33s) > 128 pending > > 2.Tested in a cluster > > > File Attachments > > > script_alert_notification_1.png > > https://reviews.apache.org/media/uploaded/files/2017/06/07/c77c5e4c-4d64-400a-8df9-11df1369e7fd__script_alert_notification_1.png > script_alert_notification_2.png > > https://reviews.apache.org/media/uploaded/files/2017/06/07/1c230f27-4158-4ef4-90a8-483b3cfd4d52__script_alert_notification_2.png > > > Thanks, > > yao lei > >
Review Request 59870: Part Two: Specify the script directly in alert target for script-based alert dispatchers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59870/ --- Review request for Ambari, Alexandr Antonenko, Richard Zang, and Yusaku Sako. Bugs: AMBARI-21123 https://issues.apache.org/jira/browse/AMBARI-21123 Repository: ambari Description --- Web Codes Part This patch amis to support creating alert target that inclueds property ambari.dispatch-property.script.filename on web UI More details, please see https://issues.apache.org/jira/browse/AMBARI-20739 Diffs (updated) - ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js df15513 ambari-web/app/messages.js 02a54f7 ambari-web/app/templates/main/alerts/create_alert_notification.hbs 7ec5b1e ambari-web/app/utils/validator.js c069724 ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js 0d58afa Diff: https://reviews.apache.org/r/59870/diff/1/ Testing --- 1.cd ambari-web & mvn test 21211 passing (33s) 128 pending 2.Tested in a cluster File Attachments script_alert_notification_1.png https://reviews.apache.org/media/uploaded/files/2017/06/07/c77c5e4c-4d64-400a-8df9-11df1369e7fd__script_alert_notification_1.png script_alert_notification_2.png https://reviews.apache.org/media/uploaded/files/2017/06/07/1c230f27-4158-4ef4-90a8-483b3cfd4d52__script_alert_notification_2.png Thanks, yao lei
