Re: Review Request 59929: Extend Swagger Maven pluging to handle nested API's

[Balázs Bence Sári]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59929/
---

(Updated June 14, 2017, 12:21 p.m.)


Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit 
Mohanty, and Sebastian Toader.


Changes
---

Fix review comment


Bugs: AMBARI-21207
https://issues.apache.org/jira/browse/AMBARI-21207


Repository: ambari


Description
---

Wrote a custom SwaggerReader in the utility project that handles nested API's. 
There is currently one nested API which is annotated for swagger: 
org.apache.ambari.server.api.services.ServiceService (nested under 
ClusterService). Using the custom reader operation paths and parameters are 
generated correctly for the nested API.


Diffs (updated)
-

  ambari-project/pom.xml 9bb2e26 
  ambari-server/pom.xml a1cd239 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
 f61fb2a 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
 a28c4aa 
  utility/pom.xml 918080e 
  utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java 
PRE-CREATION 
  utility/src/test/java/org/apache/ambari/swagger/AmbariSwaggerReaderTest.java 
PRE-CREATION 
  utility/src/test/resources/log4j.properties PRE-CREATION 


Diff: https://reviews.apache.org/r/59929/diff/5/

Changes: https://reviews.apache.org/r/59929/diff/4-5/


Testing
---

Tested Swagger API generation manually. Wrote new unit tests. Run all unit 
tests for the ambari-server and utility projects, no errors or failures.


Thanks,

Balázs Bence Sári

Re: Review Request 59929: Extend Swagger Maven pluging to handle nested API's

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59929/#review177876
---


Fix it, then Ship it!





ambari-project/pom.xml
Lines 36 (patched)


Should be 1.7.20


- Attila Doroszlai


On June 14, 2017, 12:38 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59929/
> ---
> 
> (Updated June 14, 2017, 12:38 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21207
> https://issues.apache.org/jira/browse/AMBARI-21207
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Wrote a custom SwaggerReader in the utility project that handles nested 
> API's. There is currently one nested API which is annotated for swagger: 
> org.apache.ambari.server.api.services.ServiceService (nested under 
> ClusterService). Using the custom reader operation paths and parameters are 
> generated correctly for the nested API.
> 
> 
> Diffs
> -
> 
>   ambari-project/pom.xml 9bb2e26 
>   ambari-server/pom.xml a1cd239 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
>  f61fb2a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
>  a28c4aa 
>   utility/pom.xml 918080e 
>   utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java 
> PRE-CREATION 
>   
> utility/src/test/java/org/apache/ambari/swagger/AmbariSwaggerReaderTest.java 
> PRE-CREATION 
>   utility/src/test/resources/log4j.properties PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59929/diff/4/
> 
> 
> Testing
> ---
> 
> Tested Swagger API generation manually. Wrote new unit tests. Run all unit 
> tests for the ambari-server and utility projects, no errors or failures.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 59929: Extend Swagger Maven pluging to handle nested API's

[Balázs Bence Sári]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59929/
---

(Updated June 14, 2017, 10:38 a.m.)


Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit 
Mohanty, and Sebastian Toader.


Changes
---

Rebased patch


Bugs: AMBARI-21207
https://issues.apache.org/jira/browse/AMBARI-21207


Repository: ambari


Description
---

Wrote a custom SwaggerReader in the utility project that handles nested API's. 
There is currently one nested API which is annotated for swagger: 
org.apache.ambari.server.api.services.ServiceService (nested under 
ClusterService). Using the custom reader operation paths and parameters are 
generated correctly for the nested API.


Diffs (updated)
-

  ambari-project/pom.xml 9bb2e26 
  ambari-server/pom.xml a1cd239 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
 f61fb2a 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
 a28c4aa 
  utility/pom.xml 918080e 
  utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java 
PRE-CREATION 
  utility/src/test/java/org/apache/ambari/swagger/AmbariSwaggerReaderTest.java 
PRE-CREATION 
  utility/src/test/resources/log4j.properties PRE-CREATION 


Diff: https://reviews.apache.org/r/59929/diff/4/

Changes: https://reviews.apache.org/r/59929/diff/3-4/


Testing
---

Tested Swagger API generation manually. Wrote new unit tests. Run all unit 
tests for the ambari-server and utility projects, no errors or failures.


Thanks,

Balázs Bence Sári

Re: Review Request 59929: Extend Swagger Maven pluging to handle nested API's

[Balázs Bence Sári]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59929/
---

(Updated June 13, 2017, 9:39 p.m.)


Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit 
Mohanty, and Sebastian Toader.


Changes
---

organize dependencies more nicely


Bugs: AMBARI-21207
https://issues.apache.org/jira/browse/AMBARI-21207


Repository: ambari


Description
---

Wrote a custom SwaggerReader in the utility project that handles nested API's. 
There is currently one nested API which is annotated for swagger: 
org.apache.ambari.server.api.services.ServiceService (nested under 
ClusterService). Using the custom reader operation paths and parameters are 
generated correctly for the nested API.


Diffs (updated)
-

  ambari-project/pom.xml 64d1416 
  ambari-server/pom.xml 669f90f 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
 f61fb2a 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
 a28c4aa 
  utility/pom.xml 7d5eb93 
  utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java 
PRE-CREATION 
  utility/src/test/java/org/apache/ambari/swagger/AmbariSwaggerReaderTest.java 
PRE-CREATION 
  utility/src/test/resources/log4j.properties PRE-CREATION 


Diff: https://reviews.apache.org/r/59929/diff/3/

Changes: https://reviews.apache.org/r/59929/diff/2-3/


Testing
---

Tested Swagger API generation manually. Wrote new unit tests. Run all unit 
tests for the ambari-server and utility projects, no errors or failures.


Thanks,

Balázs Bence Sári

Re: Review Request 59929: Extend Swagger Maven pluging to handle nested API's

[Balázs Bence Sári]

> On June 12, 2017, 10:48 a.m., Attila Doroszlai wrote:
> > utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java
> > Lines 56 (patched)
> > 
> >
> > Should be `LOG`, not `logger`

Unfortunately, LOG denotes an existing member variable which is a (less 
sophisticated than slfj) Maven logger. I chose slf4j for logging, but I had to 
chose a different variable name.


> On June 12, 2017, 10:48 a.m., Attila Doroszlai wrote:
> > utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java
> > Lines 80 (patched)
> > 
> >
> > Please avoid + in `debug` message, use placeholders (`{}`) instead.

This is a reainder of switching logger implementations back and forth (slf4j vs 
maven logging). I'll fix it.


- Balázs Bence


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59929/#review177602
---


On June 12, 2017, 10:09 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59929/
> ---
> 
> (Updated June 12, 2017, 10:09 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21207
> https://issues.apache.org/jira/browse/AMBARI-21207
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Wrote a custom SwaggerReader in the utility project that handles nested 
> API's. There is currently one nested API which is annotated for swagger: 
> org.apache.ambari.server.api.services.ServiceService (nested under 
> ClusterService). Using the custom reader operation paths and parameters are 
> generated correctly for the nested API.
> 
> 
> Diffs
> -
> 
>   ambari-project/pom.xml 64d1416 
>   ambari-server/pom.xml 669f90f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
>  f61fb2a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
>  a28c4aa 
>   utility/pom.xml 7d5eb93 
>   utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java 
> PRE-CREATION 
>   
> utility/src/test/java/org/apache/ambari/swagger/AmbariSwaggerReaderTest.java 
> PRE-CREATION 
>   utility/src/test/resources/log4j.properties PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59929/diff/2/
> 
> 
> Testing
> ---
> 
> Tested Swagger API generation manually. Wrote new unit tests. Run all unit 
> tests for the ambari-server and utility projects, no errors or failures.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 59929: Extend Swagger Maven pluging to handle nested API's

[Balázs Bence Sári]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59929/
---

(Updated June 12, 2017, 10:09 p.m.)


Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit 
Mohanty, and Sebastian Toader.


Changes
---

Review comments fixed.


Bugs: AMBARI-21207
https://issues.apache.org/jira/browse/AMBARI-21207


Repository: ambari


Description
---

Wrote a custom SwaggerReader in the utility project that handles nested API's. 
There is currently one nested API which is annotated for swagger: 
org.apache.ambari.server.api.services.ServiceService (nested under 
ClusterService). Using the custom reader operation paths and parameters are 
generated correctly for the nested API.


Diffs (updated)
-

  ambari-project/pom.xml 64d1416 
  ambari-server/pom.xml 669f90f 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
 f61fb2a 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
 a28c4aa 
  utility/pom.xml 7d5eb93 
  utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java 
PRE-CREATION 
  utility/src/test/java/org/apache/ambari/swagger/AmbariSwaggerReaderTest.java 
PRE-CREATION 
  utility/src/test/resources/log4j.properties PRE-CREATION 


Diff: https://reviews.apache.org/r/59929/diff/2/

Changes: https://reviews.apache.org/r/59929/diff/1-2/


Testing
---

Tested Swagger API generation manually. Wrote new unit tests. Run all unit 
tests for the ambari-server and utility projects, no errors or failures.


Thanks,

Balázs Bence Sári

Re: Review Request 59929: Extend Swagger Maven pluging to handle nested API's

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59929/#review177602
---


Fix it, then Ship it!




Nice.


utility/pom.xml
Lines 42 (patched)


Can you please add these dependencies to `dependencyManagement` in 
`ambari-project/pom.xml`, and omit the version numbers in `utility/pom.xml`?



utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java
Lines 56 (patched)


Should be `LOG`, not `logger`



utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java
Lines 62 (patched)


Can be `final`



utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java
Lines 80 (patched)


Please avoid + in `debug` message, use placeholders (`{}`) instead.


- Attila Doroszlai


On June 8, 2017, 11:37 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59929/
> ---
> 
> (Updated June 8, 2017, 11:37 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21207
> https://issues.apache.org/jira/browse/AMBARI-21207
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Wrote a custom SwaggerReader in the utility project that handles nested 
> API's. There is currently one nested API which is annotated for swagger: 
> org.apache.ambari.server.api.services.ServiceService (nested under 
> ClusterService). Using the custom reader operation paths and parameters are 
> generated correctly for the nested API.
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml c0aed7b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
>  f61fb2a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
>  a28c4aa 
>   utility/pom.xml 7d5eb93 
>   utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java 
> PRE-CREATION 
>   
> utility/src/test/java/org/apache/ambari/swagger/AmbariSwaggerReaderTest.java 
> PRE-CREATION 
>   utility/src/test/resources/log4j.properties PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59929/diff/1/
> 
> 
> Testing
> ---
> 
> Tested Swagger API generation manually. Wrote new unit tests. Run all unit 
> tests for the ambari-server and utility projects, no errors or failures.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Review Request 59929: Extend Swagger Maven pluging to handle nested API's

[Balázs Bence Sári]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59929/
---

Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit 
Mohanty, and Sebastian Toader.


Bugs: AMBARI-21207
https://issues.apache.org/jira/browse/AMBARI-21207


Repository: ambari


Description
---

Wrote a custom SwaggerReader in the utility project that handles nested API's. 
There is currently one nested API which is annotated for swagger: 
org.apache.ambari.server.api.services.ServiceService (nested under 
ClusterService). Using the custom reader operation paths and parameters are 
generated correctly for the nested API.


Diffs
-

  ambari-server/pom.xml c0aed7b 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
 f61fb2a 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
 a28c4aa 
  utility/pom.xml 7d5eb93 
  utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java 
PRE-CREATION 
  utility/src/test/java/org/apache/ambari/swagger/AmbariSwaggerReaderTest.java 
PRE-CREATION 
  utility/src/test/resources/log4j.properties PRE-CREATION 


Diff: https://reviews.apache.org/r/59929/diff/1/


Testing
---

Tested Swagger API generation manually. Wrote new unit tests. Run all unit 
tests for the ambari-server and utility projects, no errors or failures.


Thanks,

Balázs Bence Sári