Re: Review Request 60152: Add "zeppelin.server.ssl.port" in Zeppelin's setting

2017-06-21 Thread Pallav Kulshreshtha

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60152/#review178482
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On June 19, 2017, 7:10 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60152/
> ---
> 
> (Updated June 19, 2017, 7:10 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21271
> https://issues.apache.org/jira/browse/AMBARI-21271
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add "zeppelin.server.ssl.port" in Zeppelin's setting. This is in associated 
> with the changes made in https://issues.apache.org/jira/browse/ZEPPELIN-1321.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml
>  85f1859509 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
> 564dead112 
>   ambari-server/src/test/python/stacks/2.6/configs/default.json 2570657b70 
> 
> 
> Diff: https://reviews.apache.org/r/60152/diff/2/
> 
> 
> Testing
> ---
> 
> Manually on CentOS 6.4
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 60152: Add "zeppelin.server.ssl.port" in Zeppelin's setting

2017-06-21 Thread DIPAYAN BHOWMICK

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60152/#review178483
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On June 19, 2017, 7:10 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60152/
> ---
> 
> (Updated June 19, 2017, 7:10 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21271
> https://issues.apache.org/jira/browse/AMBARI-21271
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add "zeppelin.server.ssl.port" in Zeppelin's setting. This is in associated 
> with the changes made in https://issues.apache.org/jira/browse/ZEPPELIN-1321.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml
>  85f1859509 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
> 564dead112 
>   ambari-server/src/test/python/stacks/2.6/configs/default.json 2570657b70 
> 
> 
> Diff: https://reviews.apache.org/r/60152/diff/2/
> 
> 
> Testing
> ---
> 
> Manually on CentOS 6.4
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 60152: Add "zeppelin.server.ssl.port" in Zeppelin's setting

2017-06-19 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60152/#review178309
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 19, 2017, 7:10 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60152/
> ---
> 
> (Updated June 19, 2017, 7:10 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21271
> https://issues.apache.org/jira/browse/AMBARI-21271
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add "zeppelin.server.ssl.port" in Zeppelin's setting. This is in associated 
> with the changes made in https://issues.apache.org/jira/browse/ZEPPELIN-1321.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml
>  85f1859509 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
> 564dead112 
>   ambari-server/src/test/python/stacks/2.6/configs/default.json 2570657b70 
> 
> 
> Diff: https://reviews.apache.org/r/60152/diff/2/
> 
> 
> Testing
> ---
> 
> Manually on CentOS 6.4
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 60152: Add "zeppelin.server.ssl.port" in Zeppelin's setting

2017-06-19 Thread Prabhjyot Singh


> On June 17, 2017, 3:10 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml
> > Lines 40 (patched)
> > 
> >
> > Is this really needed on an Ambari upgrade?
> > What about during stack upgrades.

Yes, this requires Ambari upgrade.
Have made relavent changes for stack upgrade, which only applies when the stack 
is upgraded from 2.5 to 2.6.


- Prabhjyot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60152/#review178128
---


On June 19, 2017, 12:40 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60152/
> ---
> 
> (Updated June 19, 2017, 12:40 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21271
> https://issues.apache.org/jira/browse/AMBARI-21271
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add "zeppelin.server.ssl.port" in Zeppelin's setting. This is in associated 
> with the changes made in https://issues.apache.org/jira/browse/ZEPPELIN-1321.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml
>  85f1859509 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
> 564dead112 
>   ambari-server/src/test/python/stacks/2.6/configs/default.json 2570657b70 
> 
> 
> Diff: https://reviews.apache.org/r/60152/diff/2/
> 
> 
> Testing
> ---
> 
> Manually on CentOS 6.4
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 60152: Add "zeppelin.server.ssl.port" in Zeppelin's setting

2017-06-19 Thread Prabhjyot Singh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60152/
---

(Updated June 19, 2017, 12:40 p.m.)


Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
venkat sairam.


Bugs: AMBARI-21271
https://issues.apache.org/jira/browse/AMBARI-21271


Repository: ambari


Description
---

Add "zeppelin.server.ssl.port" in Zeppelin's setting. This is in associated 
with the changes made in https://issues.apache.org/jira/browse/ZEPPELIN-1321.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml
 85f1859509 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
564dead112 
  ambari-server/src/test/python/stacks/2.6/configs/default.json 2570657b70 


Diff: https://reviews.apache.org/r/60152/diff/2/

Changes: https://reviews.apache.org/r/60152/diff/1-2/


Testing
---

Manually on CentOS 6.4


Thanks,

Prabhjyot Singh



Re: Review Request 60152: Add "zeppelin.server.ssl.port" in Zeppelin's setting

2017-06-16 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60152/#review178128
---




ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml
Lines 40 (patched)


Is this really needed on an Ambari upgrade?
What about during stack upgrades.


- Alejandro Fernandez


On June 16, 2017, 9:28 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60152/
> ---
> 
> (Updated June 16, 2017, 9:28 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21271
> https://issues.apache.org/jira/browse/AMBARI-21271
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add "zeppelin.server.ssl.port" in Zeppelin's setting. This is in associated 
> with the changes made in https://issues.apache.org/jira/browse/ZEPPELIN-1321.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml
>  85f1859509 
>   ambari-server/src/test/python/stacks/2.6/configs/default.json 2570657b70 
> 
> 
> Diff: https://reviews.apache.org/r/60152/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on CentOS 6.4
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 60152: Add "zeppelin.server.ssl.port" in Zeppelin's setting

2017-06-16 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60152/#review178093
---


Ship it!




Ship It!

- venkat sairam


On June 16, 2017, 9:28 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60152/
> ---
> 
> (Updated June 16, 2017, 9:28 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21271
> https://issues.apache.org/jira/browse/AMBARI-21271
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add "zeppelin.server.ssl.port" in Zeppelin's setting. This is in associated 
> with the changes made in https://issues.apache.org/jira/browse/ZEPPELIN-1321.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml
>  85f1859509 
>   ambari-server/src/test/python/stacks/2.6/configs/default.json 2570657b70 
> 
> 
> Diff: https://reviews.apache.org/r/60152/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on CentOS 6.4
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Review Request 60152: Add "zeppelin.server.ssl.port" in Zeppelin's setting

2017-06-16 Thread Prabhjyot Singh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60152/
---

Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
venkat sairam.


Bugs: AMBARI-21271
https://issues.apache.org/jira/browse/AMBARI-21271


Repository: ambari


Description
---

Add "zeppelin.server.ssl.port" in Zeppelin's setting. This is in associated 
with the changes made in https://issues.apache.org/jira/browse/ZEPPELIN-1321.


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml
 85f1859509 
  ambari-server/src/test/python/stacks/2.6/configs/default.json 2570657b70 


Diff: https://reviews.apache.org/r/60152/diff/1/


Testing
---

Manually on CentOS 6.4


Thanks,

Prabhjyot Singh