Re: Review Request 60196: Fail to create solr clients in Log Search / Log Feeder with openjdk8
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60196/#review178895 --- Ship it! Ship It! - Robert Nettleton On June 26, 2017, 1:46 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60196/ > --- > > (Updated June 26, 2017, 1:46 p.m.) > > > Review request for Ambari, Miklos Gergely and Robert Nettleton. > > > Bugs: AMBARI-21277 > https://issues.apache.org/jira/browse/AMBARI-21277 > > > Repository: ambari > > > Description > --- > > Shade org.apache.http package in metrics common, as it causes a runtime error > for logsearch/logfeeder when they are using solr client (it requires at least > 4.4.x http client) > > > Diffs > - > > ambari-metrics/ambari-metrics-common/pom.xml f0d3963 > > > Diff: https://reviews.apache.org/r/60196/diff/5/ > > > Testing > --- > > done. manually checked the applications. > > > Thanks, > > Oliver Szabo > >
Re: Review Request 60196: Fail to create solr clients in Log Search / Log Feeder with openjdk8
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60196/ --- (Updated June 21, 2017, 10:16 a.m.) Review request for Ambari, Miklos Gergely and Robert Nettleton. Changes --- eliminate nullpointer Bugs: AMBARI-21277 https://issues.apache.org/jira/browse/AMBARI-21277 Repository: ambari Description --- remvoe commons-httpclient dependency from logsearch/logfeeder Diffs (updated) - ambari-logsearch/ambari-logsearch-logfeeder/pom.xml ce784cb ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java d37a3bb ambari-logsearch/ambari-logsearch-server/pom.xml 7cd90eb ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java df00c15 ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/SolrCollectionConfigurer.java f2d022e ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/SolrSchemaFieldDao.java d99694b ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/CreateCollectionHandler.java 752a1e1 Diff: https://reviews.apache.org/r/60196/diff/4/ Changes: https://reviews.apache.org/r/60196/diff/3-4/ Testing --- done. manually checked the applications. Thanks, Oliver Szabo
Re: Review Request 60196: Fail to create solr clients in Log Search / Log Feeder with openjdk8
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60196/#review178433 --- Ship it! Ship It! - Miklos Gergely On June 20, 2017, 7:46 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60196/ > --- > > (Updated June 20, 2017, 7:46 p.m.) > > > Review request for Ambari, Miklos Gergely and Robert Nettleton. > > > Bugs: AMBARI-21277 > https://issues.apache.org/jira/browse/AMBARI-21277 > > > Repository: ambari > > > Description > --- > > remvoe commons-httpclient dependency from logsearch/logfeeder > > > Diffs > - > > ambari-logsearch/ambari-logsearch-logfeeder/pom.xml ce784cb > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java > d37a3bb > ambari-logsearch/ambari-logsearch-server/pom.xml 7cd90eb > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java > df00c15 > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/SolrCollectionConfigurer.java > f2d022e > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/SolrSchemaFieldDao.java > d99694b > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/CreateCollectionHandler.java > 752a1e1 > > > Diff: https://reviews.apache.org/r/60196/diff/3/ > > > Testing > --- > > done. manually checked the applications. > > > Thanks, > > Oliver Szabo > >
Re: Review Request 60196: Fail to create solr clients in Log Search / Log Feeder with openjdk8
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60196/#review178422 --- Ship it! Ship It! - Robert Nettleton On June 20, 2017, 7:46 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60196/ > --- > > (Updated June 20, 2017, 7:46 p.m.) > > > Review request for Ambari, Miklos Gergely and Robert Nettleton. > > > Bugs: AMBARI-21277 > https://issues.apache.org/jira/browse/AMBARI-21277 > > > Repository: ambari > > > Description > --- > > remvoe commons-httpclient dependency from logsearch/logfeeder > > > Diffs > - > > ambari-logsearch/ambari-logsearch-logfeeder/pom.xml ce784cb > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java > d37a3bb > ambari-logsearch/ambari-logsearch-server/pom.xml 7cd90eb > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java > df00c15 > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/SolrCollectionConfigurer.java > f2d022e > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/SolrSchemaFieldDao.java > d99694b > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/CreateCollectionHandler.java > 752a1e1 > > > Diff: https://reviews.apache.org/r/60196/diff/3/ > > > Testing > --- > > done. manually checked the applications. > > > Thanks, > > Oliver Szabo > >
Re: Review Request 60196: Fail to create solr clients in Log Search / Log Feeder with openjdk8
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60196/ --- (Updated June 20, 2017, 7:46 p.m.) Review request for Ambari, Miklos Gergely and Robert Nettleton. Changes --- - make sure all httpclient versions are the same - create httpclients manually Bugs: AMBARI-21277 https://issues.apache.org/jira/browse/AMBARI-21277 Repository: ambari Description --- remvoe commons-httpclient dependency from logsearch/logfeeder Diffs (updated) - ambari-logsearch/ambari-logsearch-logfeeder/pom.xml ce784cb ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java d37a3bb ambari-logsearch/ambari-logsearch-server/pom.xml 7cd90eb ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java df00c15 ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/SolrCollectionConfigurer.java f2d022e ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/SolrSchemaFieldDao.java d99694b ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/CreateCollectionHandler.java 752a1e1 Diff: https://reviews.apache.org/r/60196/diff/3/ Changes: https://reviews.apache.org/r/60196/diff/2-3/ Testing --- done. manually checked the applications. Thanks, Oliver Szabo
Re: Review Request 60196: Fail to create solr clients in Log Search / Log Feeder with openjdk8
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60196/#review178245 --- Ship it! Ship It! - Robert Nettleton On June 19, 2017, 11:52 a.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60196/ > --- > > (Updated June 19, 2017, 11:52 a.m.) > > > Review request for Ambari, Miklos Gergely and Robert Nettleton. > > > Bugs: AMBARI-21277 > https://issues.apache.org/jira/browse/AMBARI-21277 > > > Repository: ambari > > > Description > --- > > remvoe commons-httpclient dependency from logsearch/logfeeder > > > Diffs > - > > ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 49122e8 > ambari-logsearch/ambari-logsearch-portal/pom.xml a439266 > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java > df00c15 > > > Diff: https://reviews.apache.org/r/60196/diff/2/ > > > Testing > --- > > done. manually checked the applications. > > > Thanks, > > Oliver Szabo > >
Re: Review Request 60196: Fail to create solr clients in Log Search / Log Feeder with openjdk8
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60196/#review178224 --- Ship it! Ship It! - Miklos Gergely On June 19, 2017, 11:52 a.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60196/ > --- > > (Updated June 19, 2017, 11:52 a.m.) > > > Review request for Ambari, Miklos Gergely and Robert Nettleton. > > > Bugs: AMBARI-21277 > https://issues.apache.org/jira/browse/AMBARI-21277 > > > Repository: ambari > > > Description > --- > > remvoe commons-httpclient dependency from logsearch/logfeeder > > > Diffs > - > > ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 49122e8 > ambari-logsearch/ambari-logsearch-portal/pom.xml a439266 > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java > df00c15 > > > Diff: https://reviews.apache.org/r/60196/diff/2/ > > > Testing > --- > > done. manually checked the applications. > > > Thanks, > > Oliver Szabo > >
Re: Review Request 60196: Fail to create solr clients in Log Search / Log Feeder with openjdk8
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60196/ --- (Updated June 19, 2017, 11:52 a.m.) Review request for Ambari, Miklos Gergely and Robert Nettleton. Changes --- remove job-history file Bugs: AMBARI-21277 https://issues.apache.org/jira/browse/AMBARI-21277 Repository: ambari Description --- remvoe commons-httpclient dependency from logsearch/logfeeder Diffs (updated) - ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 49122e8 ambari-logsearch/ambari-logsearch-portal/pom.xml a439266 ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java df00c15 Diff: https://reviews.apache.org/r/60196/diff/2/ Changes: https://reviews.apache.org/r/60196/diff/1-2/ Testing --- done. manually checked the applications. Thanks, Oliver Szabo
Review Request 60196: Fail to create solr clients in Log Search / Log Feeder with openjdk8
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60196/ --- Review request for Ambari, Miklos Gergely and Robert Nettleton. Bugs: AMBARI-21277 https://issues.apache.org/jira/browse/AMBARI-21277 Repository: ambari Description --- remvoe commons-httpclient dependency from logsearch/logfeeder Diffs - ambari-infra/job-repository.db PRE-CREATION ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 49122e8 ambari-logsearch/ambari-logsearch-portal/pom.xml a439266 ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java df00c15 Diff: https://reviews.apache.org/r/60196/diff/1/ Testing --- done. manually checked the applications. Thanks, Oliver Szabo
