Re: Review Request 60744: Add python functions to get the Ambari version of the agent

2017-07-12 Thread Attila Doroszlai

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60744/#review180297
---


Ship it!




Ship It!

- Attila Doroszlai


On July 10, 2017, 4:37 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60744/
> ---
> 
> (Updated July 10, 2017, 4:37 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Andrew Onischuk, Oliver Szabo, 
> and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21435
> https://issues.apache.org/jira/browse/AMBARI-21435
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In the mpacks we may want to know the version of Ambari, for example the Log 
> Search handles it's configuration in different ways depending on it's version
> 
> 
> Diffs
> -
> 
>   ambari-common/src/main/python/ambari_commons/get_ambari_version.py 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60744/diff/3/
> 
> 
> Testing
> ---
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>



Re: Review Request 60744: Add python functions to get the Ambari version of the agent

2017-07-12 Thread Oliver Szabo

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60744/#review180293
---


Ship it!




Ship It!

- Oliver Szabo


On July 10, 2017, 2:37 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60744/
> ---
> 
> (Updated July 10, 2017, 2:37 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Andrew Onischuk, Oliver Szabo, 
> and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21435
> https://issues.apache.org/jira/browse/AMBARI-21435
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In the mpacks we may want to know the version of Ambari, for example the Log 
> Search handles it's configuration in different ways depending on it's version
> 
> 
> Diffs
> -
> 
>   ambari-common/src/main/python/ambari_commons/get_ambari_version.py 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60744/diff/3/
> 
> 
> Testing
> ---
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>



Re: Review Request 60744: Add python functions to get the Ambari version of the agent

2017-07-10 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60744/#review180062
---


Ship it!




Ship It!

- Alejandro Fernandez


On July 10, 2017, 2:37 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60744/
> ---
> 
> (Updated July 10, 2017, 2:37 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Andrew Onischuk, Oliver Szabo, 
> and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21435
> https://issues.apache.org/jira/browse/AMBARI-21435
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In the mpacks we may want to know the version of Ambari, for example the Log 
> Search handles it's configuration in different ways depending on it's version
> 
> 
> Diffs
> -
> 
>   ambari-common/src/main/python/ambari_commons/get_ambari_version.py 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60744/diff/3/
> 
> 
> Testing
> ---
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>



Re: Review Request 60744: Add python functions to get the Ambari version of the agent

2017-07-10 Thread Robert Nettleton

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60744/#review180041
---


Ship it!




Ship It!

- Robert Nettleton


On July 10, 2017, 2:37 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60744/
> ---
> 
> (Updated July 10, 2017, 2:37 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Andrew Onischuk, Oliver Szabo, 
> and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21435
> https://issues.apache.org/jira/browse/AMBARI-21435
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In the mpacks we may want to know the version of Ambari, for example the Log 
> Search handles it's configuration in different ways depending on it's version
> 
> 
> Diffs
> -
> 
>   ambari-common/src/main/python/ambari_commons/get_ambari_version.py 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60744/diff/3/
> 
> 
> Testing
> ---
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>



Re: Review Request 60744: Add python functions to get the Ambari version of the agent

2017-07-10 Thread Miklos Gergely

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60744/
---

(Updated July 10, 2017, 2:37 p.m.)


Review request for Ambari, Attila Doroszlai, Andrew Onischuk, Oliver Szabo, and 
Robert Nettleton.


Changes
---

fix summary


Summary (updated)
-

Add python functions to get the Ambari version of the agent


Bugs: AMBARI-21435
https://issues.apache.org/jira/browse/AMBARI-21435


Repository: ambari


Description
---

In the mpacks we may want to know the version of Ambari, for example the Log 
Search handles it's configuration in different ways depending on it's version


Diffs
-

  ambari-common/src/main/python/ambari_commons/get_ambari_version.py 
PRE-CREATION 


Diff: https://reviews.apache.org/r/60744/diff/3/


Testing
---

Tested on local cluster


Thanks,

Miklos Gergely