Re: Review Request 61479: Add Secure Flag to Cookie / JSESSIONID in Zeppelin

2017-08-08 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61479/#review182410
---


Ship it!




Ship It!

- venkat sairam


On Aug. 7, 2017, 8:07 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61479/
> ---
> 
> (Updated Aug. 7, 2017, 8:07 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21675
> https://issues.apache.org/jira/browse/AMBARI-21675
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The secure flag attribute must be set on session cookies containing session 
> tokens for Zeppelin Application
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-shiro-ini.xml
>  971e4af1c6 
> 
> 
> Diff: https://reviews.apache.org/r/61479/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested on CentOS6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 61479: Add Secure Flag to Cookie / JSESSIONID in Zeppelin

2017-08-07 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61479/#review182316
---


Ship it!




Ship It!

- Alejandro Fernandez


On Aug. 7, 2017, 8:07 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61479/
> ---
> 
> (Updated Aug. 7, 2017, 8:07 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21675
> https://issues.apache.org/jira/browse/AMBARI-21675
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The secure flag attribute must be set on session cookies containing session 
> tokens for Zeppelin Application
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-shiro-ini.xml
>  971e4af1c6 
> 
> 
> Diff: https://reviews.apache.org/r/61479/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested on CentOS6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Review Request 61479: Add Secure Flag to Cookie / JSESSIONID in Zeppelin

2017-08-07 Thread Prabhjyot Singh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61479/
---

Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
venkat sairam.


Bugs: AMBARI-21675
https://issues.apache.org/jira/browse/AMBARI-21675


Repository: ambari


Description
---

The secure flag attribute must be set on session cookies containing session 
tokens for Zeppelin Application


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-shiro-ini.xml
 971e4af1c6 


Diff: https://reviews.apache.org/r/61479/diff/1/


Testing
---

Manually tested on CentOS6


Thanks,

Prabhjyot Singh