Re: Review Request 62184: Log Search UI: unit tests setup

2017-09-08 Thread Oleg Nechiporenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62184/#review184966
---


Ship it!




Ship It!

- Oleg Nechiporenko


On Сен. 8, 2017, 11:43 д.п., Andrii Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62184/
> ---
> 
> (Updated Сен. 8, 2017, 11:43 д.п.)
> 
> 
> Review request for Ambari and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-21915
> https://issues.apache.org/jira/browse/AMBARI-21915
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Unit tests should be executed in headless browser.
> 2. Externalize setup for unit tests.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-web/.angular-cli.json cc74739 
>   ambari-logsearch/ambari-logsearch-web/karma.conf.js 0512808 
>   ambari-logsearch/ambari-logsearch-web/package.json 92c5043 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/app.component.spec.ts
>  bc16ea4 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.spec.ts
>  8efe320 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.spec.ts
>  5409d30 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.spec.ts
>  5d58b5c 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filter-dropdown/filter-dropdown.component.spec.ts
>  323aa56 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.spec.ts
>  2ced41e 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/login-form/login-form.component.spec.ts
>  fd54fe6 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.spec.ts
>  02c3b23 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.spec.ts
>  6c9e021 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/modal/modal.component.spec.ts
>  802bd13 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/pagination/pagination.component.spec.ts
>  7a15bbc 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.spec.ts
>  2b3a957 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/timezone-picker/timezone-picker.component.spec.ts
>  0ef17de 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/services/http-client.service.spec.ts
>  0dfb0f3 
>   ambari-logsearch/ambari-logsearch-web/src/app/test-config.spec.ts 
> PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/test.ts 6597b1c 
>   ambari-logsearch/ambari-logsearch-web/yarn.lock 4883a15 
> 
> 
> Diff: https://reviews.apache.org/r/62184/diff/1/
> 
> 
> Testing
> ---
> 
> Executed 84 of 84 SUCCESS (1.828 secs / 1.798 secs)
> 
> 
> Thanks,
> 
> Andrii Babiichuk
> 
>



Review Request 62184: Log Search UI: unit tests setup

2017-09-08 Thread Andrii Babiichuk

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62184/
---

Review request for Ambari and Oleg Nechiporenko.


Bugs: AMBARI-21915
https://issues.apache.org/jira/browse/AMBARI-21915


Repository: ambari


Description
---

1. Unit tests should be executed in headless browser.
2. Externalize setup for unit tests.


Diffs
-

  ambari-logsearch/ambari-logsearch-web/.angular-cli.json cc74739 
  ambari-logsearch/ambari-logsearch-web/karma.conf.js 0512808 
  ambari-logsearch/ambari-logsearch-web/package.json 92c5043 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/app.component.spec.ts 
bc16ea4 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.spec.ts
 8efe320 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.spec.ts
 5409d30 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.spec.ts
 5d58b5c 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filter-dropdown/filter-dropdown.component.spec.ts
 323aa56 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.spec.ts
 2ced41e 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/login-form/login-form.component.spec.ts
 fd54fe6 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.spec.ts
 02c3b23 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.spec.ts
 6c9e021 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/modal/modal.component.spec.ts
 802bd13 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/pagination/pagination.component.spec.ts
 7a15bbc 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.spec.ts
 2b3a957 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/timezone-picker/timezone-picker.component.spec.ts
 0ef17de 
  
ambari-logsearch/ambari-logsearch-web/src/app/services/http-client.service.spec.ts
 0dfb0f3 
  ambari-logsearch/ambari-logsearch-web/src/app/test-config.spec.ts 
PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web/src/test.ts 6597b1c 
  ambari-logsearch/ambari-logsearch-web/yarn.lock 4883a15 


Diff: https://reviews.apache.org/r/62184/diff/1/


Testing
---

Executed 84 of 84 SUCCESS (1.828 secs / 1.798 secs)


Thanks,

Andrii Babiichuk